[PATCH 0/2] sa8775p-ride: Describe ethernet phy IRQs

[PATCH 0/2] sa8775p-ride: Describe ethernet phy IRQs

[Andrew Halaney]

Now that the hardware can detect the IRQs, let's describe them instead
of polling the phys

Andrew Halaney (2):
  arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy0 irq
  arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy1 irq

 arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.41.0

[PATCH 1/2] arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy0 irq

[Andrew Halaney]

There's an irq hooked up, so let's describe it.

Prior to commit 9757300d2750
("pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets")
one would not see the IRQ fire, despite some (invasive) debugging
showing that the GPIO was in fact asserted, resulting in the interface
staying down.

Now that the IRQ is properly routed we can describe it.

Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
 arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
index 81a7eeb9cfcd..8fde6935cd6e 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
@@ -285,6 +285,7 @@ sgmii_phy0: phy@8 {
 			compatible = "ethernet-phy-id0141.0dd4";
 			reg = <0x8>;
 			device_type = "ethernet-phy";
+			interrupts-extended = <&tlmm 7 IRQ_TYPE_EDGE_FALLING>;
 			reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>;
 			reset-assert-us = <11000>;
 			reset-deassert-us = <70000>;
-- 
2.41.0

Re: [PATCH 1/2] arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy0 irq

[Konrad Dybcio]

On 17.08.2023 23:37, Andrew Halaney wrote:
> There's an irq hooked up, so let's describe it.
> 
> Prior to commit 9757300d2750
> ("pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets")
> one would not see the IRQ fire, despite some (invasive) debugging
> showing that the GPIO was in fact asserted, resulting in the interface
> staying down.
> 
> Now that the IRQ is properly routed we can describe it.
> 
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH 1/2] arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy0 irq

[Bartosz Golaszewski]

On Thu, Aug 17, 2023 at 11:38 PM Andrew Halaney <ahalaney@redhat.com> wrote:
>
> There's an irq hooked up, so let's describe it.
>
> Prior to commit 9757300d2750
> ("pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets")
> one would not see the IRQ fire, despite some (invasive) debugging
> showing that the GPIO was in fact asserted, resulting in the interface
> staying down.
>
> Now that the IRQ is properly routed we can describe it.
>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> index 81a7eeb9cfcd..8fde6935cd6e 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> @@ -285,6 +285,7 @@ sgmii_phy0: phy@8 {
>                         compatible = "ethernet-phy-id0141.0dd4";
>                         reg = <0x8>;
>                         device_type = "ethernet-phy";
> +                       interrupts-extended = <&tlmm 7 IRQ_TYPE_EDGE_FALLING>;
>                         reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>;
>                         reset-assert-us = <11000>;
>                         reset-deassert-us = <70000>;
> --
> 2.41.0
>

Nice!

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

[PATCH 2/2] arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy1 irq

[Andrew Halaney]

There's an irq hooked up, so let's describe it.

Prior to commit 9757300d2750
("pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets")
one would not see the IRQ fire, despite some (invasive) debugging
showing that the GPIO was in fact asserted, resulting in the interface
staying down.

Now that the IRQ is properly routed we can describe it.

Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
 arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
index 8fde6935cd6e..9760bb4b468c 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
@@ -295,6 +295,7 @@ sgmii_phy1: phy@a {
 			compatible = "ethernet-phy-id0141.0dd4";
 			reg = <0xa>;
 			device_type = "ethernet-phy";
+			interrupts-extended = <&tlmm 26 IRQ_TYPE_EDGE_FALLING>;
 			reset-gpios = <&pmm8654au_2_gpios 9 GPIO_ACTIVE_LOW>;
 			reset-assert-us = <11000>;
 			reset-deassert-us = <70000>;
-- 
2.41.0

Re: [PATCH 2/2] arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy1 irq

[Konrad Dybcio]

On 17.08.2023 23:37, Andrew Halaney wrote:
> There's an irq hooked up, so let's describe it.
> 
> Prior to commit 9757300d2750
> ("pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets")
> one would not see the IRQ fire, despite some (invasive) debugging
> showing that the GPIO was in fact asserted, resulting in the interface
> staying down.
> 
> Now that the IRQ is properly routed we can describe it.
> 
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH 2/2] arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy1 irq

[Bartosz Golaszewski]

On Thu, Aug 17, 2023 at 11:38 PM Andrew Halaney <ahalaney@redhat.com> wrote:
>
> There's an irq hooked up, so let's describe it.
>
> Prior to commit 9757300d2750
> ("pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets")
> one would not see the IRQ fire, despite some (invasive) debugging
> showing that the GPIO was in fact asserted, resulting in the interface
> staying down.
>
> Now that the IRQ is properly routed we can describe it.
>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> index 8fde6935cd6e..9760bb4b468c 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> @@ -295,6 +295,7 @@ sgmii_phy1: phy@a {
>                         compatible = "ethernet-phy-id0141.0dd4";
>                         reg = <0xa>;
>                         device_type = "ethernet-phy";
> +                       interrupts-extended = <&tlmm 26 IRQ_TYPE_EDGE_FALLING>;
>                         reset-gpios = <&pmm8654au_2_gpios 9 GPIO_ACTIVE_LOW>;
>                         reset-assert-us = <11000>;
>                         reset-deassert-us = <70000>;
> --
> 2.41.0
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 0/2] sa8775p-ride: Describe ethernet phy IRQs

[Bjorn Andersson]

On Thu, 17 Aug 2023 16:37:15 -0500, Andrew Halaney wrote:
> Now that the hardware can detect the IRQs, let's describe them instead
> of polling the phys
> 
> Andrew Halaney (2):
>   arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy0 irq
>   arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy1 irq
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy0 irq
      commit: 1ff6569b0ffe7a2e311104cb3cd841983e484ac9
[2/2] arm64: dts: qcom: sa8775p-ride: Describe sgmii_phy1 irq
      commit: 454557d0032d088b4f467f0c541f98edb01fe431

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>