From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration. Date: Tue, 25 Oct 2016 15:47:28 +0530 Message-ID: <758f206c-d0bd-6f70-da1e-42c88d6dd1f0@ti.com> References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-3-ahaslam@baylibre.com> <7f9efe9d-0912-e10a-3e45-24c5d2b455ab@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Axel Haslam Cc: Greg KH , Johan Hovold , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Alan Stern , Kevin Hilman , Sergei Shtylyov , David Lechner , manjunath.goudar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Mark Brown , Alexandre Bailon , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Tuesday 25 October 2016 03:07 PM, Axel Haslam wrote: > Hi Sekar, > > On Tue, Oct 25, 2016 at 10:10 AM, Sekhar Nori wrote: >> On Monday 24 October 2016 10:16 PM, ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org wrote: >>> From: David Lechner >>> >>> The CFGCHIP registers are used by a number of devices, so using a syscon >>> device to share them. The first consumer of this will by the phy-da8xx-usb >>> driver. >>> >>> Signed-off-by: David Lechner >>> [Axel: minor fix: change id to -1] >> >> Can you please clarify this change? There could be other syscon devices >> on the chip for other common registers. Why use the singular device-id? >> > > in the case of non DT boot, the phy driver is looking for "syscon" : > > d_phy->regmap = syscon_regmap_lookup_by_pdevname("syscon"); > > if we register the syscon driver with id = 0, the actual name of the syscon > device will be "syscon.0" and the phy driver will fail to probe, because > the strncmp match in the syscon driver (syscon_match_pdevname) > will fail. > > should i change the phy driver instead? Yes, please. Forcing only one syscon region for the whole chip will be too restrictive, I am pretty sure. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html