Re: [PATCH v2 2/3] dt-bindings: pwm: argon40,fan-hat: Document Argon40 Fan HAT

[Marek Vasut <marek.vasut@mailbox.org>]

On 6/17/25 9:49 AM, Uwe Kleine-König wrote:
> Hello Marek,

Hi,

> On Tue, Jun 17, 2025 at 02:28:01AM +0200, Marek Vasut wrote:
>> Document trivial PWM on Argon40 Fan HAT, which is a RaspberryPi
>> blower fan hat which can be controlled over I2C.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>> ---
>> Cc: "Uwe Kleine-König" <ukleinek@kernel.org>
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-pwm@vger.kernel.org
>> Cc: linux-renesas-soc@vger.kernel.org
>> ---
>> V2: Implement dedicated binding document
>> ---
>>   .../bindings/pwm/argon40,fan-hat.yaml         | 47 +++++++++++++++++++
>>   1 file changed, 47 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/pwm/argon40,fan-hat.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/argon40,fan-hat.yaml b/Documentation/devicetree/bindings/pwm/argon40,fan-hat.yaml
>> new file mode 100644
>> index 000000000000..2725eee5328c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pwm/argon40,fan-hat.yaml
>> @@ -0,0 +1,47 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pwm/argon40,fan-hat.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Argon40 Fan HAT PWM controller
>> +
>> +maintainers:
>> +  - Marek Vasut <marek.vasut+renesas@mailbox.org>
>> +
>> +description: |
>> +  The trivial PWM on Argon40 Fan HAT, which is a RaspberryPi blower fan
>> +  hat which can be controlled over I2C, generates a fixed duty cycle PWM
>> +  signal with configurable period to control the fan speed.
> 
> Did you get that right? I would have expected a fixed period and the
> parameter modifying the duty cycle?
I actually found a fixed 30 kHz period PWM at the underside of the 
device, it wasn't easy to reach. Expect a V3.