Devicetree
 help / color / mirror / Atom feed
From: Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Praveenkumar I <praveenkumar.i@oss.qualcomm.com>,
	Manikanta Mylavarapu <manikanta.mylavarapu@oss.qualcomm.com>
Subject: Re: [PATCH 0/2] Add CDSP Power Manangement Driver
Date: Tue, 26 May 2026 13:19:15 +0530	[thread overview]
Message-ID: <75a9fec5-20b2-496f-a365-2b1201fcbd60@oss.qualcomm.com> (raw)
In-Reply-To: <20260520-precious-notorious-hyena-7ba95b@quoll>



On 5/20/2026 4:14 PM, Krzysztof Kozlowski wrote:
> On Wed, May 20, 2026 at 12:35:08AM +0530, Vignesh Viswanathan wrote:
>> On platforms like IPQ9650, the CDSP subsystem cannot manage its own power
>> rails and requires the APSS to handle power management on its behalf. Add a
>> platform driver to fulfill this role.
>>
>> Handle LPM (Low Power Mode) by executing hardware isolation and restoration
>> sequences via MPM register programming, coordinated with the NSP Q6 through
>> a handshake protocol. Support both FULL_PC (CX+MX collapse) and LONG_APCR
>> (CX-only) modes, detected dynamically at runtime.
>>
>> Handle DCVS (Dynamic Clock and Voltage Scaling) requests from the NSP Q6
>> received via a shared SMEM channel. Apply voltages via the regulator
>> framework and write responses back to SMEM.
>>
>> Expose virtual cdsp-vdd-cx and cdsp-vdd-mx regulators so that the PAS
>> remoteproc driver can control the NSP power rails through the standard
>> regulator framework.
>>
>> This driver functionally depends on [1] for bringing up the CDSP on
>> IPQ9650, but there is no compile time dependency.
>>
>> [1] https://lore.kernel.org/linux-arm-msm/20260519-mp8899-regulator-driver-v1-0-30d14421b7f1@oss.qualcomm.com/T/#t
>>
>> ---
>> Praveenkumar I (1):
>>       soc: qcom: Add CDSP power management driver
> 
> Power management drivers CANNOT go to drivers/soc.

Ack.

> 
>>
>> Vignesh Viswanathan (1):
>>       dt-bindings: soc: qcom: Document CDSP Power Management
> 
> Neither to bindings soc.

Ack, As per Bjorn's review, this CDSP power management driver + standard PAS
driver will be a non-standard implementation and I'm looking at moving this
into a new remoteproc driver. Will address in next version.

Thanks,
Vignesh

> 
> Best regards,
> Krzysztof
> 


      reply	other threads:[~2026-05-26  7:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 19:05 [PATCH 0/2] Add CDSP Power Manangement Driver Vignesh Viswanathan
2026-05-19 19:05 ` [PATCH 1/2] dt-bindings: soc: qcom: Document CDSP Power Management Vignesh Viswanathan
2026-05-19 19:17   ` sashiko-bot
2026-05-20  9:59   ` Konrad Dybcio
2026-05-26  7:38     ` Vignesh Viswanathan
2026-06-16 12:27       ` Konrad Dybcio
2026-05-20 10:43   ` Krzysztof Kozlowski
2026-05-20 10:46     ` Krzysztof Kozlowski
2026-05-26  7:46       ` Vignesh Viswanathan
2026-05-21 23:29   ` Bjorn Andersson
2026-05-26  7:57     ` Vignesh Viswanathan
2026-06-17  4:39       ` Krzysztof Kozlowski
2026-05-19 19:05 ` [PATCH 2/2] soc: qcom: Add CDSP power management driver Vignesh Viswanathan
2026-05-19 19:43   ` sashiko-bot
2026-05-20 10:50   ` Krzysztof Kozlowski
2026-05-26  7:49     ` Vignesh Viswanathan
2026-05-22  2:49   ` Bjorn Andersson
2026-05-26  8:00     ` Vignesh Viswanathan
2026-05-20 10:44 ` [PATCH 0/2] Add CDSP Power Manangement Driver Krzysztof Kozlowski
2026-05-26  7:49   ` Vignesh Viswanathan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75a9fec5-20b2-496f-a365-2b1201fcbd60@oss.qualcomm.com \
    --to=vignesh.viswanathan@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manikanta.mylavarapu@oss.qualcomm.com \
    --cc=praveenkumar.i@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox