From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AF3F137C26 for ; Wed, 17 Apr 2024 09:52:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713347534; cv=none; b=D6sTLOzzcETkAMgsfczA8bGbDzOf/sltITzym9vXcEgnvAciyeM2Nat+2Zr5jNrlx0SdlvhG6hah0jr4hKW5i4mCkNqvlb+xF8Hd5CePUW6LQJwhl43C+My06eOliCvSla0sBu1uyEb5E3zOXT92b2qfNugn4Dm16IlGgIFR7mw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713347534; c=relaxed/simple; bh=3X6WwNfAVR7FMkoaL54r/zUW5zJ1gH7cm4+/P1mg7j0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pwnn5iwvrRwjJpzDtaGJlHBquXpJBTlFta1VORI8zJxqyTNdOAVn1/1GrOp+QzjLRHWSOzhyLi0KVn4uzFgqnHi5sTr2iak2wK7XzHDripitdIPkYOiH3wP4wqV5DFPChKhb4ycNJDCHeeATHvOYuKKbBbNw5EWlA2fxdvMIkAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fGY39utO; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fGY39utO" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5708d8a773aso272639a12.3 for ; Wed, 17 Apr 2024 02:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713347531; x=1713952331; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5f5XU8CL1kg+VvVC0mF3oI+N9DcL6GD1pDu7yNmuO1Q=; b=fGY39utO6irKOll8izO+7MR1eqH1lbzYw2D+KRkJoY2GDZ1weRqAekMVOf0hw/bdXd PzHupGVCXJkwYGv1UpqG+56mMCXm+Cg0FLX/BHOP49/+P3UzNBlDJArd9RQlCRVczfRg zCXihgKHtNnRETbVT0LpeF5+pZ3WBuxNjhOJpZ5iJScAzOlWCSTIyRbF/G9Gt/uAqyBj Kyl8j2RUwiDAuiDPftEVv0g1ZDNlEJz4qEGCIubiZvQIYMIgw5aJwM0I4wwoTGjkO4Ny EbuHnLpmot0+NwjF7D5KxOtWFzrV3Xa3Nhar4+MWhPJDnEr3g0vYEMDIGFWf6hBHTUxc 9XAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713347531; x=1713952331; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5f5XU8CL1kg+VvVC0mF3oI+N9DcL6GD1pDu7yNmuO1Q=; b=tHtp8sUwRjsL3ypTtl9F7mee4BGdqAIJ+FcrG7vfhwc2OdVwmHx695imvcxhPVP9iW 00siRmP0AuJgo8Jh4/dfElYWRXlgw/mGafkLM3eBjphq8w4shXp9NrzwTUilDB8+3IuK gkQiSbgBzCLItdyOdhJPG3a5CZeKI0DNMuyssKKdUhptKNlAj82G7qAYZpWnN3swuW1p 5Da8Kh5wA3aYmUDpUexs3fvbxqC6y92aydLAJ1uBuUwpF9wtCcasLDf0AJG1lRlbOL8g nEGE6mN0ffFEeNvzQi+8pmt6PqJSfEOE04hlkCFvcp0JEElREAJYP1oR+0/vy84gKEU1 3M6g== X-Forwarded-Encrypted: i=1; AJvYcCW/BQiyBfe+4i61k823dTeYMpWbyPcMAfvQvPfHov3JxmWER4l+tLS+TviXD7pLN795NMsnbWiW6bJ04kJIbD/B2spx/OObPEaMOw== X-Gm-Message-State: AOJu0Yx6ot/73AEEcCRyF2tKOcBs2ULBt8Z3+Ljy/x3rolxQQHaXcypq bzwkjFzza7JdMYgJ11cHbf3EdE0TzbTNEm393rDwpKSc+QX9ozY9X11nM2TYkSU= X-Google-Smtp-Source: AGHT+IEYPrQEauvIgRMeVjGwsmiUGzuIZo8hcH8ym7d63O1kdjEGb0XdYaDBVBXRGhRdHQrpHYNOWg== X-Received: by 2002:a17:907:7d91:b0:a54:1c55:7123 with SMTP id oz17-20020a1709077d9100b00a541c557123mr5905226ejc.73.1713347531118; Wed, 17 Apr 2024 02:52:11 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id t6-20020a1709067c0600b00a5229c51077sm7414958ejo.9.2024.04.17.02.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 02:52:10 -0700 (PDT) Date: Wed, 17 Apr 2024 12:52:07 +0300 From: Dan Carpenter To: Peter Griffin Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, kishon@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, s.nawrocki@samsung.com, cw00.choi@samsung.com, jejb@linux.ibm.com, martin.petersen@oracle.com, chanho61.park@samsung.com, ebiggers@kernel.org, linux-scsi@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com Subject: Re: [PATCH 10/17] phy: samsung-ufs: ufs: Add SoC callbacks for calibration and clk data recovery Message-ID: <75b1b063-e8d4-417d-99a8-4320d72297cf@moroto.mountain> References: <20240404122559.898930-1-peter.griffin@linaro.org> <20240404122559.898930-11-peter.griffin@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240404122559.898930-11-peter.griffin@linaro.org> On Thu, Apr 04, 2024 at 01:25:52PM +0100, Peter Griffin wrote: > diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c > index c567efafc30f..f57a2f2a415d 100644 > --- a/drivers/phy/samsung/phy-samsung-ufs.c > +++ b/drivers/phy/samsung/phy-samsung-ufs.c > @@ -46,7 +46,7 @@ static void samsung_ufs_phy_config(struct samsung_ufs_phy *phy, > } > } > > -static int samsung_ufs_phy_wait_for_lock_acq(struct phy *phy) > +int samsung_ufs_phy_wait_for_lock_acq(struct phy *phy, u8 lane) > { > struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); > const unsigned int timeout_us = 100000; > @@ -98,8 +98,15 @@ static int samsung_ufs_phy_calibrate(struct phy *phy) > } > } > > - if (ufs_phy->ufs_phy_state == CFG_POST_PWR_HS) > - err = samsung_ufs_phy_wait_for_lock_acq(phy); > + for_each_phy_lane(ufs_phy, i) { > + if (ufs_phy->ufs_phy_state == CFG_PRE_INIT && > + ufs_phy->drvdata->wait_for_cal) > + err = ufs_phy->drvdata->wait_for_cal(phy, i); > + > + if (ufs_phy->ufs_phy_state == CFG_POST_PWR_HS && > + ufs_phy->drvdata->wait_for_cdr) > + err = ufs_phy->drvdata->wait_for_cdr(phy, i); The "err" value is only preserved from the last iteration in this loop. regards, dan carpenter > + } > > /** > * In Samsung ufshci, PHY need to be calibrated at different