From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 7.mo560.mail-out.ovh.net (7.mo560.mail-out.ovh.net [188.165.48.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB3C61487DC for ; Tue, 24 Sep 2024 09:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.165.48.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727171762; cv=none; b=LWZOAcg+MC95nLmAmgNvrFKIBe3MGLsTtdO/obiTWVIhKgucXYAFaZpsupcBAVoLUngJ7/kW6RaZ72TUYpl0nkw5X5myO6nLzxskf/6/Pd8yMsgy243jpm10oSU518HK/BhqY5fndl8/ewhlHfLRrNskvbZ/sm6uSz4cUhBFL+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727171762; c=relaxed/simple; bh=BnNTOClk37Yx5kmE3nkdR71wySOFIiN6hExvBSLNF8Q=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=Ypil2ClhRQwy+VrmGTvUVEDPg6wjIZPSXfiX2rm35HaQ1x3tTVdmWsgppAvr+ZUJyj1oCNCjf6bIqjAKxPT7aCOq3iweOXcX6R260l1rR9v+EqzUX8ZQSWSHayhoaofZCYnGhKfHlUV+GOx2SxxBdjqZeMq9ukFndRylo9GleMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=milecki.pl; spf=pass smtp.mailfrom=milecki.pl; dkim=pass (2048-bit key) header.d=milecki.pl header.i=@milecki.pl header.b=H4Qq7VYD; arc=none smtp.client-ip=188.165.48.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=milecki.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=milecki.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=milecki.pl header.i=@milecki.pl header.b="H4Qq7VYD" Received: from director6.ghost.mail-out.ovh.net (unknown [10.108.17.147]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 4XCZxK5sLPz1mNB for ; Tue, 24 Sep 2024 09:55:49 +0000 (UTC) Received: from ghost-submission-55b549bf7b-5q9lx (unknown [10.110.164.235]) by director6.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 3B7A11FE9B; Tue, 24 Sep 2024 09:55:47 +0000 (UTC) Received: from milecki.pl ([37.59.142.101]) by ghost-submission-55b549bf7b-5q9lx with ESMTPSA id AqzIBaOM8mZcgQAA+u7rcQ (envelope-from ); Tue, 24 Sep 2024 09:55:47 +0000 Authentication-Results:garm.ovh; auth=pass (GARM-101G004d3854881-9240-4405-bcc0-c07042d02785, 1AB79004D049CCABD2FE35BF073248474FDEF107) smtp.auth=rafal@milecki.pl X-OVh-ClientIp:151.80.29.20 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 24 Sep 2024 11:55:44 +0200 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Sandie Cao Cc: Conor Dooley , Emil Renner Berthing , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Stuebner , Neil Armstrong , Linus Walleij , Michael Zhu , Drew Fustini , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dhs@frame.work, ams@frame.work, gregkh@linuxfoundation.org, yuning.liang@deepcomputing.io, huiming.qiu@deepcomputing.io Subject: Re: [patch v2 3/3] riscv: dts: starfive: add framework dts In-Reply-To: <20240924080650.1345485-4-sandie.cao@deepcomputing.io> References: <20240924080650.1345485-4-sandie.cao@deepcomputing.io> Message-ID: <75d4f0395187f7950e0450a91fbe087d@milecki.pl> X-Sender: rafal@milecki.pl X-Webmail-UserID: rafal@milecki.pl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 10134506538491882359 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeeftddrvddtvddgvdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvvefujghfkfigihgtgfesthekjhdttddtjeenucfhrhhomheptfgrfhgrlhcuofhilhgvtghkihcuoehrrghfrghlsehmihhlvggtkhhirdhplheqnecuggftrfgrthhtvghrnhepjeejkeekgeejtdffffevffeivedtueeifeeuffegkeehkeeliedugfelfedutdeunecukfhppeduvdejrddtrddtrddupdefuddruddurddvudekrddutdeipdduhedurdektddrvdelrddvtddpfeejrdehledrudegvddruddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomheprhgrfhgrlhesmhhilhgvtghkihdrphhlpdhnsggprhgtphhtthhopedupdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehiedtpdhmohguvgepshhmthhpohhuth DKIM-Signature: a=rsa-sha256; bh=jffzDI9wqpTBxYh402/WuPcxuVwvyleh09GDw3XTbs0=; c=relaxed/relaxed; d=milecki.pl; h=From; s=ovhmo3028686-selector1; t=1727171750; v=1; b=H4Qq7VYDRzRWv9WFaKeW1C47OolejEPczUMrO/b5LLTjo2+5Z3m5nY+1cHFcCufYPh5t/6hk oMrRFbUEq/f2QprP1TO9UxEXsV2uwjvrBk3XxOGOfYSh5lvYxK8q5do3FJoXGkBQVlCRRl3O1+G j3wAt0duT4a3RN+jaHXNimzKu2hN9qKAr153r4ypR60sYAP9fibB4gSaWR9PBsawYGFcpDlscQ4 5UZk7IOgZuy4uu+Q+0HWZBAFmDEiCqhUShtiId4/icFcn0eloP/h2br97bFgUBxA3/YVg3IvwQ+ qqLrPsjwzccFcyJdJRsf9qwltIPJWn42N5B7jCN4YUvKg== On 2024-09-24 10:06, Sandie Cao wrote: > diff --git a/arch/riscv/boot/dts/starfive/jh7110-framework.dts > b/arch/riscv/boot/dts/starfive/jh7110-framework.dts > new file mode 100644 > index 000000000000..ff12c24ebab3 > --- /dev/null > +++ b/arch/riscv/boot/dts/starfive/jh7110-framework.dts > @@ -0,0 +1,34 @@ > +// SPDX-License-Identifier: GPL-2.0 OR MIT > +/* > + * Copyright (C) 2022 StarFive Technology Co., Ltd. > + * Copyright (C) 2022 Emil Renner Berthing > + */ > + > +/dts-v1/; > +#include "jh7110-common.dtsi" > + > +/ { > + model = "Framework FRANME0000"; > + compatible = "deepcomputing,fm7110", "starfive,jh7110"; > +}; Nitpicking: property "compatible" should go first. See Documentation/devicetree/bindings/dts-coding-style.rst -- Rafał Miłecki