From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7309EC433EF for ; Wed, 13 Jul 2022 14:32:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234652AbiGMOcH (ORCPT ); Wed, 13 Jul 2022 10:32:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233865AbiGMOcG (ORCPT ); Wed, 13 Jul 2022 10:32:06 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 135443718A; Wed, 13 Jul 2022 07:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657722725; x=1689258725; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=2J6SXMWdLRY7k+Xu1M4COjz6hfN05sGZcty/Ghsevy8=; b=UUH+J11vKEtCi5lTeZbfIrwFel5xAeH6CSrktwn/MeI12TSsLLOFdC7x l8n76fzuo9S/vSXt+P5MAx72419uqgM2apOmrJAOqbPTin+QW77umVbcC rdU/y9oTU2d4f+iiFrpBKpZ636c/4/1XdaIPx26tSolarWdt2uW/s2yqu H70umfn8NM1JC1vbQ2M9sNzvKl0lx2/DOn30NehkLd6ih48O+vtAiGT/w AESa4meP9Nq0XdHMKIomjIM3YXoM8DtV2c76JdcgYcpnBQZ1Fv9hOF6J5 WfCkLSxt2OX+4NXKHSS9IyOYOohrmWd9FVxP8AmbGAWLq3ShiL0dFIPrC g==; X-IronPort-AV: E=McAfee;i="6400,9594,10407"; a="265637981" X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="265637981" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 07:31:55 -0700 X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="593010229" Received: from melanief-mobl.amr.corp.intel.com (HELO [10.212.10.37]) ([10.212.10.37]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 07:31:53 -0700 Message-ID: <75e9b775-3bbe-0b34-2bd6-b4ac74620672@linux.intel.com> Date: Wed, 13 Jul 2022 09:23:28 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.10.0 Subject: Re: [PATCH] soundwire: qcom: Update error prints to debug prints Content-Language: en-US To: Srinivasa Rao Mandadapu , vkoul@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@quicinc.com, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org References: <1657714921-28072-1-git-send-email-quic_srivasam@quicinc.com> From: Pierre-Louis Bossart In-Reply-To: <1657714921-28072-1-git-send-email-quic_srivasam@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 7/13/22 07:22, Srinivasa Rao Mandadapu wrote: > Upadte error prints to debug prints to avoid redundant logging in kernel update > boot time, as these prints are informative prints in irq handler. > > Signed-off-by: Srinivasa Rao Mandadapu > --- > drivers/soundwire/qcom.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index 9df970e..a4293d0 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) > break; > case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED: > case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS: > - dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n", > - __func__); > + dev_dbg(swrm->dev, "%s: SWR new slave attached\n", __func__); any reason why the rate limitation was dropped? > swrm->reg_read(swrm, SWRM_MCP_SLV_STATUS, &slave_status); > if (swrm->slave_status == slave_status) { > - dev_err(swrm->dev, "Slave status not changed %x\n", > + dev_dbg(swrm->dev, "Slave status not changed %x\n", > slave_status); > } else { > qcom_swrm_get_device_status(swrm);