From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Robert Foss <robert.foss@linaro.org>,
robdclark@gmail.com, quic_abhinavk@quicinc.com,
dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@linux.ie,
daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, agross@kernel.org,
bjorn.andersson@linaro.org, quic_kalyant@quicinc.com,
swboyd@chromium.org, angelogioacchino.delregno@somainline.org,
loic.poulain@linaro.org, quic_khsieh@quicinc.com,
quic_vpolimer@quicinc.com, vkoul@kernel.org,
dianders@chromium.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Marek <jonathan@marek.ca>,
vinod.koul@linaro.org, quic_jesszhan@quicinc.com,
andersson@kernel.org
Subject: Re: [PATCH v2 09/12] arm64: dts: qcom: sm8350: Use 2 interconnect cells
Date: Tue, 15 Nov 2022 14:45:14 +0100 [thread overview]
Message-ID: <760918b4-e94e-38b0-8a66-629f2eaf89af@linaro.org> (raw)
In-Reply-To: <20221115133105.980877-10-robert.foss@linaro.org>
On 15/11/2022 14:31, Robert Foss wrote:
> Use two interconnect cells in order to optionally
> support a path tag.
>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index 805d53d91952..434f8e8b12c1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -1543,56 +1543,56 @@ apps_smmu: iommu@15000000 {
> config_noc: interconnect@1500000 {
> compatible = "qcom,sm8350-config-noc";
> reg = <0 0x01500000 0 0xa580>;
> - #interconnect-cells = <1>;
> + #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> mc_virt: interconnect@1580000 {
> compatible = "qcom,sm8350-mc-virt";
> reg = <0 0x01580000 0 0x1000>;
> - #interconnect-cells = <1>;
> + #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> system_noc: interconnect@1680000 {
> compatible = "qcom,sm8350-system-noc";
> reg = <0 0x01680000 0 0x1c200>;
> - #interconnect-cells = <1>;
> + #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> aggre1_noc: interconnect@16e0000 {
> compatible = "qcom,sm8350-aggre1-noc";
> reg = <0 0x016e0000 0 0x1f180>;
> - #interconnect-cells = <1>;
> + #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> aggre2_noc: interconnect@1700000 {
> compatible = "qcom,sm8350-aggre2-noc";
> reg = <0 0x01700000 0 0x33000>;
> - #interconnect-cells = <1>;
> + #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> mmss_noc: interconnect@1740000 {
> compatible = "qcom,sm8350-mmss-noc";
> reg = <0 0x01740000 0 0x1f080>;
> - #interconnect-cells = <1>;
> + #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> lpass_ag_noc: interconnect@3c40000 {
> compatible = "qcom,sm8350-lpass-ag-noc";
> reg = <0 0x03c40000 0 0xf080>;
> - #interconnect-cells = <1>;
> + #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> compute_noc: interconnect@a0c0000{
> compatible = "qcom,sm8350-compute-noc";
> reg = <0 0x0a0c0000 0 0xa180>;
> - #interconnect-cells = <1>;
> + #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> @@ -1620,8 +1620,8 @@ ipa: ipa@1e40000 {
> clocks = <&rpmhcc RPMH_IPA_CLK>;
> clock-names = "core";
>
> - interconnects = <&aggre2_noc MASTER_IPA &mc_virt SLAVE_EBI1>,
> - <&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_IPA_CFG>;
> + interconnects = <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>,
> + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_IPA_CFG 0>;
> interconnect-names = "memory",
> "config";
>
> @@ -1661,7 +1661,7 @@ mpss: remoteproc@4080000 {
> <&rpmhpd SM8350_MSS>;
> power-domain-names = "cx", "mss";
>
> - interconnects = <&mc_virt MASTER_LLCC &mc_virt SLAVE_EBI1>;
> + interconnects = <&mc_virt MASTER_LLCC &mc_virt SLAVE_EBI1 0>;
>
> memory-region = <&pil_modem_mem>;
>
> @@ -2239,7 +2239,7 @@ cdsp: remoteproc@98900000 {
> <&rpmhpd SM8350_MXC>;
> power-domain-names = "cx", "mxc";
>
> - interconnects = <&compute_noc MASTER_CDSP_PROC &mc_virt SLAVE_EBI1>;
> + interconnects = <&compute_noc MASTER_CDSP_PROC 0 &mc_virt SLAVE_EBI1 0>;
>
> memory-region = <&pil_cdsp_mem>;
>
> @@ -2421,14 +2421,14 @@ usb_2_ssphy: phy@88ebe00 {
> dc_noc: interconnect@90c0000 {
> compatible = "qcom,sm8350-dc-noc";
> reg = <0 0x090c0000 0 0x4200>;
> - #interconnect-cells = <1>;
> + #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> gem_noc: interconnect@9100000 {
> compatible = "qcom,sm8350-gem-noc";
> reg = <0 0x09100000 0 0xb4000>;
> - #interconnect-cells = <1>;
> + #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
next prev parent reply other threads:[~2022-11-15 13:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 13:30 [PATCH v2 00/12] Enable Display for SM8350 Robert Foss
2022-11-15 13:30 ` [PATCH v2 01/12] dt-bindings: display: msm: Add qcom,sm8350-dpu binding Robert Foss
2022-11-16 14:59 ` Rob Herring
2022-11-15 13:30 ` [PATCH v2 02/12] dt-bindings: display: msm: Add qcom,sm8350-mdss binding Robert Foss
2022-11-15 13:30 ` [PATCH v2 03/12] drm/msm/dpu: Refactor sc7280_pp location Robert Foss
2022-11-15 13:33 ` Konrad Dybcio
2022-11-25 6:05 ` [Freedreno] " Abhinav Kumar
2022-11-17 13:37 ` Abhinav Kumar
2022-11-15 13:30 ` [PATCH v2 04/12] drm/msm/dpu: Add SM8350 to hw catalog Robert Foss
2022-11-15 13:40 ` Konrad Dybcio
2022-11-29 11:48 ` Robert Foss
2022-11-15 13:30 ` [PATCH v2 05/12] drm/msm/dpu: Add support for SM8350 Robert Foss
2022-11-15 13:30 ` [PATCH v2 06/12] drm/msm: " Robert Foss
2022-11-15 13:42 ` Konrad Dybcio
2022-11-29 11:40 ` Robert Foss
2022-11-15 13:31 ` [PATCH v2 07/12] arm64: dts: qcom: sm8350: Add &tlmm gpio-line-names Robert Foss
2022-11-15 13:31 ` [PATCH v2 08/12] arm64: dts: qcom: sm8350: Remove mmxc power-domain-name Robert Foss
2022-11-15 13:44 ` Konrad Dybcio
2022-11-15 13:31 ` [PATCH v2 09/12] arm64: dts: qcom: sm8350: Use 2 interconnect cells Robert Foss
2022-11-15 13:45 ` Konrad Dybcio [this message]
2022-11-15 13:31 ` [PATCH v2 10/12] arm64: dts: qcom: sm8350: Add display system nodes Robert Foss
2022-11-15 13:47 ` Konrad Dybcio
2022-11-29 16:47 ` Robert Foss
2022-11-29 19:59 ` Dmitry Baryshkov
2022-11-15 13:31 ` [PATCH v2 11/12] arm64: dts: qcom: sm8350-hdk: Enable display & dsi nodes Robert Foss
2022-11-15 13:31 ` [PATCH v2 12/12] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge Robert Foss
2022-11-15 15:23 ` [PATCH v2 00/12] Enable Display for SM8350 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=760918b4-e94e-38b0-8a66-629f2eaf89af@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_vpolimer@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).