From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AB25B1A9FAB; Wed, 10 Sep 2025 19:30:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757532640; cv=none; b=Y3ABK7RyiIo+c3mqBse0LNvuOFyyh8Nx0dInXt+4J9I8KBzBl4lK6cTAV7Dj6BSrKIaR+YKl/X4iUNl0QEmT0YkOdFWxiDIF/kW99v8Udpt0XKZcRs+69l7ptkS+X5nWqpXvaF/0SxbOwfr5unLM3COKRlRZ0NOyHbmgW9y43Q4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757532640; c=relaxed/simple; bh=CFkFFhuK4a4sgSNf/dIg9P4rxUjRSaINRvr5UWYmgy4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K+iR4Go4uaZB6Dw4ys2UuxLi8aKgemsG/Z4gZWZlyGVvDxUm9Hyo13lLRXgAgp+r5Xtjjv/s7NsKnKSj/I3lqQCtGHYiNXMwHLJy2mAsqSonzwDXF48ncleuLZhu4C5Ynivsn8QtKL/zNqx53xg465vtEtpJppqboHie3inJ0xo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A97A016F8; Wed, 10 Sep 2025 12:30:28 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 093773F694; Wed, 10 Sep 2025 12:30:30 -0700 (PDT) Message-ID: <761245fb-a045-4809-9fd9-5efc56794b37@arm.com> Date: Wed, 10 Sep 2025 20:30:29 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 27/33] arm_mpam: Add mpam_msmon_read() to read monitor value To: Ben Horgan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org Cc: shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250822153048.2287-1-james.morse@arm.com> <20250822153048.2287-28-james.morse@arm.com> Content-Language: en-GB From: James Morse In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Ben, On 29/08/2025 16:55, Ben Horgan wrote: > On 8/22/25 16:30, James Morse wrote: >> Reading a monitor involves configuring what you want to monitor, and >> reading the value. Components made up of multiple MSC may need values >> from each MSC. MSCs may take time to configure, returning 'not ready'. >> The maximum 'not ready' time should have been provided by firmware. >> >> Add mpam_msmon_read() to hide all this. If (one of) the MSC returns >> not ready, then wait the full timeout value before trying again. >> diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c >> index e7e00c632512..9ce771aaf671 100644 >> --- a/drivers/resctrl/mpam_devices.c >> +++ b/drivers/resctrl/mpam_devices.c >> @@ -973,6 +973,228 @@ static int mpam_msc_hw_probe(struct mpam_msc *msc) >> +static void gen_msmon_ctl_flt_vals(struct mon_read *m, u32 *ctl_val, >> + u32 *flt_val) >> +{ >> + struct mon_cfg *ctx = m->ctx; >> + >> + switch (m->type) { >> + case mpam_feat_msmon_csu: >> + *ctl_val = MSMON_CFG_CSU_CTL_TYPE_CSU; >> + break; >> + case mpam_feat_msmon_mbwu: >> + *ctl_val = MSMON_CFG_MBWU_CTL_TYPE_MBWU; >> + break; >> + default: >> + return; >> + } >> + >> + /* >> + * For CSU counters its implementation-defined what happens when not >> + * filtering by partid. >> + */ >> + *ctl_val |= MSMON_CFG_x_CTL_MATCH_PARTID; >> + >> + *flt_val = FIELD_PREP(MSMON_CFG_MBWU_FLT_PARTID, ctx->partid); >> + if (m->ctx->match_pmg) { >> + *ctl_val |= MSMON_CFG_x_CTL_MATCH_PMG; >> + *flt_val |= FIELD_PREP(MSMON_CFG_MBWU_FLT_PMG, ctx->pmg); >> + } > As we are using MSMON_CFG_MBWU_FLT_{PMG,PARTID} for both CSU and MBWU > how about changing to MSMON_CFG_x_FLT_{PMG,PARTID}? Sure, >> + >> + if (mpam_has_feature(mpam_feat_msmon_mbwu_rwbw, &m->ris->props)) >> + *flt_val |= FIELD_PREP(MSMON_CFG_MBWU_FLT_RWBW, ctx->opts); > This needs to be conditional on the type of the monitor being > configured. There is an XCL bit here for CSU monitors. Fixed ... that wasn't there last time I looked! I may as well wire that up too... Thanks, James