From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Schulz Subject: Re: [PATCH v4 11/18] dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding Date: Wed, 15 Mar 2017 23:41:07 +0100 Message-ID: <761e35fc-932a-953c-cfad-7e967ea3d126@free-electrons.com> References: <20170315105537.22349-1-quentin.schulz@free-electrons.com> <20170315105537.22349-12-quentin.schulz@free-electrons.com> <20170315222852.z2qrwoexcsjt7vs6@earth> Reply-To: quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H3os4bRIrK53VTemfr3cVwqJmWoK8aCHk" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170315222852.z2qrwoexcsjt7vs6@earth> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Sebastian Reichel Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, liam-RYWXG+zxWwBdeoIcmNTgJF6hYfS7NtTn@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bonbons-ud5FBsm0p/xEiooADzr8i9i2O/JbrIOy@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, icenowy-ymACFijhrKM@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --H3os4bRIrK53VTemfr3cVwqJmWoK8aCHk Content-Type: multipart/mixed; boundary="0Sst19kenI6FG2oi1qAkJvwGB29PVAlgF"; protected-headers="v1" From: Quentin Schulz To: Sebastian Reichel Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, liam-RYWXG+zxWwBdeoIcmNTgJF6hYfS7NtTn@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bonbons-ud5FBsm0p/xEiooADzr8i9i2O/JbrIOy@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, icenowy-ymACFijhrKM@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Message-ID: <761e35fc-932a-953c-cfad-7e967ea3d126-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Subject: Re: [PATCH v4 11/18] dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding References: <20170315105537.22349-1-quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> <20170315105537.22349-12-quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> <20170315222852.z2qrwoexcsjt7vs6@earth> In-Reply-To: <20170315222852.z2qrwoexcsjt7vs6@earth> --0Sst19kenI6FG2oi1qAkJvwGB29PVAlgF Content-Type: text/plain; charset=UTF-8 Hi, On 15/03/2017 23:28, Sebastian Reichel wrote: > Hi, > > On Wed, Mar 15, 2017 at 11:55:30AM +0100, Quentin Schulz wrote: >> The X-Powers AXP20X and AXP22X PMICs can have a battery as power supply. >> >> This patch adds the DT binding documentation for the battery power >> supply which gets various data from the PMIC, such as the battery status >> (charging, discharging, full, dead), current max limit, current current, >> battery capacity (in percentage), voltage max and min limits, current >> voltage and battery capacity (in Ah). >> >> Signed-off-by: Quentin Schulz >> Acked-by: Chen-Yu Tsai >> Acked-by: Maxime Ripard > > I suggest to do "s/battery-power-supply/battery-fuel-gauge/g" > The IP is way more than a simple fuel gauge, you have info about the voltage, current, you can set different things, even though you have the percentage of the battery returned by the PMIC. Does it really make sense to rename it that way? Thanks, Quentin >> --- >> >> v4: >> - added monitored-battery optional property, >> - added example with battery, >> >> v3: >> - removed constant charge current property, now should use the WIP >> battery framework, >> >> v2: >> - changed DT node name from ac_power_supply to ac-power-supply, > > ac-power-supply? > > -- Sebastian > >> - removed io-channels and io-channel-names from DT (the IIO mapping is >> done in the IIO ADC driver now), >> - added x-powers,constant-charge-current property to set the maximal >> default constant current charge of the battery, >> .../bindings/power/supply/axp20x_battery.txt | 30 ++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/supply/axp20x_battery.txt >> >> diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt >> new file mode 100644 >> index 0000000..89cb7a2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt >> @@ -0,0 +1,30 @@ >> +AXP20x and AXP22x battery power supply >> + >> +Required Properties: >> + - compatible, one of: >> + "x-powers,axp209-battery-power-supply" >> + "x-powers,axp221-battery-power-supply" >> + >> +Optional properties: >> + - monitored-battery, phandle to a fixed battery >> + >> +This node is a subnode of the axp20x/axp22x PMIC. >> + >> +The AXP20X and AXP22X can read the battery voltage, charge and discharge >> +currents of the battery by reading ADC channels from the AXP20X/AXP22X >> +ADC. >> + >> +Example: >> + >> +battery: battery { >> + compatible = "fixed-battery"; >> + voltage-min-design-microvolt = <3200000>; >> + constant-charge-microamp = <300000>; >> +}; >> + >> +&axp209 { >> + battery_power_supply: battery-power-supply { >> + compatible = "x-powers,axp209-battery-power-supply"; >> + monitored-battery = <&battery>; >> + } >> +}; >> -- >> 2.9.3 >> >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. --0Sst19kenI6FG2oi1qAkJvwGB29PVAlgF-- --H3os4bRIrK53VTemfr3cVwqJmWoK8aCHk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYycMMAAoJEIS4mnU+4PGjzcsQAJRtlufCHWMn03WGB9V9Ibwi pwnl82TYBSztc64+4Y2QqqvM5NwE9o8UxMuqh15bgk7SDsUDq0n46fgWCBnmj+7l 5P+xngQt3CyGE1SejU1TGejoqKjfIuUbFblbsSDq1U3UrjXKa29LQqORx6xeaA4N nt101TfIReAN/rKqkcFRb01ZP4JzvV3sIfwopehQbl2j0qF/PxR/j9231P8z+Rzy UOu3LPxdNVzKe6pSpT80nqexnsp3KUUONgtB1NIhVknlQF1CqtR7E2TpXDm76HG1 jsl7hGPln6jBblJr8eOKOu9KX1aBoy/6YeGT6haURgyEIZ8NoCMtBFgAs2NWamTf VKqjwOoFcg1DejJebBD3gjokf+5ok9komYLaQfEPy8WzHtoGQZ1MDcL3IbjwtSvH dz4Ok3060yDjpyrZTrrDwZioxC39oG2fJarbDTItw3jBv4yABMYDfD2GskLg7Q1C Ka3J3Bj2FSGYecNsWNq631CFOWP9uPus6juABIc/X9vhZZHXsQ1LXM8aFOneRWcM Pcm+Du+ITcAz1+BkaMR/IYTe5hNqOsRSvryPrlWj+91GsOqNKQxmpdPHtiI0cUU9 khkhxeVt5Rth9UICSkbhM7nOZSIw7vpBc1TQlS6zisigMDaKu3a50c2UL5Zl8S33 gLxEM7p/H8ToHuZVeVQx =fuBW -----END PGP SIGNATURE----- --H3os4bRIrK53VTemfr3cVwqJmWoK8aCHk--