From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v2 1/6] dt-bindings: power: reset: qcom-pon: define pm8941-pon
Date: Tue, 9 May 2023 13:54:37 +0200 [thread overview]
Message-ID: <761fd2ec-b83f-b695-5d23-f1cf5db48f99@linaro.org> (raw)
In-Reply-To: <CAA8EJpr4yC8sKsvscSK3FtQdM7fFUJAbA6zogzAo96U0MxvKDw@mail.gmail.com>
On 9.05.2023 13:21, Dmitry Baryshkov wrote:
> On Tue, 9 May 2023 at 11:53, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>>
>> On 8.05.2023 18:04, Dmitry Baryshkov wrote:
>>> On PM8941 pon doesn't store the reset reason. However we still need the
>>> wrapping node for pwrkey and resin nodes. Add bindings for pm8941-pon
>>> device.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>> Should probably also disallow setting reboot modes!
>
> But we don't set reboot modes in DT!
That's what I'm saying :P
>
>>
>> Konrad
>>> Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
>>> index d96170eecbd2..0f4f55dd4eac 100644
>>> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
>>> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
>>> @@ -19,6 +19,7 @@ properties:
>>> compatible:
>>> enum:
>>> - qcom,pm8916-pon
>>> + - qcom,pm8941-pon
>>> - qcom,pms405-pon
>>> - qcom,pm8998-pon
>>> - qcom,pmk8350-pon
>>> @@ -63,6 +64,7 @@ allOf:
>>> contains:
>>> enum:
>>> - qcom,pm8916-pon
>>> + - qcom,pm8941-pon
>>> - qcom,pms405-pon
>>> - qcom,pm8998-pon
>>> then:
[...]
allOf:
- $ref: reboot-mode.yaml#
Konrad
>
>
>
next prev parent reply other threads:[~2023-05-09 11:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 16:04 [PATCH v2 0/6] ARM: dts: qcom: apq8074-dragonboard: enable additional devices Dmitry Baryshkov
2023-05-08 16:04 ` [PATCH v2 1/6] dt-bindings: power: reset: qcom-pon: define pm8941-pon Dmitry Baryshkov
2023-05-09 8:53 ` Konrad Dybcio
2023-05-09 11:21 ` Dmitry Baryshkov
2023-05-09 11:54 ` Konrad Dybcio [this message]
2023-05-08 16:04 ` [PATCH v2 2/6] power: reset: qcom-pon: add support for pm8941-pon Dmitry Baryshkov
2023-05-09 8:51 ` Konrad Dybcio
2023-05-08 16:04 ` [PATCH v2 3/6] ARM: dts: qcom-pm8941: add resin support Dmitry Baryshkov
2023-05-09 8:52 ` Konrad Dybcio
2023-05-08 16:04 ` [PATCH v2 4/6] ARM: dts: qcom: apq8074-dragonboard: add resin and gpio keys Dmitry Baryshkov
2023-05-09 8:52 ` Konrad Dybcio
2023-05-08 16:04 ` [PATCH v2 5/6] ARM: dts: qcom: apq8074-dragonboard: add onboard leds Dmitry Baryshkov
2023-05-08 16:35 ` Krzysztof Kozlowski
2023-05-09 8:52 ` Konrad Dybcio
2023-05-08 16:04 ` [PATCH v2 6/6] ARM: dts: qcom: apq8074-dragonboard: enable coincell charger Dmitry Baryshkov
2023-05-23 23:34 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761fd2ec-b83f-b695-5d23-f1cf5db48f99@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).