From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27B79C77B7C for ; Tue, 9 May 2023 11:55:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235629AbjEILzA (ORCPT ); Tue, 9 May 2023 07:55:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235069AbjEILyo (ORCPT ); Tue, 9 May 2023 07:54:44 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BD4D4499 for ; Tue, 9 May 2023 04:54:41 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-4f00c33c3d6so6567754e87.2 for ; Tue, 09 May 2023 04:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683633279; x=1686225279; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YRecC+blqX9umwq/P5o5GfKySbyBcOvvkdfafugMVB4=; b=CLQ2+SBETxw7FIQSLl+c+VQNoYKBMi9PhduEZ0j+mnr2VwWv98pKnkgn3j15Ynx5Gl oh7WDqncyZwebtggkfpfVejLes1MbvrbCDptFyb5MgiPTV0IIbImBm4UI6T9letI62Y7 v8pjWaAR0DfCgUNF5Z7HhdTMdeJcJCBfUC6gwTxR1Abtl7ZlXCYKpaTVKn+4FXQL+Hhu h7zqlUlvF4NP6misQq1rOWr31EpK5kqjeQAhnWYUlS3oNmEsPUfgF3iFosgYccnPYUg2 9TVakDYqFHeYxPAwielTeEJ9Fgc3MGrczlQsZsEa8w/BhwKxBCfd5HMW+FPRLXm8ltAt T2ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683633279; x=1686225279; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YRecC+blqX9umwq/P5o5GfKySbyBcOvvkdfafugMVB4=; b=Ju9TDspAT6L6iCx/L2mGTKBC6On99nP6LphlCSSBFKw4OQ8AgqyYDdBOOhi3yDnODj utjEZjSXpi0sxlAyPcXv/Kfzypyd830Rs5WALCjonRxnDZ4NlA5H867SnrSdDoYZAZRP zmy9Ak/1M4rxECihAx7uXLU/vMfyI9tDJxA7k0mCiqEct/bjTBcTXqLDBptG5tMJpI4d pGjdoOb9AsikoDklKJkp+IdO6ROLO2W0HUD6L7rcl39FZui9EqKf27qGJTi8I5DY0CjJ VlfBDd8z3aYhS88nyN8UuGpR2/ORildQWM8FZPqceM2oJHZZ+ybfzsPkv4Uz2KWSfOp5 lI6g== X-Gm-Message-State: AC+VfDx1UGqBk0iSsdLs44Nk/wHC6GmovZuQg1HNERrQQnYCjbbMuI9S p3n4AuONjd1ixioW25R17cPuDA== X-Google-Smtp-Source: ACHHUZ7jeJe34EYrWUEMtQP+6NBiZHhuzbzSe6XdD5VsJLpeAL3yD6LEK9LGAqGYeTbykuNM2Q7PGg== X-Received: by 2002:a05:6512:208:b0:4ea:f526:5bef with SMTP id a8-20020a056512020800b004eaf5265befmr654546lfo.28.1683633279482; Tue, 09 May 2023 04:54:39 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id i17-20020ac25231000000b004f122a378d4sm321300lfl.163.2023.05.09.04.54.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 May 2023 04:54:39 -0700 (PDT) Message-ID: <761fd2ec-b83f-b695-5d23-f1cf5db48f99@linaro.org> Date: Tue, 9 May 2023 13:54:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/6] dt-bindings: power: reset: qcom-pon: define pm8941-pon Content-Language: en-US To: Dmitry Baryshkov Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Vinod Koul , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski References: <20230508160446.2374438-1-dmitry.baryshkov@linaro.org> <20230508160446.2374438-2-dmitry.baryshkov@linaro.org> <32d6b9be-58f1-1d63-2c1b-de9f7ba7b3b5@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 9.05.2023 13:21, Dmitry Baryshkov wrote: > On Tue, 9 May 2023 at 11:53, Konrad Dybcio wrote: >> >> >> >> On 8.05.2023 18:04, Dmitry Baryshkov wrote: >>> On PM8941 pon doesn't store the reset reason. However we still need the >>> wrapping node for pwrkey and resin nodes. Add bindings for pm8941-pon >>> device. >>> >>> Reviewed-by: Krzysztof Kozlowski >>> Signed-off-by: Dmitry Baryshkov >>> --- >> Should probably also disallow setting reboot modes! > > But we don't set reboot modes in DT! That's what I'm saying :P > >> >> Konrad >>> Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>> index d96170eecbd2..0f4f55dd4eac 100644 >>> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>> @@ -19,6 +19,7 @@ properties: >>> compatible: >>> enum: >>> - qcom,pm8916-pon >>> + - qcom,pm8941-pon >>> - qcom,pms405-pon >>> - qcom,pm8998-pon >>> - qcom,pmk8350-pon >>> @@ -63,6 +64,7 @@ allOf: >>> contains: >>> enum: >>> - qcom,pm8916-pon >>> + - qcom,pm8941-pon >>> - qcom,pms405-pon >>> - qcom,pm8998-pon >>> then: [...] allOf: - $ref: reboot-mode.yaml# Konrad > > >