From: Chanwoo Choi <chanwoo@kernel.org>
To: Frank Li <Frank.Li@nxp.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
"open list:NXP PTN5150A CC LOGIC AND EXTCON DRIVER"
<linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Cc: imx@lists.linux.dev
Subject: Re: [PATCH v4 1/1] dt-bindings: extcon: ptn5150: add child node port
Date: Thu, 22 Aug 2024 23:34:58 +0900 [thread overview]
Message-ID: <7620f6b3-347e-418d-b90b-487afa2ec32d@kernel.org> (raw)
In-Reply-To: <20240820143911.444048-1-Frank.Li@nxp.com>
24. 8. 20. 23:39에 Frank Li 이(가) 쓴 글:
> Add child node 'port' to allow connect to usb controller to do role-switch
> if id pin of ptn5150 have not connected to chip's usb ID function pin.
>
> Fix below warning:
> arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v3 to v4
> - remove extra empty line
> - fix Indentation in example
> Change from v2 to v3
> - only add port to existed example.
> Change from v1 to v2
> - add example for id pin have not connect to main chip's id example.
> - commit 095b96b2b fix "port" warning, but add new warning "connector" is
> not exist. And follow commit revert this change.
> 690085d866f08 Revert "arm64: dts: imx8mn-var-som-symphony: Describe the USB-C connector
> - I have not board in hand to debug why "connector" is not work.
> ---
> .../devicetree/bindings/extcon/extcon-ptn5150.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
> index d5cfa32ea52dd..072b3c0c5fd03 100644
> --- a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
> +++ b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
> @@ -37,6 +37,11 @@ properties:
> GPIO pin (output) used to control VBUS. If skipped, no such control
> takes place.
>
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + A port node to link the usb controller for the dual role switch.
> +
> required:
> - compatible
> - interrupts
> @@ -58,5 +63,11 @@ examples:
> interrupt-parent = <&msmgpio>;
> interrupts = <78 IRQ_TYPE_LEVEL_HIGH>;
> vbus-gpios = <&msmgpio 148 GPIO_ACTIVE_HIGH>;
> +
> + port {
> + endpoint {
> + remote-endpoint = <&usb1_drd_sw>;
> + };
> + };
> };
> };
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
prev parent reply other threads:[~2024-08-22 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 14:39 [PATCH v4 1/1] dt-bindings: extcon: ptn5150: add child node port Frank Li
2024-08-22 7:03 ` Krzysztof Kozlowski
2024-08-22 14:34 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7620f6b3-347e-418d-b90b-487afa2ec32d@kernel.org \
--to=chanwoo@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).