Re: [PATCH 1/5] dt-bindings: PCI: mediatek-gen3: Add MT8196 support

Krzysztof Kozlowski
2025-01-06T12:27:52Z

On 06/01/2025 10:26, Jianjun Wang (王建军) wrote:
> On Fri, 2025-01-03 at 10:10 +0100, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Fri, Jan 03, 2025 at 02:00:11PM +0800, Jianjun Wang wrote:
>>> + clock-names:
>>> + items:
>>> + - const: pl_250m
>>> + - const: tl_26m
>>> + - const: peri_26m
>>> + - const: peri_mem
>>> + - const: ahb_apb
>>> + - const: low_power
>>> +
>>> + resets:
>>> + minItems: 1
>>> + maxItems: 2
>>> +
>>> + reset-names:
>>> + minItems: 1
>>> + maxItems: 2
>>
>> Why resets are flexible?
>
> There are two resets, one for MAC and another for PHY, some platforms
> may only use one of them.

Even more questions. What does it mean use? Is it there or is it not?
Platform like SoC? But this is one specific SoC, it cannot be used on
different SoC.

>
> Would you prefer to set the number of resets to a fixed value for
> specific platforms?

Everything should be constrained to match hardware.

Best regards,
Krzysztof