From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Burton Subject: Re: [PATCH v2 09/14] MIPS: Malta: Probe RTC via DT Date: Tue, 20 Sep 2016 11:34:39 +0100 Message-ID: <762c9f70-911c-0e48-ef8e-8f8b9e006592@imgtec.com> References: <20160919212132.28893-1-paul.burton@imgtec.com> <20160919212132.28893-10-paul.burton@imgtec.com> <55c977d1-21dd-4cf8-d0f9-10d96b452573@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <55c977d1-21dd-4cf8-d0f9-10d96b452573-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sergei Shtylyov Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Ralf Baechle , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org On 20/09/16 11:21, Sergei Shtylyov wrote: > Hello. > > On 9/20/2016 12:21 AM, Paul Burton wrote: > >> Add the DT node required to probe the RTC, and remove the platform code >> that was previously doing it. >> >> Signed-off-by: Paul Burton >> >> --- >> >> Changes in v2: >> - Remove rtc DT node label > > Haven't you also renamed the node? Hi Sergei, Yes, strictly speaking I could have been more verbose & elaborated in the changelog on every aspect of the simple change from "rtc: mc146818@70" to "rtc@70". I didn't, but as it's obviously clear to you what changed and it has no effect on either the code or the commit that would end up in git I don't really see the point of your bringing it up. Thanks, Paul >> arch/mips/boot/dts/mti/malta.dts | 15 +++++++++++++++ >> arch/mips/mti-malta/malta-platform.c | 21 --------------------- >> 2 files changed, 15 insertions(+), 21 deletions(-) >> >> diff --git a/arch/mips/boot/dts/mti/malta.dts >> b/arch/mips/boot/dts/mti/malta.dts >> index af765af..fecbca8 100644 >> --- a/arch/mips/boot/dts/mti/malta.dts >> +++ b/arch/mips/boot/dts/mti/malta.dts >> @@ -49,4 +49,19 @@ >> interrupt-parent = <&gic>; >> interrupts = ; >> }; >> + >> + isa { >> + compatible = "isa"; >> + #address-cells = <2>; >> + #size-cells = <1>; >> + ranges = <1 0 0 0x1000>; >> + >> + rtc@70 { >> + compatible = "motorola,mc146818"; >> + reg = <1 0x70 0x8>; >> + >> + interrupt-parent = <&i8259>; >> + interrupts = <8>; >> + }; >> + }; >> }; > [...] > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html