From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88930C43334 for ; Tue, 5 Jul 2022 11:13:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230082AbiGELNJ (ORCPT ); Tue, 5 Jul 2022 07:13:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229974AbiGELNI (ORCPT ); Tue, 5 Jul 2022 07:13:08 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A0CF15A25 for ; Tue, 5 Jul 2022 04:13:07 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id t25so19951216lfg.7 for ; Tue, 05 Jul 2022 04:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=QrXr/J2hqDMZnPja47ouKqHCNCSXX62rUd+oU7fHrVE=; b=ld10z4BMu3SPYvQjMUNxI/WoH4qQDOu8NDQX6v9q5XyH/7AB+sYcA+jTTTxJvIxPiI QF8Wr3neT9klB20DKd39SUPyiH3Spa2LwHCcx4XJiufKAgoGjoMA+KzmupUDsIxhHZIZ vRFypw8UfeLP2N6t358u9zWZHma/AYAVwRtGZQ2tv1SPbswF1rjvDDC8PpgN0oP54ivF ILpkCMAolNQTLmh2d4aYdHcFtReaHrp1Jo484+ezkP7YhKMSZH3mJmrIRiYkvpgPLXj7 qKuM5wrrNoFrM6uPYwmHwz/quiYx+4PTmWNFEazKfe0YNIAp8KYV7NZgJqUCI/tMyV+1 2hbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=QrXr/J2hqDMZnPja47ouKqHCNCSXX62rUd+oU7fHrVE=; b=nJR+1WY+kINf76ia52DM1dLzygW05e/6/PL4nAEKoYODsuH0Rfr2Dm/1tyBrxmiWf9 hKrF4DVwoaZN+fyaE5HCllFgA+LHeMorC5RkpBhsyW3vqRoUNyVpPyivrj/8nfMV4PS0 WFLxssj/VRT8WI2RBADkwYejZHJwfVVtp+C90y1uo/rMR4vpijXpIExgqatA6aHC0g2n uwq0iUHOmJPPvhsxsgLfc8u35T7eJSXi65S1c9kLMsY8DoV8Zs+PKkn+8rNwzmU1LGXW BSGNjkaW7izI4Dvb9hqVRVYal7cFYWWi3ZCCd3Ts6yviuWLX1hTlmqPM7x8frc/Reai+ K9+g== X-Gm-Message-State: AJIora/ryawe8l5SSEdTSzcyBRlcSPVjnrugMwZk8Cay6UeFLGKUo4su AFruLcdD5URyJRtG9W49SsaN5A== X-Google-Smtp-Source: AGRyM1sAdS98Ne78ejyP4qj9Qn0wMJLTsqJ4OfDUzVBDDJTlyAB/4I5+75jXeyJRkXEkT/FwOp6ysg== X-Received: by 2002:a05:6512:12c7:b0:481:51ff:d027 with SMTP id p7-20020a05651212c700b0048151ffd027mr17914254lfg.577.1657019585986; Tue, 05 Jul 2022 04:13:05 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id f13-20020a2eb5ad000000b0025aa51b069esm5368789ljn.5.2022.07.05.04.13.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 04:13:05 -0700 (PDT) Message-ID: <76508b56-6733-b65c-d81c-31ac173780c0@linaro.org> Date: Tue, 5 Jul 2022 14:13:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 38/43] phy: qcom-qmp-pcie: drop pipe clock lane suffix Content-Language: en-GB To: Krzysztof Kozlowski , Johan Hovold , Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220705094239.17174-1-johan+linaro@kernel.org> <20220705094239.17174-39-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/07/2022 13:20, Krzysztof Kozlowski wrote: > On 05/07/2022 11:42, Johan Hovold wrote: >> The pipe clock is defined in the "lane" node so there's no need to keep >> adding a redundant lane-number suffix to the clock name. >> >> Drop the lane suffix from the pipe clock name, but continue supporting >> the legacy name as a fall back. >> >> Signed-off-by: Johan Hovold >> --- >> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c >> index 385ea3d8de08..254ad25591b9 100644 >> --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c >> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c >> @@ -2210,8 +2210,12 @@ int qcom_qmp_phy_pcie_create(struct device *dev, struct device_node *np, int id, >> if (!qphy->pcs_misc) >> dev_vdbg(dev, "PHY pcs_misc-reg not used\n"); >> >> - snprintf(prop_name, sizeof(prop_name), "pipe%d", id); >> - qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name); >> + qphy->pipe_clk = devm_get_clk_from_child(dev, np, "pipe"); > > Just get first clock and no need for handling any deprecation. If I got it correctly, passing NULL instead of the name would do the trick. -- With best wishes Dmitry