From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Komal Bajaj <quic_kbajaj@quicinc.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc
Date: Sat, 27 May 2023 01:22:04 +0200 [thread overview]
Message-ID: <76513a6b-a8c1-0bc3-a094-2cce1aa8ef87@linaro.org> (raw)
In-Reply-To: <20230523135733.3852-5-quic_kbajaj@quicinc.com>
On 23.05.2023 15:57, Komal Bajaj wrote:
> Add sdhci node for emmc in qdu1000-idp.
>
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> index 9e9fd4b8023e..6e988e90aa50 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> @@ -448,6 +448,29 @@
> status = "okay";
> };
>
> +&sdhc {
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&sdc_on_state>;
> + pinctrl-1 = <&sdc_off_state>;
Please do
property-n
property-names
we've had a little bit of a mess over the years but we're trying
to unify that.
With that:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> +
> + cap-mmc-hw-reset;
> + mmc-ddr-1_8v;
> + mmc-hs200-1_8v;
> + mmc-hs400-1_8v;
> + mmc-hs400-enhanced-strobe;
> +
> + non-removable;
> + no-sd;
> + no-sdio;
> +
> + supports-cqe;
> +
> + vmmc-supply = <&vreg_l10a_2p95>;
> + vqmmc-supply = <&vreg_l7a_1p8>;
> +
> + status = "okay";
> +};
> +
> &uart7 {
> status = "okay";
> };
> --
> 2.17.1
>
next prev parent reply other threads:[~2023-05-26 23:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 13:57 [PATCH v3 0/4] arm64: dts: qcom: qdu1000: add SDHCI Komal Bajaj
2023-05-23 13:57 ` [PATCH v3 1/4] dt-bindings: mmc: sdhci-msm: Document the QDU1000/QRU1000 compatible Komal Bajaj
2023-05-23 13:57 ` [PATCH v3 2/4] arm: dts: qcom: qdu1000: Add SDHCI node Komal Bajaj
2023-05-25 4:27 ` Bjorn Andersson
2023-06-01 6:56 ` Komal Bajaj
2023-05-23 13:57 ` [PATCH v3 3/4] arm64: dts: qcom: qdu1000: Add SDHCI pin configuration to DTSI Komal Bajaj
2023-05-23 13:57 ` [PATCH v3 4/4] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc Komal Bajaj
2023-05-26 23:22 ` Konrad Dybcio [this message]
2023-06-01 6:57 ` Komal Bajaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76513a6b-a8c1-0bc3-a094-2cce1aa8ef87@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_kbajaj@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).