From: Heiko Stuebner <heiko@sntech.de>
To: Alex Bee <knaerzche@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Fix GPU register width for RK3328
Date: Mon, 23 Aug 2021 23:20:04 +0200 [thread overview]
Message-ID: <7657417.31r3eYUQgx@phil> (raw)
In-Reply-To: <c586d864-994f-2d24-9b29-2933b567be84@gmail.com>
Hi Alex,
Am Montag, 23. August 2021, 00:19:08 CEST schrieb Alex Bee:
> Hi Heiko,
>
> is there anything left to do for this one?
nope, there wasn't anything missing, I just somehow managed to overlook
the patch till your ping. As you can see from the other mail, it is
applied now :-)
Heiko
>
> Same for:
>
> https://patchwork.kernel.org/project/linux-rockchip/patch/20210623145918.187018-1-knaerzche@gmail.com/
>
> and
>
> https://patchwork.kernel.org/project/linux-rockchip/patch/20210623150208.187201-1-knaerzche@gmail.com/
>
> Alex
>
> Am 23.06.21 um 13:59 schrieb Alex Bee:
> > As can be seen in RK3328's TRM the register range for the GPU is
> > 0xff300000 to 0xff330000.
> > It would (and does in vendor kernel) overlap with the registers of
> > the HEVC encoder (node/driver do not exist yet in upstream kernel).
> > See already existing h265e_mmu node.
> >
> > Fixes: 752fbc0c8da7 ("arm64: dts: rockchip: add rk3328 mali gpu node")
> > Signed-off-by: Alex Bee <knaerzche@gmail.com>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> > index 8c821acb21ff..da84be6f4715 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> > @@ -599,7 +599,7 @@ saradc: adc@ff280000 {
> >
> > gpu: gpu@ff300000 {
> > compatible = "rockchip,rk3328-mali", "arm,mali-450";
> > - reg = <0x0 0xff300000 0x0 0x40000>;
> > + reg = <0x0 0xff300000 0x0 0x30000>;
> > interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>,
>
next prev parent reply other threads:[~2021-08-23 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 11:59 [PATCH] arm64: dts: rockchip: Fix GPU register width for RK3328 Alex Bee
2021-08-22 22:19 ` Alex Bee
2021-08-23 21:20 ` Heiko Stuebner [this message]
2021-08-23 18:42 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7657417.31r3eYUQgx@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=knaerzche@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox