Re: [PATCH v4 04/11] dt-bindings: marvell: a38x: add kobol helios-4 board

[Josua Mayer <josua@solid-run.com>]

Am 04.01.24 um 09:43 schrieb Krzysztof Kozlowski:
> On 30/12/2023 16:44, Josua Mayer wrote:
>> Add DT compatible for the helios-4 nas by Kobol, which is already used
>> in-tree.
>>
>> This product shares a common system on module with the solidrun armada
>> 388 clearfog boards, however it is not easily described in a single
>> list due to their extra "solidrun,clearfog-a1" compatible string.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> ---
>>  Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
>> index 4950b840bf1c..3babda0d575f 100644
>> --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
>> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
>> @@ -15,6 +15,15 @@ properties:
>>    compatible:
>>      oneOf:
>>  
>> +      - description:
>> +          Kobol Armada 388 based helios nas.
>> +
> Drop blank line
Ack.
>
>> +        items:
>> +          - const: kobol,helios4
>> +          - const: marvell,armada388
>> +          - const: marvell,armada385
>> +          - const: marvell,armada380
>> +
>>        - description:
>>            SolidRun Armada 388 clearfog family single-board computers.
>>  
>>
> Best regards,
> Krzysztof
>