Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
Cc: Sunyun Yang <syyang@lontium.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, venkata.valluru@oss.qualcomm.com,
	Jessica Zhang <jesszhan0024@gmail.com>,
	y@hu-mdsor-hyd.qualcomm.com
Subject: Re: [PATCH v7 2/2] drm/bridge: Add Lontium LT9609C(EX/UXD) MIPI DSI to HDMI driver
Date: Sat, 18 Jul 2026 17:55:18 +0200	[thread overview]
Message-ID: <767e5a58-3d2e-4f80-bb85-d300757a9dbc@kernel.org> (raw)
In-Reply-To: <altfrJgx2IjO1g33@hu-mdsor-hyd.qualcomm.com>

On 18/07/2026 13:12, Mohit Dsor wrote:
> On Thu, Jul 16, 2026 at 02:56:02PM +0200, Krzysztof Kozlowski wrote:
>> On 16/07/2026 13:31, mohit.dsor@oss.qualcomm.com wrote:
>>> From: Sunyun Yang <syyang@lontium.com>
>>>
>>> LT9611C(EX/UXD) is an I2C-controlled chip that Receiver signal/dual port
>>> mipi dsi and output hdmi, differences in hardware features:
>>> - LT9611C: supports 1-port mipi dsi to hdmi 1.4
>>> - LT9611EX: supports 2-port mipi dsi to hdmi 1.4
>>> - LT9611UXD: supports 2-port mipi dsi to hdmi 1.4/2.0
>>>
>>> Signed-off-by: Sunyun Yang <syyang@lontium.com>
>>> Co-developed-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
>>> Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
>>> ---
>>>  MAINTAINERS                              |    7 +
>>>  drivers/gpu/drm/bridge/Kconfig           |   18 +
>>>  drivers/gpu/drm/bridge/Makefile          |    1 +
>>>  drivers/gpu/drm/bridge/lontium-lt9611c.c | 1293 ++++++++++++++++++++++++++++++
>>>  4 files changed, 1319 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 6dea93a41962..30be2eaf2bec 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -15184,6 +15184,13 @@ S:	Maintained
>>>  F:	Documentation/devicetree/bindings/display/bridge/lontium,lt8912b.yaml
>>>  F:	drivers/gpu/drm/bridge/lontium-lt8912b.c
>>>  
>>> +LONTIUM LT9611C MIPI DSI TO HDMI BRIDGE
>>> +M:	Sunyun Yang <syyang@lontium.com>
>>> +M:	Mohit Dsor <mohit.dsor@oss.qualcomm.com>
>>> +S:	Maintained
>>> +F:	Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
>>> +F:	drivers/gpu/drm/bridge/lontium-lt9611c.c
>>> +
>>>  LOONGARCH
>>>  M:	Huacai Chen <chenhuacai@kernel.org>
>>>  R:	WANG Xuerui <kernel@xen0n.name>
>>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
>>> index 4a57d49b4c6d..b8959b8e2ad0 100644
>>> --- a/drivers/gpu/drm/bridge/Kconfig
>>> +++ b/drivers/gpu/drm/bridge/Kconfig
>>> @@ -177,6 +177,24 @@ config DRM_LONTIUM_LT9611
>>>  	  HDMI signals
>>>  	  Please say Y if you have such hardware.
>>>  
>>> +config DRM_LONTIUM_LT9611C
>>> +	tristate "Lontium LT9611C DSI/HDMI bridge"
>>> +	select SND_SOC_HDMI_CODEC if SND_SOC
>>> +	depends on OF
>>> +	select CRC8
>>> +	select FW_LOADER
>>> +	select DRM_PANEL_BRIDGE
>>> +	select DRM_KMS_HELPER
>>> +	select DRM_MIPI_DSI
>>> +	select DRM_DISPLAY_HELPER
>>> +	select DRM_DISPLAY_HDMI_STATE_HELPER
>>> +	select REGMAP_I2C
>>> +	help
>>> +	  Driver for Lontium DSI to HDMI bridge
>>> +	  chip driver that converts dual DSI and I2S to
>>> +	  HDMI signals
>>> +	  Please say Y if you have such hardware.
>>
>> Please wrap the code to appropriate limits.
> I checked the others in Kconfigs they appear to be similar,
> still i will try to fix it.

This is nowhere close to the limit expressed by coding style.

Best regards,
Krzysztof

      reply	other threads:[~2026-07-18 15:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 11:31 [PATCH v7 0/2] Subject: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver mohit.dsor
2026-07-16 11:31 ` [PATCH v7 1/2] dt-bindings: bridge: " mohit.dsor
2026-07-16 11:36   ` sashiko-bot
2026-07-16 11:31 ` [PATCH v7 2/2] drm/bridge: Add Lontium LT9609C(EX/UXD) " mohit.dsor
2026-07-16 11:43   ` sashiko-bot
2026-07-16 12:56   ` Krzysztof Kozlowski
2026-07-18 11:12     ` Mohit Dsor
2026-07-18 15:55       ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=767e5a58-3d2e-4f80-bb85-d300757a9dbc@kernel.org \
    --to=krzk@kernel.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jesszhan0024@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mohit.dsor@oss.qualcomm.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=syyang@lontium.com \
    --cc=tzimmermann@suse.de \
    --cc=venkata.valluru@oss.qualcomm.com \
    --cc=vkoul@kernel.org \
    --cc=y@hu-mdsor-hyd.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox