Re: [PATCH v3 1/2] regulator: dt-bindings: document the SGM3804 Dual Output regulator

[Neil Armstrong <neil.armstrong@linaro.org>]

On 5/4/26 14:44, Neil Armstrong wrote:
> Document the SG Micro SGM3804 Single Inductor Dual Output Buck/Boost
> Converter used to power LCD panels a provide positive and negative
> power rails with configurable voltage and active discharge function
> for each output.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>   .../bindings/regulator/sgmicro,sgm3804.yaml        | 77 ++++++++++++++++++++++
>   1 file changed, 77 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/sgmicro,sgm3804.yaml b/Documentation/devicetree/bindings/regulator/sgmicro,sgm3804.yaml
> new file mode 100644
> index 000000000000..5ea475f8f8b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/sgmicro,sgm3804.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/sgmicro,sgm3804.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SG Micro SGM3804 Single Inductor Dual Output Buck/Boost Converter
> +
> +maintainers:
> +  - Neil Armstrong <neil.armstrong@linaro.org>
> +
> +description:
> +  The SGM3804 is a dual voltage regulator, designed to support positive/negative
> +  supply for driving LCD panels. It support software-configurable output
> +  switching. The output voltages can be programmed via an I2C compatible interface.
> +
> +properties:
> +  compatible:
> +    const: sgmicro,sgm3804
> +
> +  reg:
> +    maxItems: 1
> +
> +  enable-gpios:
> +    minItems: 2
> +    description:
> +      GPIO specifiers to enable the positive and negative outputs.
> +
> +  vin-supply: true
> +
> +patternProperties:
> +  "^(pos|neg)$":
> +    type: object
> +    $ref: regulator.yaml#
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - enable-gpios
> +  - pos
> +  - neg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        regulator@3e {
> +            compatible = "sgmicro,sgm3804";
> +            reg = <0x3e>;
> +
> +            vin-supply = <&vin_reg>;
> +
> +            enable-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>,
> +                           <&gpio 18 GPIO_ACTIVE_HIGH>;

So this fails with Rob's bot and with DTBS_CHECK with board DT but I can't make
it fail with dt_binding_check on my side.

enable-gpios: [[88, 59, 0], [88, 58, 0]] is too long

But I found out in Documentation/devicetree/bindings/gpio/gpio-consumer-common.yaml :
   enable-gpios:
     maxItems: 1
     description:
       GPIO connected to the enable control pin.

This was rather unexpected...

So I'll probably need update the bindings to mode the enable gpios in the subnodes instead.

Neil

> +
> +            pos {
> +                regulator-name = "outpos";
> +                regulator-min-microvolt = <5000000>;
> +                regulator-max-microvolt = <5000000>;
> +            };
> +
> +            neg {
> +                regulator-name = "outneg";
> +                regulator-min-microvolt = <5000000>;
> +                regulator-max-microvolt = <5000000>;
> +            };
> +        };
> +    };
> +...
> +
>