From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E842DC4332F for ; Tue, 13 Dec 2022 13:37:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235266AbiLMNhb (ORCPT ); Tue, 13 Dec 2022 08:37:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235519AbiLMNh2 (ORCPT ); Tue, 13 Dec 2022 08:37:28 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70FC620362 for ; Tue, 13 Dec 2022 05:37:26 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id bp15so4881981lfb.13 for ; Tue, 13 Dec 2022 05:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pgDRSp/f16xzmWzxjmFxCL6xZadwIS7cOwIn0PxoaZk=; b=fCRVoT/qejeKPXkjsA03s0w3u8M3gNLb5e6NMC9zTJZh8WllhV/TonZ0p+3rj3UJwl 4N3uARm5ptBQhQGA9mxpDUKejEfnp4HKyMm2szoY7sA+fc79jiG5GgAWdkpPwuApVgzV /araw8sN0023f+0ZsNhTVzIyeEKSpzcXVzCBGawQP6wY7kLUolzLMLHKjRY50jqHgtLC OCJKvognIPibkDtuO11IdTh9WMgg26DHle3iYXpxWf24OndKLPQzPAHPWVfpwCjgbds/ 6uQkn6rC5HWN3W8qiR7c+7gvWlv2xShB02Pv6bO70dPKz3VGN3fpSfZ0FZka+PmORwWh snAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pgDRSp/f16xzmWzxjmFxCL6xZadwIS7cOwIn0PxoaZk=; b=lC5H5kfdUn9CN6G/yns7NyTxUGfwhmuQJe+Wzp1WQBxXqkqYB6Q5oUSvedRhYV3utz 0fgwgfjt+//BrH+RY3VLw+m7Z8QmmaCb1zhIqNcriMyihvpqOGG73Ah/s/9SL86yfZYU PMeNoTY6/A4J5G0F5GSl83+9KvIe2+PAOsoL5CNi9nYm/cXsu5v6f8aRL6Q5FChzruwP Th+V69UtfMWBBmy8bC5pMrjaHHWLx3d5BkICWKkWdTpR0i60WE3UW2LPfVGNdC5yoULe hjFw+vbtdfaO/ji8krkmMf1PXpqBKsb28nHo+siyGeV/AX5Q4Tw+JRBtJ1NpSin2Diae Ax6Q== X-Gm-Message-State: ANoB5pmLZ8v75nwnhnnvf0zk/M0cSDs8WyE0FSU8d0QqXjVItAm5mV4K FzzO3m43PfRhKrpar5fQTf8HHg== X-Google-Smtp-Source: AA0mqf6TyCH12rWSC74gVlzA99xf93VjcY1KeD9BJiNKIo2LXA9ZiCDDJIhBIEGVDjJd/nSfcI89dQ== X-Received: by 2002:a05:6512:3e06:b0:4b5:9bfa:801a with SMTP id i6-20020a0565123e0600b004b59bfa801amr6392757lfv.46.1670938644846; Tue, 13 Dec 2022 05:37:24 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id 3-20020ac25f03000000b004b700ba3cf3sm127631lfq.203.2022.12.13.05.37.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 05:37:24 -0800 (PST) Message-ID: <769dbb36-2223-91a3-0d6b-e23304827c43@linaro.org> Date: Tue, 13 Dec 2022 14:37:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 12/12] dt-bindings: mediatek: mt8188: add mt8188-mt6359 document Content-Language: en-US To: =?UTF-8?B?VHJldm9yIFd1ICjlkLPmlofoia8p?= , "robh+dt@kernel.org" , "broonie@kernel.org" , "p.zabel@pengutronix.de" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "perex@perex.cz" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "angelogioacchino.delregno@collabora.com" , "alsa-devel@alsa-project.org" , Project_Global_Chrome_Upstream_Group , "devicetree@vger.kernel.org" References: <20221208033148.21866-1-trevor.wu@mediatek.com> <20221208033148.21866-13-trevor.wu@mediatek.com> <6350def8-bb1f-8aeb-4c98-4d02a4c59aed@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/12/2022 16:34, Trevor Wu (吳文良) wrote: > On Fri, 2022-12-09 at 11:18 +0100, Krzysztof Kozlowski wrote: >> On 08/12/2022 04:31, Trevor Wu wrote: >>> Add document for mt8188 board with mt6359. >>> >>> Signed-off-by: Trevor Wu >>> --- >>> .../bindings/sound/mt8188-mt6359.yaml | 60 >>> +++++++++++++++++++ >>> 1 file changed, 60 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/sound/mt8188- >>> mt6359.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/sound/mt8188- >>> mt6359.yaml b/Documentation/devicetree/bindings/sound/mt8188- >>> mt6359.yaml >>> new file mode 100644 >>> index 000000000000..eac1c87b693a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/sound/mt8188-mt6359.yaml >> >> Missing vendor prefix. You got comments for it already. > Hi Krzysztof, > > I will correct it in V4. > >> >>> @@ -0,0 +1,60 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: >>> https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mt8188-mt6359.yaml*__;Iw!!CTRNKA9wMg0ARbw!nw_OzBIRlXrEP6K_EtxEWAIZzuvnD3Dm_KDuv8gpLRqlnnSfVLksNfKqMmeYiFlEVVy6F2BXwmXB8oQkDPeBuEXMtfLX2w$  >>> >>> +$schema: >>> https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!nw_OzBIRlXrEP6K_EtxEWAIZzuvnD3Dm_KDuv8gpLRqlnnSfVLksNfKqMmeYiFlEVVy6F2BXwmXB8oQkDPeBuEXodFoCJA$  >>> >>> + >>> +title: MediaTek MT8188 ASoC sound card >>> + >>> +maintainers: >>> + - Trevor Wu >>> + >>> +properties: >>> + compatible: >>> + const: mediatek,mt8188-mt6359-evb >>> + >>> + model: >>> + $ref: /schemas/types.yaml#/definitions/string >>> + description: User specified audio sound card name >>> + >>> + audio-routing: >>> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array >>> + description: >>> + A list of the connections between audio components. Each >>> entry is a >>> + sink/source pair of strings. Valid names could be the input >>> or output >>> + widgets of audio components, power supplies, MicBias of >>> codec and the >>> + software switch. >>> + >>> + mediatek,platform: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: The phandle of MT8188 ASoC platform. >>> + >>> + mediatek,dptx-codec: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: The phandle of MT8188 Display Port Tx codec node. >>> + >>> + mediatek,hdmi-codec: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: The phandle of MT8188 HDMI codec node. >> >> Why you do not use DAI links for all these? > > Are the following examples "DAI links" you mean? > > hdmi-dai-link { > link-name = "HDMI Playback"; > cpu { > sound-dai = <&q6afedai TERTIARY_MI2S_RX>; > }; > > platform { > sound-dai = <&q6routing>; > }; > > codec { > sound-dai = <<9611_codec 0>; > }; > }; Yes, this one. I think this is preferred. But anyway the point is to use sound-dai-cells, not pure (non-DAI) phandles). > > or > > headset-codec { > sound-dai = <&rt5682s>; > }; > > > As far as I know, only "mediatek,platform" was used at the beginning. > Next, hdmi-codec was introduced, and it followed the same style to get > phandle. Finally, it became three properties in mt8195, and the > implementation of mt8188 was inherited from mt8195. OK, if you share common code it is fine. > > I just glanced over the usage of dai links. > As I see it, I will replace the codec parts with dai link structure > like the example above first. It seems to be easier to extend more > codecs with the same tyle. Would be good. > > For platform part, I need more time to check if it is better to keep > the original implementation, because we still have to take SOF related > implementation into consideration. OK Best regards, Krzysztof