From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45028EB64D7 for ; Wed, 21 Jun 2023 06:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229470AbjFUGDF (ORCPT ); Wed, 21 Jun 2023 02:03:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbjFUGDC (ORCPT ); Wed, 21 Jun 2023 02:03:02 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCE6A1998 for ; Tue, 20 Jun 2023 23:02:50 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9896216338cso95699766b.3 for ; Tue, 20 Jun 2023 23:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687327369; x=1689919369; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oAEk81ZICVDtnc+wdWoBCpFc/VJWJ2dNtRwNJtzQAy8=; b=XiHH6lZdLXfcINNXyv9xpRvQR+NiN9dmTyUgmZ9J/P4nmSLifi+ZWb0O0CgM/9sQ4W a8eCK6gdjNGPqGDMeUVWvx8j++7TTFosFUmXpebaqEFKV10706tRCIZ/ONvgkVlnYJa5 TS4mrZOQnGbyERQkCU5MM+AJMsz7ToARh7Gq1STPrYrKHKmujcJtI1eE5RASXsLI0vCs Tz2tvnCmRPZjnwqX7WW64WUwSSzFFiq9DW11fJ0V4ZoGLdhBkzvgqlnofq14xI5l8qyk FZ+u5MXAOETFVgBroBKqkOvIiv6layV72H7COcwB5k6fB8PhW12fk66ENKIQM7hIbYNs uHzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687327369; x=1689919369; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oAEk81ZICVDtnc+wdWoBCpFc/VJWJ2dNtRwNJtzQAy8=; b=gVd/w/07M6S15cgX5AW4/zy/qHYD06OZ3YYoAPnPZu520tI6TEk6wYqUyQu+71ug37 U8MyfZls78MISnoZAAsV0OwJQC+5s+78D+RQOmvMVZLpVTgR5SQi19+NypLnGZ3koXH2 zEUkCaS/4Y3q3XCFSCybDi83lvHwZoSD8U+UbD/ual3JQt4gODKRe7Um2ZBeFEAaU0sq knEPtm/g5dHTAA1DsF/jstr9tQUNDetTJtRyOuy8ObrKC3Fzlx7sGGljvsGVr1PgW+hs cKHvSHIf5+C+E4IOJegPOnLL44E4aTpIf9TrWz+NWRU9MCV/La5xWEaku8/itmA0KRIB KKnA== X-Gm-Message-State: AC+VfDwitb0JLS2RZdplyph7p00VCTD1TwfG+5lX1Q74T/0/VzNW7aAw IjLIu998qtA9TPsBSvJyP/AjcA== X-Google-Smtp-Source: ACHHUZ50b++2H7B0kJgKPXmL93Wl0xN8LfsMHkJef4xYJOLT4e6HR5bCEBNeFopNSOQDsDVkODhzxw== X-Received: by 2002:a17:907:a412:b0:989:d9d:d911 with SMTP id sg18-20020a170907a41200b009890d9dd911mr4343002ejc.69.1687327369331; Tue, 20 Jun 2023 23:02:49 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id p10-20020a170906a00a00b00987bc81506dsm2482314ejy.202.2023.06.20.23.02.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 23:02:48 -0700 (PDT) Message-ID: <76a7f819-f3d2-d39d-1bc9-f1e7f837fd22@linaro.org> Date: Wed, 21 Jun 2023 08:02:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 2/2] arm64: dts: meson-t7-a311d2-khadas-vim4: add initial device-tree To: Yixun Lan , Lucas Tanure Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jerome Brunet , Kevin Hilman , Nick , Artem , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20230620134857.238941-1-tanure@linux.com> <20230620134857.238941-3-tanure@linux.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/06/2023 00:09, Yixun Lan wrote: >> + apb4: bus@fe000000 { >> + compatible = "simple-bus"; >> + reg = <0x0 0xfe000000 0x0 0x480000>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; >> + >> + uart_A: serial@78000 { >> + compatible = "amlogic,meson-t7-uart", > ~~~~~~~~~~~~~~~~~ > if you introduce new compatible string, then at least you need to document it > so Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml need to be updated > > but my qeustion here, why bother introducing new compatible string if nothing > changed with the compatible data? given the uart is same IP with g12a, can't we just > use "amlogic,meson-g12-uart" for this? no only it will reduce the structure length of > meson_uart_dt_match[], but also relieve maintainer's review burden? https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 Best regards, Krzysztof