From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F3AC77B75 for ; Fri, 5 May 2023 06:45:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231133AbjEEGpR (ORCPT ); Fri, 5 May 2023 02:45:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229972AbjEEGpR (ORCPT ); Fri, 5 May 2023 02:45:17 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE63230F6 for ; Thu, 4 May 2023 23:45:15 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-965cc5170bdso130739066b.2 for ; Thu, 04 May 2023 23:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683269114; x=1685861114; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f1F8TUb0vE+6tu+UVmJ0AzgABHlR7ADfS8FFXBxRieA=; b=UK0H7SvI8XLENMldv8m6kP0ZOtVPN6jLEgL+NVDGS4xY4pOviX0TlMDLPiOJzKkVpY r1E21fJSLXmSn+BKOrwceUdmwgXLLt94CorxzRHPjMCeYoLJ92xjGs0xVwK0fdJaVWJV 3VAcSGNDwKeIf8PmNSpfTvUz/UPhAQn3T56MoAHX0a91TdnGvGaJmHyD9UZ+77/R77/l Cs8r3YMdJDF3e8OZl8mGWJZkuocp3AuKu9y2XE0WEiLl+OkSEoJLKDvcjfOuFSoNtllk IgdJH/gJnymbzdllN9wY8zQ3SxQaRrivemzhUIHRcX53mtDJekOJkoA5K0BvRULz3cQG 9z8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683269114; x=1685861114; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f1F8TUb0vE+6tu+UVmJ0AzgABHlR7ADfS8FFXBxRieA=; b=cI7pQT/jl2wh2KWWzbmexGW89d80btXBTT+MOAnYu507BQWY/UJ95ib1RpDXNd+TWY a1dUpkzfSBCFjRf0iRi81WNsyXNtD0ekxR69fSYS1VRjC8vYK1K2+bdK0uvXPme6EhX4 QmWzZJL8xhf+S/tmuhN8IV8ztZx2eWFOniThrUfOa+7/Gz7ZPJE6JQMp2VDyeF3kgfYA roEQ345vFvyL7XOQSf5kZtBXWdOqaa8VonvEz32tD6t0H8Rk2P0ulQ3o8bC37Dcjnh4R fqjlKRTvipVjw/29yFDHY2uP669jqSUXXXVsHprzXH/j8Gj0Twh6nIqoPZscVPPvy+cp A35w== X-Gm-Message-State: AC+VfDwfME492l157CBipMSln7DBqvmz41vIdXhOjI2UXDdyLHPWcJjE I+DSSlInWiLSY+fkrk2dNY2kzw== X-Google-Smtp-Source: ACHHUZ7e7CM816XOA8JH1lGUFzOlkUl5vywj1RnY1LL4ilUqUe6wTzu5vYAUKtEeQGlRPbffNQbYGQ== X-Received: by 2002:a17:906:db03:b0:965:4b43:11f1 with SMTP id xj3-20020a170906db0300b009654b4311f1mr230527ejb.3.1683269114140; Thu, 04 May 2023 23:45:14 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:52e:24ce:bbc1:127d? ([2a02:810d:15c0:828:52e:24ce:bbc1:127d]) by smtp.gmail.com with ESMTPSA id bj6-20020a170906b04600b0096595cc0810sm549923ejb.72.2023.05.04.23.45.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 23:45:13 -0700 (PDT) Message-ID: <76a8662d-25ce-cd8c-7851-d163f4b3496b@linaro.org> Date: Fri, 5 May 2023 08:45:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] arm64: dts: qcom: Add Fxtec Pro1X (QX1050) DTS Content-Language: en-US To: Dang Huynh , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230505-fxtec-pro1x-support-v1-1-1d9473b4d6e4@riseup.net> From: Krzysztof Kozlowski In-Reply-To: <20230505-fxtec-pro1x-support-v1-1-1d9473b4d6e4@riseup.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/05/2023 22:33, Dang Huynh wrote: > The F(x)tec Pro1X is a mobile phone released by FX Technologies Ltd > in 2022. > > The phone is exactly the same as the Pro1 released in 2019 with some > changes: > - MSM8998 -> SM6115 > - Camera button is no longer multistate > - Only one 48MP back camera > - A new keyboard layout picked by the community. > Thank you for your patch. There is something to discuss/improve. > + * Copyright (c) 2023, Dang Huynh > + */ > + > +/dts-v1/; > + > +#include "sm6115.dtsi" > +#include "pm6125.dtsi" > + > +/ { > + model = "F(x)tec Pro1 (QX1050)"; > + compatible = "fxtec,pro1x", "qcom,sm6115"; Missing bindings (first patch in the series). > + chassis-type = "handset"; > + > + /* required for bootloader to select correct board */ > + qcom,msm-id = <417 0x10000>, <444 0x10000>; > + qcom,board-id = <34 0>; > + > + aliases { > + }; Drop empty node. > + > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + framebuffer0: framebuffer@5c000000 { > + compatible = "simple-framebuffer"; > + reg = <0 0x5c000000 0 (1080 * 2160 * 4)>; > + width = <1080>; > + height = <2160>; > + stride = <(1080 * 4)>; > + format = "a8r8g8b8"; > + clocks = <&gcc GCC_DISP_HF_AXI_CLK>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&vol_up_n>; > + > + key-volume-up { > + label = "Volume Up"; > + linux,code = ; > + gpios = <&pm6125_gpios 5 GPIO_ACTIVE_LOW>; > + debounce-interval = <15>; > + linux,can-disable; > + gpio-key,wakeup; > + }; > + }; > +}; > + > +&tlmm { Override/label entries should be ordered by name. tlmm is after pm6125. > + gpio-reserved-ranges = <0 4>, <14 4>; > +}; > + > +&pm6125_gpios { > + vol_up_n: vol-up-n-state { > + pins = "gpio5"; > + function = "normal"; > + power-source = <0>; > + bias-pull-up; > + input-enable; > + }; > +}; > + > +&dispcc { > + /* HACK: disable until a panel driver is ready to retain simplefb */ > + status = "disabled"; > +}; > + > +&pon_pwrkey { > + status = "okay"; > +}; > + > +&pon_resin { > + linux,code = ; > + status = "okay"; > +}; > + > +&rpm_requests { > + pm6125-regulators { Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof