* [PATCH] dt-bindings: serial: stm32: add power-domains property
@ 2024-01-11 11:24 Valentin Caron
2024-01-15 15:05 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Valentin Caron @ 2024-01-11 11:24 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alexandre Torgue
Cc: linux-kernel, devicetree, linux-stm32, linux-arm-kernel,
Valentin Caron
Add "power-domains" property in stm32 serial binding to avoid:
serial@40010000: Unevaluated properties are not allowed
('power-domains' were unexpected)
Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
---
Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
index 1df8ffe95fc6..62f97da1b2fd 100644
--- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
@@ -58,6 +58,9 @@ properties:
wakeup-source: true
+ power-domains:
+ maxItems: 1
+
rx-threshold:
description:
If value is set to 1, RX FIFO threshold is disabled.
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: serial: stm32: add power-domains property
2024-01-11 11:24 [PATCH] dt-bindings: serial: stm32: add power-domains property Valentin Caron
@ 2024-01-15 15:05 ` Krzysztof Kozlowski
2024-01-17 9:21 ` Valentin CARON
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-15 15:05 UTC (permalink / raw)
To: Valentin Caron, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alexandre Torgue
Cc: linux-kernel, devicetree, linux-stm32, linux-arm-kernel
On 11/01/2024 12:24, Valentin Caron wrote:
> Add "power-domains" property in stm32 serial binding to avoid:
>
> serial@40010000: Unevaluated properties are not allowed
> ('power-domains' were unexpected)
>
It would be better if you checked whether it can be part of power domain
or not. What if the DTS is wrong?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: serial: stm32: add power-domains property
2024-01-15 15:05 ` Krzysztof Kozlowski
@ 2024-01-17 9:21 ` Valentin CARON
2024-01-17 9:23 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Valentin CARON @ 2024-01-17 9:21 UTC (permalink / raw)
To: Krzysztof Kozlowski, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alexandre Torgue
Cc: linux-kernel, devicetree, linux-stm32, linux-arm-kernel
On 1/15/24 16:05, Krzysztof Kozlowski wrote:
> On 11/01/2024 12:24, Valentin Caron wrote:
>> Add "power-domains" property in stm32 serial binding to avoid:
>>
>> serial@40010000: Unevaluated properties are not allowed
>> ('power-domains' were unexpected)
>>
> It would be better if you checked whether it can be part of power domain
> or not. What if the DTS is wrong?
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
I'm not sure to understand, but if you mean that there is no
power-domains properties right now in all stm32mp device trees
and so it does not required to add this stm32 serial bindings:
Theses will be upstreamed in the future, and because power-domains
property is optional, I can add it right now in stm32 serial binding
to anticipate.
Best regards,
Valentin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: serial: stm32: add power-domains property
2024-01-17 9:21 ` Valentin CARON
@ 2024-01-17 9:23 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-17 9:23 UTC (permalink / raw)
To: Valentin CARON, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alexandre Torgue
Cc: linux-kernel, devicetree, linux-stm32, linux-arm-kernel
On 17/01/2024 10:21, Valentin CARON wrote:
>
> On 1/15/24 16:05, Krzysztof Kozlowski wrote:
>> On 11/01/2024 12:24, Valentin Caron wrote:
>>> Add "power-domains" property in stm32 serial binding to avoid:
>>>
>>> serial@40010000: Unevaluated properties are not allowed
>>> ('power-domains' were unexpected)
>>>
>> It would be better if you checked whether it can be part of power domain
>> or not. What if the DTS is wrong?
>>
>> Best regards,
>> Krzysztof
>>
> Hi Krzysztof,
>
> I'm not sure to understand, but if you mean that there is no
> power-domains properties right now in all stm32mp device trees
> and so it does not required to add this stm32 serial bindings:
>
> Theses will be upstreamed in the future, and because power-domains
> property is optional, I can add it right now in stm32 serial binding
> to anticipate.
No. You used argument: "add because DTS has it" and I want different
argument: "add because it is the right thing to do because foo and bar".
If DTS is wrong, then your commit and this explanation is wrong.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-17 9:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-11 11:24 [PATCH] dt-bindings: serial: stm32: add power-domains property Valentin Caron
2024-01-15 15:05 ` Krzysztof Kozlowski
2024-01-17 9:21 ` Valentin CARON
2024-01-17 9:23 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).