Re: [PATCH 3/3] dt-bindings: display: Add MAYQUEEN PIXPAPER e-ink panel

[Krzysztof Kozlowski <krzk@kernel.org>]

On 18/06/2025 05:49, LiangCheng Wang wrote:
> The binding is for the MAYQUEEN PIXPAPER e-ink display panel,
> controlled via an SPI interface.
> 
> Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
> ---
>  .../bindings/display/mayqueen,pixpaper.yaml   | 67 +++++++++++++++++++

Don't send multiple patches but version them correctly.

>  1 file changed, 67 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/mayqueen,pixpaper.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/mayqueen,pixpaper.yaml b/Documentation/devicetree/bindings/display/mayqueen,pixpaper.yaml
> new file mode 100644
> index 000000000..f7c33957e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/mayqueen,pixpaper.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/mayqueen,pixpaper.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MAYQUEEN PIXPAPER e-ink display panel

Don't capitalize all letters. Mayqueen Pixpaper or whatever it is really
called.

> +
> +maintainers:
> +  - LC Wang <zaq14760@gmail.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The PIXPAPER is an e-ink display panel controlled via an SPI interface.
> +  The panel has a resolution of 122x250 pixels and requires GPIO pins for
> +  reset, busy, and data/command control.
> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    const: mayqueen,pixpaper
> +
> +  reg:
> +    maxItems: 1
> +    description: SPI chip select number for the device.

Drop description

> +
> +  spi-max-frequency:
> +    default: 1000000
> +    description: Maximum SPI clock frequency in Hz.

Drop description


> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: GPIO for the panel reset pin.

Drop description


> +
> +  busy-gpios:
> +    maxItems: 1
> +    description: GPIO for the panel busy pin.
> +
> +  dc-gpios:
> +    maxItems: 1
> +    description: GPIO for the data/command pin.
> +
> +required:
> +  - compatible
> +  - reg
> +  - reset-gpios
> +  - busy-gpios
> +  - dc-gpios
> +
> +additionalProperties: false

unevaluatedProperties instead



Best regards,
Krzysztof