From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0AA3C4332F for ; Sat, 1 Oct 2022 09:58:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229635AbiJAJ6G (ORCPT ); Sat, 1 Oct 2022 05:58:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbiJAJ6F (ORCPT ); Sat, 1 Oct 2022 05:58:05 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7DAEFA256 for ; Sat, 1 Oct 2022 02:58:03 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id l12so7130245ljg.9 for ; Sat, 01 Oct 2022 02:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Lg74YdrNQ3T6av29vUZXf6jb0Fvwg0IUmRSwVmSXrvQ=; b=WWcl3zeNaFEKSQvjYL3BGfMNIzSduNPL7gEZy3456dhW6s04O63yPwKg8lVl/V7J66 jx5cG2FWSiuEWP5dc4pMHEe0Bu/he4Z2oGyG0XSKPEdd8Ru3AR/PqB3P3p2r19lJAO5X 02Msc6luM5pi4UvKmq4gMouGN538NOkbM63VE4RwPu8Yww6pjTxZdb4IxhHFoRYM3iu3 jelDj7aLzXOsZzFFSPdN30/ROHtr48m2QHFTyMJn2Mgg00mk+qgUzkklSvdzpdL4ffM+ eTWKPk3jZgd3i8I4wniSBiNWyHZ9jWSuiYBhvipLHjGZdp1c4itzCOggDgBbZ2llKP+L nXxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Lg74YdrNQ3T6av29vUZXf6jb0Fvwg0IUmRSwVmSXrvQ=; b=6Pc8o95HUINV/ml4pAEzb9+aVDpI6UNqFXtdWyY2XEQdAti8eC6EyhaWMT23TsHhTt xs+ESs47ID8B9mNYqXsH4QC16mPV2qq6yUfNEF8jWX2annscMO9P/CYj+RotDQbzNBZk qW2iUNuil2EeyrzWwHJ+XHTfZb2CBXGjSWiP6BqlX1l8T/Y05uCAl0W0Ap9Av16byhAV /Wq81OgaHFsJUYn+NK0vBAkViq1NH22RSdEB9Bdr4RBk1ESg7IAsC0jPDbLfwQm1/C+c Vs28KRyiVuGQFX4WAAtvf02WIlX16rAJMp2xP+Lcw99tmmGR23UHOowD8ruvXfPOiplV cwhA== X-Gm-Message-State: ACrzQf0jSwk2Sbx3mdZXIOWqQnIih2zTOUr+trMTU40OyNrC67UusmJq qulVrnr8/B5XcCWL+pbwGm0DnQ== X-Google-Smtp-Source: AMsMyM44bd0wOVQGkOK1HTRrf1lPB4hqKLYjtFXHuqO7b/Lq1+31ewi/V4PVrd9aXjD0xaFjokKuyQ== X-Received: by 2002:a2e:5344:0:b0:26c:417b:aa78 with SMTP id t4-20020a2e5344000000b0026c417baa78mr3957120ljd.298.1664618282125; Sat, 01 Oct 2022 02:58:02 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id b8-20020a2eb908000000b00268335eaa8asm394308ljb.51.2022.10.01.02.58.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Oct 2022 02:58:01 -0700 (PDT) Message-ID: <76b3269a-1e04-1e93-c06e-ec0f28536cc5@linaro.org> Date: Sat, 1 Oct 2022 11:57:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/3] arm64: dts: qcom: sdm630: fix UART1 pin bias Content-Language: en-US To: Doug Anderson Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Rob Clark , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , "# 4.0+" References: <20220930182212.209804-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/09/2022 22:19, Doug Anderson wrote: > Hi, > > On Fri, Sep 30, 2022 at 11:22 AM Krzysztof Kozlowski > wrote: >> >> There is no "bias-no-pull" property. Assume intentions were disabling >> bias. >> >> Fixes: b190fb010664 ("arm64: dts: qcom: sdm630: Add sdm630 dts file") >> Cc: >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> Not tested on hardware. >> --- >> arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > This does change behavior and has the potential to break someone. > Thus, without a bug report or someone to give a tested-by I'm at least > moderately worried about this going to stable@ Indeed. I can drop Cc-stable, but AUTOSEL can still pick it up because of Fixes tag. Fixes tag is here important to indicate we are having a bug before. > > I would also note that convention on Qualcomm SoCs that I've worked on > was that bias shouldn't be specified in the SoC dtsi file and should > be left to board files. This is talked a bit about in a previous email > thread [1]. Uh, that makes a lot of sense. It is almost always a property of a board. > > That being said, it does look like this was the intention of the > original commit, so thus: > > Reviewed-by: Douglas Anderson Thanks. I can also drop the property entirely to match existing behavior (not the intention). > > [1] https://lore.kernel.org/lkml/CAD=FV=VUL4GmjaibAMhKNdpEso_Hg_R=XeMaqah1LSj_9-Ce4Q@mail.gmail.com/ Best regards, Krzysztof