From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0B546AA6 for ; Mon, 30 Oct 2023 07:34:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L+sMjL06" Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90A51B7 for ; Mon, 30 Oct 2023 00:34:39 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2c59a4dcdacso60392471fa.1 for ; Mon, 30 Oct 2023 00:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698651278; x=1699256078; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5pa4dby/8JwYM97NqAMx2Dp0QBnoAbYBFM9x+csgj/k=; b=L+sMjL06oPACtfBBiC9MTX6WoJ+UvTe9fwcn9Lu16jQqDrahTBGKqJZI76y8En6E78 PhzahJZeNOOSlcsmmS9ibQrJqeSIaYqhL03GxQFnW+EZN3Z3X0TwJgtw7gkaz6yWDWdl vUbKYv7B7XOpQamCha3V5m4Gj8t1FmoA0uvveOXqCDl6mtXEj1Yx7VOnpbTjQGk2+gHa n/YI4cfjHiy9wSDhPjK7AssfPAZrmq01yV918IQqxWlByC88eXWqdkm2CsZYDQfmEA6c mAgWXz1Kgog1ETsj3KPlW3GZSLZJMkPNdNFaQbyNEr5o9KwFZcAcPXAQzQn+MCSc7Ar0 9+lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698651278; x=1699256078; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5pa4dby/8JwYM97NqAMx2Dp0QBnoAbYBFM9x+csgj/k=; b=VUpLB8RYe6pMsJ/J3cMZXgsVBS8hqY0ISQP4Gmkuj1ot/4kJSDPM8UQtalrPxsGVAJ 98cuDDi/ueezE0Ym8+55H7baz30K6fKb94oQiSEWPXlCx6I+S4EAgsAG5mWOSrt0YieN MQWWMYh+Wd/RRDLHEQpKZttBaUpOn7WHS1xS/Urc3st1hrsy3DmErmJF5Hw0jSJVK/Ff RAQ6hBaJFcwRDLsiKc2ufnsu6Ci8D6eHLkkx/28wstSjhBksh1S8R4DkBaeBtx5YifVx SlNiKZp3VM8aWgmP+Nk335mkp4Kr4w6LytVQ+IDnDRYSpTALf6moEY7Xvo2amYrXrDoz rlsw== X-Gm-Message-State: AOJu0YzpOIYvIF+jbDl9oWu0rdSdWYo/3JZvfqgfZElfgw5zMc32MilK iCyhJXUJl9/GOeFDMGx/gq+jew== X-Google-Smtp-Source: AGHT+IFClab2CGOT7WcNzsudckLb5HVdvWSPDOayHaeqCCju9bD/roXblb+CT3A4N7R0t9lA+Is5Zg== X-Received: by 2002:a05:651c:1986:b0:2bc:b9c7:7ba8 with SMTP id bx6-20020a05651c198600b002bcb9c77ba8mr8159099ljb.43.1698651277734; Mon, 30 Oct 2023 00:34:37 -0700 (PDT) Received: from [192.168.1.20] ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id ay32-20020a05600c1e2000b004065daba6casm11907165wmb.46.2023.10.30.00.34.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 00:34:37 -0700 (PDT) Message-ID: <76b68a17-9cd8-4a65-bc56-2170fc7fd363@linaro.org> Date: Mon, 30 Oct 2023 08:34:34 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3][3/4] mmc: Add dw mobile mmc cmdq rtk driver Content-Language: en-US To: =?UTF-8?B?SnlhbiBDaG91IFvlkajoirflrold?= , Krzysztof Kozlowski , "adrian.hunter@intel.com" , "jh80.chung@samsung.com" , "ulf.hansson@linaro.org" Cc: "riteshh@codeaurora.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "asutoshd@codeaurora.org" , "p.zabel@pengutronix.de" , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , "briannorris@chromium.org" , "doug@schmorgal.com" , "tonyhuang.sunplus@gmail.com" , "abel.vesa@linaro.org" , "william.qiu@starfivetech.com" References: <20231020034921.1179-1-jyanchou@realtek.com> <20231020034921.1179-4-jyanchou@realtek.com> <5bc8fd15-9ae7-449d-9625-6e8c87876b06@kernel.org> <67ac1f7e28ba42d8a1d2315c26f26106@realtek.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <67ac1f7e28ba42d8a1d2315c26f26106@realtek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 30/10/2023 08:30, Jyan Chou [周芷安] wrote: > Hi Krzysztof, > >> Use Linux coding style. This driver looks like one for staging, not ready for submission. :/ > > We had modified our code to match Linux coding style. Unfortunately, not much... > >>> + mcq_writel(host, AHB, 0); >>> + dev_info(dev, "AHB=0x%x, dw_mci_cqe_suspend ret=%d\n", >>> + mcq_readl(host, AHB), ret); >> Drop useless success/function entry/exit messages.. > > We had drop useless function. > >> Why? This is not an error. If it were, then it should be build stage error. > > It was our mistake to use dev_err here, we had corrected it. I have no clue what you are referring to. Respond inline as requested by mailing list etiquette. > >> You should not need MODULE_ALIAS() in normal cases. If you need it, usually it means your device ID table is wrong. > > We had removed MODULE_ALIAS(). > Please check our new post below, thanks. > https://patchwork.kernel.org/project/linux-mmc/patch/20231030062749.2840-4-jyanchou@realtek.com/ Please rework the driver from scratch to look like Linux driver. It was not looking at the beginning at all. Best regards, Krzysztof