From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7D9C433EF for ; Wed, 29 Jun 2022 11:22:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231508AbiF2LWT (ORCPT ); Wed, 29 Jun 2022 07:22:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231431AbiF2LWS (ORCPT ); Wed, 29 Jun 2022 07:22:18 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AC8E2180E for ; Wed, 29 Jun 2022 04:22:17 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id lw20so31949381ejb.4 for ; Wed, 29 Jun 2022 04:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=fGm6fqw2YW1uqWu3gi81JCdQoxsdScWmBsLg22T2BVU=; b=nJqcmK32rXmYDaxAu0A68rmBBx9rPABWwX9p2A7NZpP+ZLL6aKO4FIeLsCpECAKhjm 25F8QrGZX9RFwhnxwJpL8T5R8iuTSdsaR6SDD1PAyEf4XhJQeJMENdVWOJgFiO33xTR7 MNPdXJhYeB2vs+DdeRFI8QgnhMobWNLfgLLYWb6LsaP726rT4axAhNRh0GH1NUScjYc8 2fyhnnEB7Xvzut0gaekMCTsgP+FSdmrdQcWnqolEa1S1GoDe91CzSklag/C+EYiD2FFT KVBQCTRg5+AQo6ke1aHUelccNEU6GwuDNFHA107QIJu3swMNNJrW618DIHi36xdLID08 CNeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fGm6fqw2YW1uqWu3gi81JCdQoxsdScWmBsLg22T2BVU=; b=p+0Zl0o5VeXeV9ZCbv1rtQGGX0ou3MTN39SpUoh0ZdobOeRL5ggFKtStvv7I7ApA2/ 4h4zwWmeOV3kwf9HewX7XnVOVgldaYq4LET8Q5nJStHT107DucUVQ3BG2X0saforqL1+ FJ4vk/6XeDFv1vdR3DUCbTLdLkPUg9LK/9F3F+m8R/BdzqjUyUFiUd2zRJ4r8g41qieJ DGJKqIJ/ufkxNOIg7Te61DLGYCrraMFtCTQN3qnDpPcPiDxD0O8zC4MOQieY62l01UQM r2zs6E2HaJxc5UasKet8XvyVf/pFgoAAM++qsB9VbkuOViPtMyK6nC3cLlgga55PxMxg 4mRA== X-Gm-Message-State: AJIora+5D9BiIA5R1EvvDAhPFqT8qo7GnJEPgGHKCj790IBuiuMc98SJ nON5/nB5rvYZqg3LWm/D0FvJgQ== X-Google-Smtp-Source: AGRyM1tY4YFMRcOCf8Nca7bLLqAbv0rjL4zX4VO3jEHFlqgoQp29S45c23YShV+h6KgaTGg6XPE53A== X-Received: by 2002:a17:906:58c6:b0:72a:3df5:813d with SMTP id e6-20020a17090658c600b0072a3df5813dmr1344460ejs.153.1656501735704; Wed, 29 Jun 2022 04:22:15 -0700 (PDT) Received: from [192.168.0.184] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id t23-20020a170906609700b006fed062c68esm7741787ejj.182.2022.06.29.04.22.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 04:22:15 -0700 (PDT) Message-ID: <76b8819f-df55-8b81-7f80-90d0694400d4@linaro.org> Date: Wed, 29 Jun 2022 13:22:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 1/4] dt-bindings: interconnect: qcom,msm8998-cpu-bwmon: add BWMON device Content-Language: en-US To: Rajendra Nayak , Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Rob Herring References: <20220629075250.17610-1-krzysztof.kozlowski@linaro.org> <20220629075250.17610-2-krzysztof.kozlowski@linaro.org> <7d1fe567-6dd7-a6e0-08bf-225e8d515931@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <7d1fe567-6dd7-a6e0-08bf-225e8d515931@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/06/2022 13:21, Rajendra Nayak wrote: > >> This BWMON device sits between >> CPU and Last Level Cache Controller. > > []... > >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - enum: >> + - qcom,sdm845-cpu-bwmon > > should this be qcom,sdm845-llcc-bwmon instead since it actually > tells us the llcc bw values? > That way perhaps the other one between llcc and DDR can be > qcom,sdm845-ddr-bwmon. > Good point, thanks. I'll change it. Best regards, Krzysztof