devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: linux-sh@vger.kernel.org
Cc: "Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Damien Le Moal" <dlemoal@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Rich Felker" <dalias@libc.org>,
	"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
	"Lee Jones" <lee@kernel.org>, "Helge Deller" <deller@gmx.de>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Chris Morgan" <macromorgan@hotmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Hyeonggon Yoo" <42.hyeyoo@gmail.com>,
	"David Rientjes" <rientjes@google.com>,
	"Vlastimil Babka" <vbabka@suse.cz>, "Baoquan He" <bhe@redhat.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Stephen Rothwell" <sfr@canb.auug.org.au>,
	"Guo Ren" <guoren@kernel.org>,
	"Javier Martinez Canillas" <javierm@redhat.com>,
	"Azeem Shaikh" <azeemshaikh38@gmail.com>,
	"Palmer Dabbelt" <palmer@rivosinc.com>,
	"Bin Meng" <bmeng@tinylab.org>,
	"Max Filippov" <jcmvbkbc@gmail.com>, "Tom Rix" <trix@redhat.com>,
	"Herve Codina" <herve.codina@bootlin.com>,
	"Jacky Huang" <ychuang3@nuvoton.com>,
	"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Michael Karcher" <kernel@mkarcher.dialup.fu-berlin.de>,
	"Sergey Shtylyov" <s.shtylyov@omp.ru>,
	"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
	linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-pci@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-fbdev@vger.kernel.org
Subject: [DO NOT MERGE v5 06/37] sh: kernel/setup Update DT support.
Date: Tue,  5 Dec 2023 18:45:25 +0900	[thread overview]
Message-ID: <76bbd45b22ef6cc1fa69369aff908c9c4e366860.1701768028.git.ysato@users.sourceforge.jp> (raw)
In-Reply-To: <cover.1701768028.git.ysato@users.sourceforge.jp>

Fix extrnal fdt initialize and bootargs.

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
---
 arch/sh/kernel/setup.c | 51 ++++++++++++++++++++++++++++--------------
 1 file changed, 34 insertions(+), 17 deletions(-)

diff --git a/arch/sh/kernel/setup.c b/arch/sh/kernel/setup.c
index 3d80515298d2..b299abff68e0 100644
--- a/arch/sh/kernel/setup.c
+++ b/arch/sh/kernel/setup.c
@@ -30,6 +30,7 @@
 #include <linux/memblock.h>
 #include <linux/of.h>
 #include <linux/of_fdt.h>
+#include <linux/libfdt.h>
 #include <linux/uaccess.h>
 #include <uapi/linux/mount.h>
 #include <asm/io.h>
@@ -74,7 +75,13 @@ extern int root_mountflags;
 #define RAMDISK_PROMPT_FLAG		0x8000
 #define RAMDISK_LOAD_FLAG		0x4000
 
+#if defined(CONFIG_OF) && !defined(CONFIG_USE_BUILTIN_DTB)
+#define CHOSEN_BOOTARGS
+#endif
+
+#ifndef CHOSEN_BOOTARGS
 static char __initdata command_line[COMMAND_LINE_SIZE] = { 0, };
+#endif
 
 static struct resource code_resource = {
 	.name = "Kernel code",
@@ -244,18 +251,18 @@ void __init __weak plat_early_device_setup(void)
 void __ref sh_fdt_init(phys_addr_t dt_phys)
 {
 	static int done = 0;
-	void *dt_virt;
+	void *fdt;
 
 	/* Avoid calling an __init function on secondary cpus. */
 	if (done) return;
 
 #ifdef CONFIG_USE_BUILTIN_DTB
-	dt_virt = __dtb_start;
+	fdt = __dtb_start;
 #else
-	dt_virt = phys_to_virt(dt_phys);
+	fdt = phys_to_virt(dt_phys);
 #endif
 
-	if (!dt_virt || !early_init_dt_scan(dt_virt)) {
+	if (!fdt || !early_init_dt_scan(fdt)) {
 		pr_crit("Error: invalid device tree blob"
 			" at physical address %p\n", (void *)dt_phys);
 
@@ -269,8 +276,20 @@ void __ref sh_fdt_init(phys_addr_t dt_phys)
 
 void __init setup_arch(char **cmdline_p)
 {
+#ifdef CONFIG_OF_EARLY_FLATTREE
+	if (IS_ENABLED(CONFIG_USE_BUILTIN_DTB)) {
+		/* Relocate Embedded DTB */
+		unflatten_and_copy_device_tree();
+	} else if (initial_boot_params) {
+		/* Reserve external DTB area */
+		memblock_reserve(__pa(initial_boot_params),
+				 fdt_totalsize(initial_boot_params));
+		unflatten_device_tree();
+	}
+#endif
 	enable_mmu();
 
+#ifndef CONFIG_OF
 	ROOT_DEV = old_decode_dev(ORIG_ROOT_DEV);
 
 	printk(KERN_NOTICE "Boot params:\n"
@@ -299,19 +318,25 @@ void __init setup_arch(char **cmdline_p)
 	bss_resource.start = virt_to_phys(__bss_start);
 	bss_resource.end = virt_to_phys(__bss_stop)-1;
 
-#ifdef CONFIG_CMDLINE_OVERWRITE
-	strscpy(command_line, CONFIG_CMDLINE, sizeof(command_line));
-#else
+#endif
+
+#ifndef CHOSEN_BOOTARGS
+#ifndef CONFIG_CMDLINE_OVERWRITE
 	strscpy(command_line, COMMAND_LINE, sizeof(command_line));
 #ifdef CONFIG_CMDLINE_EXTEND
 	strlcat(command_line, " ", sizeof(command_line));
 	strlcat(command_line, CONFIG_CMDLINE, sizeof(command_line));
 #endif
-#endif
-
+#else   /* !CONFIG_CMDLINE_OVERWRITE*/
+	strscpy(command_line, CONFIG_CMDLINE, sizeof(command_line));
+#endif  /* CONFIG_CMDLINE_OVERWRITE */
 	/* Save unparsed command line copy for /proc/cmdline */
 	memcpy(boot_command_line, command_line, COMMAND_LINE_SIZE);
 	*cmdline_p = command_line;
+#else	/* CHOSEN_BOOTARGS */
+	/* Use "/chosen/bootargs" specified in devicetree. */
+	*cmdline_p = boot_command_line;
+#endif
 
 	parse_early_param();
 
@@ -322,14 +347,6 @@ void __init setup_arch(char **cmdline_p)
 	/* Let earlyprintk output early console messages */
 	sh_early_platform_driver_probe("earlyprintk", 1, 1);
 
-#ifdef CONFIG_OF_EARLY_FLATTREE
-#ifdef CONFIG_USE_BUILTIN_DTB
-	unflatten_and_copy_device_tree();
-#else
-	unflatten_device_tree();
-#endif
-#endif
-
 	paging_init();
 
 	/* Perform the machine specific initialisation */
-- 
2.39.2


  parent reply	other threads:[~2023-12-05  9:55 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05  9:45 [DO NOT MERGE v5 00/37] Device Tree support for SH7751 based board Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 01/37] sh: passing FDT address to kernel startup Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 02/37] sh: Kconfig unified OF supported targets Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 03/37] sh: Enable OF support for build and configuration Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 04/37] dt-bindings: interrupt-controller: Add header for Renesas SH3/4 INTC Yoshinori Sato
2023-12-05 16:01   ` Krzysztof Kozlowski
2023-12-05  9:45 ` [DO NOT MERGE v5 05/37] sh: GENERIC_IRQ_CHIP support for CONFIG_OF=y Yoshinori Sato
2023-12-05  9:45 ` Yoshinori Sato [this message]
2023-12-05 13:14   ` [DO NOT MERGE v5 06/37] sh: kernel/setup Update DT support Arnd Bergmann
2023-12-05  9:45 ` [DO NOT MERGE v5 07/37] sh: Fix COMMON_CLK support in CONFIG_OF=y Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 08/37] clocksource: sh_tmu: CLOCKSOURCE support Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 09/37] dt-bindings: timer: renesas,tmu: add renesas,tmu-sh7750 Yoshinori Sato
2023-12-05 15:29   ` Geert Uytterhoeven
2023-12-05 16:07   ` Krzysztof Kozlowski
2023-12-05  9:45 ` [DO NOT MERGE v5 10/37] sh: Common PCI Framework driver support Yoshinori Sato
2023-12-05 13:05   ` Arnd Bergmann
2023-12-05  9:45 ` [DO NOT MERGE v5 11/37] pci: pci-sh7751: Add SH7751 PCI driver Yoshinori Sato
2023-12-05 13:26   ` Arnd Bergmann
2023-12-05 13:34     ` Geert Uytterhoeven
2023-12-05 21:48     ` Linus Walleij
2023-12-05  9:45 ` [DO NOT MERGE v5 12/37] dt-bindings: pci: pci-sh7751: Add SH7751 PCI Yoshinori Sato
2023-12-05 14:14   ` Geert Uytterhoeven
2023-12-05  9:45 ` [DO NOT MERGE v5 13/37] dt-bindings: clock: sh7750-cpg: Add renesas,sh7750-cpg header Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 14/37] clk: Compatible with narrow registers Yoshinori Sato
2023-12-05 10:10   ` Uwe Kleine-König
2023-12-05  9:45 ` [DO NOT MERGE v5 15/37] clk: renesas: Add SH7750/7751 CPG Driver Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 16/37] irqchip: Add SH7751 INTC driver Yoshinori Sato
2023-12-08 15:49   ` Thomas Gleixner
2023-12-05  9:45 ` [DO NOT MERGE v5 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema Yoshinori Sato
2023-12-05  9:59   ` Linus Walleij
2023-12-05 15:01   ` Geert Uytterhoeven
2023-12-05 16:04   ` Krzysztof Kozlowski
2023-12-05  9:45 ` [DO NOT MERGE v5 18/37] irqchip: SH7751 IRL external encoder with enable gate Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 19/37] dt-bindings: interrupt-controller: renesas,sh7751-irl-ext: Add json-schema Yoshinori Sato
2023-12-05 21:01   ` Rob Herring
2023-12-05  9:45 ` [DO NOT MERGE v5 20/37] serial: sh-sci: fix SH4 OF support Yoshinori Sato
2023-12-05 15:27   ` Geert Uytterhoeven
2023-12-05  9:45 ` [DO NOT MERGE v5 21/37] dt-bindings: serial: renesas,scif: Add scif-sh7751 Yoshinori Sato
2023-12-05 14:57   ` Geert Uytterhoeven
2023-12-05  9:45 ` [DO NOT MERGE v5 22/37] dt-bindings: display: smi,sm501: SMI SM501 binding json-schema Yoshinori Sato
2023-12-05 13:36   ` Rob Herring
2023-12-05 13:36   ` Arnd Bergmann
2023-12-05 15:56     ` Krzysztof Kozlowski
2023-12-05  9:45 ` [DO NOT MERGE v5 23/37] mfd: sm501: Convert platform_data to OF property Yoshinori Sato
2023-12-07 16:36   ` Lee Jones
2023-12-05  9:45 ` [DO NOT MERGE v5 24/37] dt-binding: sh: cpus: Add SH CPUs json-schema Yoshinori Sato
2023-12-05 15:07   ` Geert Uytterhoeven
2023-12-05  9:45 ` [DO NOT MERGE v5 25/37] dt-bindings: vendor-prefixes: Add iodata Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 26/37] dt-bindings: vendor-prefixes: Add smi Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 27/37] dt-bindings: ata: ata-generic: Add new targets Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 28/37] dt-bindings: soc: renesas: sh: Add SH7751 based target Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 29/37] sh: SH7751R SoC Internal peripheral definition dtsi Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 30/37] sh: add RTS7751R2D Plus DTS Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 31/37] sh: Add IO DATA LANDISK dts Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 32/37] sh: Add IO DATA USL-5P dts Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 33/37] sh: j2_mimas_v2.dts update Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 34/37] sh: Add dtbs target support Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 35/37] sh: RTS7751R2D Plus OF defconfig Yoshinori Sato
2023-12-05 13:01   ` Arnd Bergmann
2023-12-05  9:45 ` [DO NOT MERGE v5 36/37] sh: LANDISK " Yoshinori Sato
2023-12-05  9:45 ` [DO NOT MERGE v5 37/37] sh: j2_defconfig: update Yoshinori Sato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76bbd45b22ef6cc1fa69369aff908c9c4e366860.1701768028.git.ysato@users.sourceforge.jp \
    --to=ysato@users.sourceforge.jp \
    --cc=42.hyeyoo@gmail.com \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=azeemshaikh38@gmail.com \
    --cc=bhe@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=bmeng@tinylab.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dalias@libc.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=deller@gmx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=guoren@kernel.org \
    --cc=heiko@sntech.de \
    --cc=herve.codina@bootlin.com \
    --cc=javierm@redhat.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=kernel@mkarcher.dialup.fu-berlin.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kw@linux.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lpieralisi@kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=macromorgan@hotmail.com \
    --cc=magnus.damm@gmail.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=palmer@rivosinc.com \
    --cc=rdunlap@infradead.org \
    --cc=rientjes@google.com \
    --cc=robh+dt@kernel.org \
    --cc=s.shtylyov@omp.ru \
    --cc=sam@ravnborg.org \
    --cc=sboyd@kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=trix@redhat.com \
    --cc=tzimmermann@suse.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vbabka@suse.cz \
    --cc=ychuang3@nuvoton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).