From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C24BC433EF for ; Thu, 14 Apr 2022 07:33:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238640AbiDNHfY (ORCPT ); Thu, 14 Apr 2022 03:35:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240359AbiDNHfX (ORCPT ); Thu, 14 Apr 2022 03:35:23 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41C3256203 for ; Thu, 14 Apr 2022 00:32:59 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id bh17so8368897ejb.8 for ; Thu, 14 Apr 2022 00:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=rkD4Wf92TMGep0/30NQKr7VRz7II9sGrZbor54Q/xRk=; b=iN9ypiMERw5LppW8cGKW2C4wiIosRgrFUgiAzntqy98BwV3KiLvz8YHWdXEPfbAWR0 T2zV42oKntNo1RlRC+y9adviLE60XYLhRW4vd62wUizmPmRT7P/qj0+nDUejLIm3xvpB GWtD+janBmy2XM0vMj5SVD598QN1RbL8sv3536IoiomAjFkNn3U0z2sq3xYBtbllse3M qcyTVxGdH7hGJq99xeA4TH0oUmPoeWWmJ3vZKoK2bhpHn/XyCv15Lx3IS2HWFD4HX2kP k7gZSHoas+NooDlufDv95yksWuL3Nv5Nn4TE+W+WdHoDLQUSGIyd3s+6C/NaKPrIzKFK VoIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rkD4Wf92TMGep0/30NQKr7VRz7II9sGrZbor54Q/xRk=; b=VmJRP11IMP9uh0Kd6r3+KyA+HMHjEzQilLSRXnh6FmwFrAVuJ2fsuIFjJz5+oErd5I hpU+5Y7ekGLRMZulrHmQPD8PU74tbXQ2yN+r3CEQpev2pN4aDf92LlFUiFI8syz5fHs6 CHxbLMcBa9IFgk/cJwurLXGiE3gXDMsgl1PWttn/ESAbDjdqRfCSMjZmdwRf163Y0L68 CygwGqrMvYyzsPmnqh3Cw+in90UKTwcicahFx3o8l4y7Hx9os0U4yXnUgQw/zO+uBzHQ bCAWLXvTi3YKCaWKY6R6NDDpXZR12/HS3dzz06d2PIDiM2mSN00MKzUlnK097wG1NJa/ /k7A== X-Gm-Message-State: AOAM533+tOx9VOh1F52PIrQJn977qODOgVbYaaQ3lbIdcTiT7cZClGTH +PjfL2T1OHvO46IErLYxole3Aw== X-Google-Smtp-Source: ABdhPJyIhl5iB1oiTjY3Q/tXc13WAFkiAsoQlqVDVD1KjollmUpxx3kXZwJP7vY5xYASFKFZXckXwg== X-Received: by 2002:a17:907:a427:b0:6db:572b:df24 with SMTP id sg39-20020a170907a42700b006db572bdf24mr1233433ejc.193.1649921577860; Thu, 14 Apr 2022 00:32:57 -0700 (PDT) Received: from [192.168.0.209] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id n5-20020a1709061d0500b006e87591ca21sm364707ejh.192.2022.04.14.00.32.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 00:32:57 -0700 (PDT) Message-ID: <76ea346b-0645-97b5-f8fb-5b46b4bcc80b@linaro.org> Date: Thu, 14 Apr 2022 09:32:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/2] dt-bindings: dwc2: Add bindings for new Ingenic SoCs. Content-Language: en-US To: "H. Nikolaus Schaller" , Zhou Yanjie , Krzysztof Kozlowski Cc: Greg Kroah-Hartman , hminas@synopsys.com, Rob Herring , linux-usb@vger.kernel.org, linux-mips , Linux Kernel Mailing List , OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , dragancecavac@yahoo.com, dongsheng.qiu@ingenic.com, qipengzhen , rick.tyliu@ingenic.com, sernia.zhou@foxmail.com, zhenwenjin@gmail.com, reimu@sudomaker.com References: <1649788201-87620-1-git-send-email-zhouyanjie@wanyeetech.com> <1649788201-87620-2-git-send-email-zhouyanjie@wanyeetech.com> <6F03670F-9040-4560-AD78-CC7A03EC678F@goldelico.com> <0AE74BF9-46F1-44EC-8E5F-40EA12851AD0@goldelico.com> From: Krzysztof Kozlowski In-Reply-To: <0AE74BF9-46F1-44EC-8E5F-40EA12851AD0@goldelico.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/04/2022 21:30, H. Nikolaus Schaller wrote: > So we need "snps,dwc2" to get any driver match and I thought the "ingenic,jz4780-otg" is redundant. > > But maintainers convinced me to keep it as a dummy compatible in the .dtsi for potential future > specialization (which does not exist and seems not to be necessary). Isn't exactly the next patch 2/2 using such specialization? > Unless I can convince them > that this is never ever needed. Which is beyond my knowledge and almost everyone. > > So we can't remove the "snps,dwc2" here. > > Well, we can with more work elsewhere. > You have to extend the dwc2_of_match_table to include all ingenic devices. > > Therefore we now know 3 potential solutions: > a) remove "ingenic,jz4780-otg" from jz4780.dtsi (my proposal) > b) add "ingenic,jz4780-otg" to dwc2.yaml together with "snps,dwc2" (your proposal + my suggestion here) > c) add only "ingenic,jz4780-otg" to dwc2.yaml and extend the match table in drivers//usb/dwc2/params.c (new proposals) > > From consistency point of view I think variant b) is the right one. a) was rejected and c) only adds redundant code. c) was already proposed by Zhou, so if you think the code is not correct (the params for jz4780) maybe nack it there, so we will know that driver needs fixes. Best regards, Krzysztof