From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE111C19F21 for ; Thu, 28 Jul 2022 11:50:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236167AbiG1LuV (ORCPT ); Thu, 28 Jul 2022 07:50:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236520AbiG1LuT (ORCPT ); Thu, 28 Jul 2022 07:50:19 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C5D812617 for ; Thu, 28 Jul 2022 04:50:18 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id z25so2486409lfr.2 for ; Thu, 28 Jul 2022 04:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=7xpPHdGqf/twjarqLThIKnxxVR76bJ0+Y4hOdD6FTH0=; b=u9RxphfEhlesMJTgJ2DTHDXp2Is+k+Yy6xHKD/10S8uOdq7uzCt1W2XYvdxDzhXztZ c33fK2uiiX/zGMz54CexpA3Sllzj/9EaYd7ZV0sbG7JTAaljvjGU1o0APd4Tf+oiOuRi dHLO3+QXs45GLqryQq2oN147NTNMGzEGq8WTpGHCo77FZDgC80+mgbvsjE0aUcYNpe3Z Oc+XaUdhjtuENe6nqBnYhxu2KGzzP0NESPHglrlcTK54eC5hP5bC/NH54ZMrMawjUz1U gXwELDJTyehwB9Jv3q9JOyyXsvKF9aCL8TfoPxcXR2sXRYnOHNTbBtVazD49FNOqrXJI iOXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7xpPHdGqf/twjarqLThIKnxxVR76bJ0+Y4hOdD6FTH0=; b=IsxkqleIXO8wXZVeyYqSzY3lq96Lm/LR6Yf1TRtqbmCwoJCFc8jpty5UKgz5gykUBQ PVfy+frPgzFo4AjlZn1MP5ufMe/xhOL2nbQwTTzghzorLSagKKuf+jiiso6cbPaJs8Ju Qy9u4JSBv0MhsigqHgFLbAsOJyOsIKDy5MjyBOhYN2NPmM9smuYew90fOtScCEUl9QHR YBkHM/M1pp+yLXN0XKaO+iLdqF5nK0+zO+5OwWL5n0i0SQlX41/ey4qzfbiaKlksV6hy 6lmvKEKfUsAWDAgkydtxNpJfgHivqRGfAsfkKPB2D3fQt+iJS9KBf9awaJDXvN5ar/eA 2V/w== X-Gm-Message-State: AJIora+zOfRYPOprMKenBqavGbMURIHDVSyBQu8NZ3dLiZZ0bqjS6vh/ KAbf2iyOKtvFJCsS/Z1Qwex+Vg== X-Google-Smtp-Source: AGRyM1v/NiequENiAj7aR5vCW9GvvpY8xU5xz6IyBFp6PvvVx8Zz8iDfP8Up4QHmcWvCQ7F+NHVtWQ== X-Received: by 2002:a05:6512:3403:b0:481:60ae:7ebc with SMTP id i3-20020a056512340300b0048160ae7ebcmr10262663lfr.358.1659009016201; Thu, 28 Jul 2022 04:50:16 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id s6-20020a056512202600b0048a833a14edsm163625lfs.201.2022.07.28.04.50.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 04:50:15 -0700 (PDT) Message-ID: <76ed8999-c211-f8ea-c70c-21fddd75a896@linaro.org> Date: Thu, 28 Jul 2022 13:50:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 2/3] ARM: dts: qcom: msm8960: add references to USB1 Content-Language: en-US To: Shinjo Park Cc: David Heidelberg , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220728111635.30540-1-peremen@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220728111635.30540-1-peremen@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/07/2022 13:16, Shinjo Park wrote: > Use the same USB definition as qcom-apq8064.dtsi, tested on Casio GzOne. > > Signed-off-by: Shinjo Park > Reviewed-by: David Heidelberg Thank you for your patch. There is something to discuss/improve. Similar problems as with previous patch - thread your patches and how did you get review? > --- > arch/arm/boot/dts/qcom-msm8960.dtsi | 32 +++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi > index 991eb1948..a32073d61 100644 > --- a/arch/arm/boot/dts/qcom-msm8960.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -201,6 +202,37 @@ regulators { > }; > }; > > + usb1: usb@12500000 { > + compatible = "qcom,ci-hdrc"; > + reg = <0x12500000 0x200>, > + <0x12500200 0x200>; > + interrupts = ; > + clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>; > + clock-names = "core", "iface"; > + assigned-clocks = <&gcc USB_HS1_XCVR_CLK>; > + assigned-clock-rates = <60000000>; > + resets = <&gcc USB_HS1_RESET>; > + reset-names = "core"; > + phy_type = "ulpi"; > + ahb-burst-config = <0>; > + phys = <&usb_hs1_phy>; > + phy-names = "usb-phy"; > + status = "disabled"; status is the last property. > + #reset-cells = <1>; Best regards, Krzysztof