From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-108-mta232.mxroute.com (mail-108-mta232.mxroute.com [136.175.108.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BF5B137930 for ; Thu, 28 Mar 2024 19:16:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.175.108.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711653395; cv=none; b=O5BuVcPU5CFnYTyR5LXlvBExQp7QPj2Q2xBqFjQFrco0KDEhbbiiqSsf/H2BYG5iphVw3VbvYUfGIdJzOGVO6JmzrbEZAUBV4DwYiTXwDeQqaO8tjQjuwCoJKlZFgP0a+h6Dlv2I7REQH0Uu+ijRBjiP8IR97QUhAjAUS460Isg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711653395; c=relaxed/simple; bh=+P6JDdjJ1Ex7kuwioyIjjSETZSNuTHoLH51U4FVMcjg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nqp7rMarK5zAg4l2E3NpHJwPdDdHzeN4E+yI28vcwTlzet8R7U9Jng4RJaAA/SakShsh/iSHPQfpqCwyLhTMl+UyBheQA9GriQDLsGUB/z2oGCHF8+7ghByvvss07wu0h6OQ/3Yd8SRMWSh4tujgbwCXjbMERTiz2uFBL7Y+AN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com; spf=pass smtp.mailfrom=luigi311.com; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b=qwCXm9BF; arc=none smtp.client-ip=136.175.108.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=luigi311.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b="qwCXm9BF" Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta232.mxroute.com (ZoneMTA) with ESMTPSA id 18e867e00920003bea.00e for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 28 Mar 2024 19:16:28 +0000 X-Zone-Loop: 2fc1ebb26498716b307947ec60cc6fe53f5d7cad1b47 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tQJb1jl0+k5VWPtDnFdvdOzbEiK5LWRoPsu+EFTE44M=; b=qwCXm9BF5B/BKG1LMbYhN94yUV rAc3/t4oTkVHcORDV9B8HrlemSm+v5kD/t39rjI6ws/L1XXVKQc+i7KbjwCBB3NAAxMyt6oXQ1EfD IlhlxeC1iAParASXRSIBb+oE/zna2MuWrkPKPO3l9gROf39Fs21jOlpBJqFu10PqisHRKMl6kjNEs Jahj+QjNfU9EwqGze4OsIvNSOts0YMcTLDSyvubePtWWK2F9R9GVJI0nuN0jtfVHViTaIo6lOu3qn aRtavdTKoklJWGZYZx6JUB9w2wB3k9wPEXoOAViWsskP1Jok9Yibg6Z30Qwhewbeb2ybGBRRe9khs pEyvc0EQ==; Message-ID: <76f999a7-55e0-4676-aa75-8fcd466e046b@luigi311.com> Date: Thu, 28 Mar 2024 13:16:22 -0600 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 18/23] dt-bindings: media: imx258: Add alternate compatible strings Content-Language: en-US To: Rob Herring Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240327231710.53188-1-git@luigi311.com> <20240327231710.53188-19-git@luigi311.com> <20240328185526.GA88354-robh@kernel.org> From: Luigi311 In-Reply-To: <20240328185526.GA88354-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authenticated-Id: git@luigi311.com On 3/28/24 12:55, Rob Herring wrote: > On Wed, Mar 27, 2024 at 05:17:04PM -0600, git@luigi311.com wrote: >> From: Dave Stevenson >> >> There are a number of variants of the imx258 modules that can not >> be differentiated at runtime, so add compatible strings for them. >> But you are only adding 1 variant. I can not speak for Dave but as to why this was added here but looking at the imx296 yaml that has something similar where there are multiple variants that may not be detectable at run time but does not include similar verbiage in the main description. Should I drop this from the description so it matches the imx296? > >> >> Signed-off-by: Dave Stevenson >> Signed-off-by: Luigi311 >> --- >> .../devicetree/bindings/media/i2c/sony,imx258.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> index bee61a443b23..c7856de15ba3 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> @@ -14,10 +14,14 @@ description: |- >> type stacked image sensor with a square pixel array of size 4208 x 3120. It >> is programmable through I2C interface. Image data is sent through MIPI >> CSI-2. >> + There are a number of variants of the sensor which cannot be detected at >> + runtime, so multiple compatible strings are required to differentiate these. > > That's more reasoning/why for the patch than description of the h/w. > >> properties: >> compatible: >> - const: sony,imx258 >> + - enum: >> + - sony,imx258 >> + - sony,imx258-pdaf > > How do I know which one to use? Please define what PDAF means somewhere > as well as perhaps what the original/default variant is or isn't. Would it make sense to change the properties to include a description like so properties: compatible: enum: - sony,imx258 - sony,imx258-pdaf description: The IMX258 sensor exists in two different models, a standard variant (IMX258) and a variant with phase detection autofocus (IMX258-PDAF). The camera module does not expose the model through registers, so the exact model needs to be specified. > >> >> assigned-clocks: true >> assigned-clock-parents: true >> -- >> 2.42.0 >>