From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66B5A200D2 for ; Wed, 7 Feb 2024 07:52:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707292377; cv=none; b=NqRlNNfPBZ/mrlPgBoDX2bLlIZvBaec210gwlNdJXXWQsFjHJMK0573yLWDKeZtp1yTLKLSq53IxgmIqiaOGMSOpFIDT2vwTdl37A6yBpvK6n2weqyPbpCuZ7dTvCbfPKM8m17i4JuqgGe6tTKh6OnURdV2MLqealF11OOh61Zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707292377; c=relaxed/simple; bh=KPfQuWi/PXVkKmq8lELu0pIH64nc2bAJSKfva0E2W9U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TxkxWe29+AmLLIvFnv9E+OC1csz+4rHzW8jQslirBuMnSNQQrFAyfpRuwidges11EaYKw4NUEBmsKDJKM10ALIcQ+88yjZt7YKkPrtS03ILxAr1XCI3poYwyifRMycWvY+q/B9O7l0W4azqu2RIiHXZQ4AVCgPia2zN8lrxje2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CrYVyuUf; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CrYVyuUf" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-40fd280421aso2458305e9.3 for ; Tue, 06 Feb 2024 23:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707292373; x=1707897173; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4m7Si2JFAYJeO9yLW8w4qmaSrLD1aYrFf/y2zpA4ILM=; b=CrYVyuUfxRLAtVm1ZzXIYwEy1275dm5jMFkRtY0dWIVTMgknGcRD4ijz7xqeAU1S6n oldSlX+CCqrVUSe4DaN/0vPHm8QUnKQst5UHOk3lIUT5EtYkPDW9Um8RVKBMoMMbZgaF C8le9CCUsR8yr38ABUrtl/dtX1Y5LtkW+BC31XGhJ+OqGco010kj7qSOijaEfvPtU9fJ TUsTfsU4S+6TkponMNX/YMAzO2IbgTQOspWsawDmkGD0Q9ArZuzBUr9Nq5oQUmwSfSIB pZRVhXGk+SMgzOi8zQXhY65J/ksxONX7ZTMgdfDyKN78YBMkMkABww2QcfhiJgZO5WA8 s+Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707292373; x=1707897173; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4m7Si2JFAYJeO9yLW8w4qmaSrLD1aYrFf/y2zpA4ILM=; b=E2ohiAbSi8zU0UGrD1+cJ+SUwyPPvIzbMR1mcLJe/HrQvvWtAm5a5xdalv71JSOTQK FBa8FUXe9AL1TyhieOmMIklPYS3fUC5yj/Y6iAhNATzk4tNPfYo/nvuI91sSWr1uO3ar wGouAo4zXKxxbphpwhXO2Mg2MiXLtHT71VfrTNi/bdPG0JBgrcbLi3NN8xoGpvj9Qrqf pxZE0Y77up+nHqSR0m4O1+tfWq6yOVTLXgbNyX3yjL81StJwo61X19yB9wkzRt+CkAzQ I2uZg2bF6rV6w8ln9wqYFXDXfFXoPIop3/8PVMScGBUwNffc7dfX9C5pN9c6myG+YGgq 57Sw== X-Gm-Message-State: AOJu0YyVk1VQnDudemYwJ9R0rZp0UkmAZmyPeTIaYJ70OAwXdBJaL4yj my+LQPP7/9n7gDlEe9R5BJU7G2mswPEPHwZ6sFci1eQIQzwZJtGdHynLZyMpADQ= X-Google-Smtp-Source: AGHT+IH/aKBWw+eJLUYv8QGZd4sXrwuaM+XNWQReNDxtgKZa2iR4o45DsEoZsG80TSSFCTqcpInx/g== X-Received: by 2002:adf:e50b:0:b0:33b:4b01:cc94 with SMTP id j11-20020adfe50b000000b0033b4b01cc94mr1866833wrm.63.1707292373570; Tue, 06 Feb 2024 23:52:53 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXsFMp0lx84Jc2lvposEF66wvq1wewxRpxX3R80XKreT90wcFbPNlQ5oeJ35WcI+vCO7nNGO49KLQtPVAPGimHJB45pR17NRhFxm80WRhXFPeaMNdqMy7HXFJn9LueYfgDRYOFBK5quYUPIMEBg4Uf05jPudnwIqeMyM2rNjkYiiclDXirjviJu8B2IcPpuBiPHtuZdz/eMkIUnkHPmPKbaTHMIm0Y/HqmF8TSiIHd2T98eyIb4FfRlI+AS0Vbbusg1BBy/VsFhx7rqS6D883FqY/tu+3RLXomNY2/Soi9AP1q9cwc/6ImQnkLlDB+v6S2G/OaAKsWVgpV0hkmjmzuv41SNKcTwg6jEokw8ntxcOKKpOJrX3R/LmYSGuxTCYOYaDKd2k5hj6hsCVYKG5HNIC9gbegp5h8sHCZWma9BhlDsYovSmgncBYWvlDNmU0Dbilqv52C9wjwUdKAXb3OJexxRja5XkS1U7UXawP1yG3ppJTzOV9eU4zf2tm3ABJmTMLav8iXyy1Vjw8Z7LPKmDOLLZqph5riwKMTDMDgekdLLKq1GUMXwZmmVK7HD7nABYzM6DP1GE6fI6L02lu21ztK/A Received: from [192.168.1.20] ([178.197.222.62]) by smtp.gmail.com with ESMTPSA id d11-20020adff2cb000000b0033b278cf5fesm806286wrp.102.2024.02.06.23.52.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Feb 2024 23:52:53 -0800 (PST) Message-ID: <76f9aeed-9c8c-4bbf-98b5-98e9ee7dfff8@linaro.org> Date: Wed, 7 Feb 2024 08:52:51 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/2] dt-bindings: net: airoha,en8811h: Add en8811h serdes polarity Content-Language: en-US To: Eric Woudstra , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Heiner Kallweit , Russell King , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Daniel Golle , Lucien Jheng , Zhi-Jun You Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org References: <20240206194751.1901802-1-ericwouds@gmail.com> <20240206194751.1901802-2-ericwouds@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240206194751.1901802-2-ericwouds@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06/02/2024 20:47, Eric Woudstra wrote: > The en8811h phy can be set with serdes polarity reversed on rx and/or tx. > > Changed from rfc patch: > > Explicitly say what -rx and -tx means. I don't know what does it mean. This is v1, so we don't expect changelog. If this is v2 (because there was RFC/RFT/RFkisses/RFhugs which are states of patchsets, not versions), then please mark it as v2 and put changelog under ---. > > Signed-off-by: Eric Woudstra > --- > .../bindings/net/airoha,en8811h.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml > > diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml > new file mode 100644 > index 000000000000..99898e2bed64 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Airoha EN8811H PHY > + > +maintainers: > + - Eric Woudstra > + > +description: > + Bindings for Airoha EN8811H PHY Drop "Bindings for" and instead describe the hardware. You are duplicating now title. > + > +allOf: > + - $ref: ethernet-phy.yaml# > + > +properties: This won't match to anything... missing compatible. You probably want to align with ongoing work on the lists. > + airoha,pnswap-rx: > + type: boolean > + description: > + Reverse rx polarity of the SERDES. This is the receiving > + side of the lines from the MAC towards the EN881H. > + > + Only one blank line. > + airoha,pnswap-tx: > + type: boolean > + description: > + Reverse tx polarity of SERDES. This is the transmitting > + side of the lines from EN8811H towards the MAC. > + > +unevaluatedProperties: false > + > +examples: > + - | > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy1: ethernet-phy@1 { > + reg = <1>; > + airoha,pnswap-rx; You have broken indentation. Use 4 spaces for example indentation. > + }; > + }; Best regards, Krzysztof