From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900 Date: Sat, 09 Jul 2016 22:17:06 +0200 Message-ID: <7701071.Nr6sCmDkjL@wuerfel> References: <1466851042-22239-1-git-send-email-vw@iommu.org> <8706947.5rzUDVsB2F@wuerfel> <57806E9F.3020407@iommu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <57806E9F.3020407-6ukY98dZOFrYtjvyW6yDsg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wan Zongshun Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wan Zongshun , Daniel Lezcano , Russell King , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner List-Id: devicetree@vger.kernel.org On Saturday, July 9, 2016 11:25:19 AM CEST Wan Zongshun wrote: > On 2016=E5=B9=B406=E6=9C=8829=E6=97=A5 23:27, Arnd Bergmann wrote: > > On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote: > >> +#define IRQ_WDT W90X900_IRQ(1) > >> +#define IRQ_WWDT W90X900_IRQ(2) > >> +#define IRQ_LVD W90X900_IRQ(3) > >> +#define IRQ_EXT0 W90X900_IRQ(4) > >> +#define IRQ_EXT1 W90X900_IRQ(5) > >> +#define IRQ_EXT2 W90X900_IRQ(6) > >> +#define IRQ_EXT3 W90X900_IRQ(7) > >> +#define IRQ_EXT4 W90X900_IRQ(8) > >> +#define IRQ_EXT5 W90X900_IRQ(9) > >> +#define IRQ_EXT6 W90X900_IRQ(10) > > > > I'd suggest dropping the list, the contents are now in the dts. >=20 > Arnd, I will drop this file later, since old w90x900 plat still need = it. Sure. > but I will remove the Macros related to nuc970 and avoid nuc970=20 > interrupt using those Macro. >=20 > But I still need hack this irqs.h like below, since here NR_IRQS defi= ned=20 > and it is need for nuc970 irqchip driver. >=20 > #if !defined(CONFIG_SOC_NUC900) > #define NR_IRQS (IRQ_ADC+1) > #else > #define NR_IRQS 62 > #endif Have you considered using CONFIG_SPARSE_IRQ? That would avoid the need for setting NR_IRQS entirely, but may also require more work elsewhere. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html