From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED7D017107A for ; Tue, 30 Apr 2024 12:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714480431; cv=none; b=Dbic4nr7+YmX8SoVfkKwAQ3Lb4ZQkHC9DkNiFs0Ru8oj1K/idme255DIzf55EexwD35ZJ+vWFVED3JyleMkBDgURA03w20EphqesUwFZ0BEJlRSQPCJzNb7tZVpZzmSPdZijY+GJwibUhgnY5WnWJZUQTkSYw6/gjjxuvfRJyww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714480431; c=relaxed/simple; bh=8qRGv9BUyqVd6XtlXFdWfT5zPzODEmCn5lc+lyDQMQk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jDvfOXB4FduKq0/iwT3ASqTn/fOO1cAmzESOPenOkWr3jR0Mvywlh4NpgIJjKQ1MiABc5/oribYHRH4wRME09gl0V6iRmeU4cnaLOCG45IX4SSwbkVGvkRR7HY/JVZUXYuB+YDBw9vnK5DNE8qC0kF+ot/SedrJZ56yq+VnnkbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=Bg/I1oz7; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="Bg/I1oz7" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-516ced2f94cso1338102e87.1 for ; Tue, 30 Apr 2024 05:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1714480428; x=1715085228; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8JYnpful/x3DE6HE/Q8pSIRWAs5wjh2Z17X6El2O6XQ=; b=Bg/I1oz7Fb9DgA6vYFCZ/Y5HynGpEMOEpF5OzKXbUCynjMGP7QoDW3mpSl+/W3fH0V +al2uHC0RAAeo4MDgAjuPeEdsiBxvYu494vHrrL/nGpYJB5y28YRPWxvov6tCwYbOwAM /p4pwYuV2diJZ7QTBRVvfuzuyI/yjymKAELkrrKbDbh2l/O3vmxz2q0v1RnI3I5puG3G PQtwA2oznCVbXeUO4vxD7MDN1pLnp/O/2rF6rSk5mT+bmNgZTy3RrgjUVQYwkKnLsGN/ 8Q65S69a6A+lu5ZOP80/p9axP13UgzOR/8a3MJjERrXVWYLaASsDZdHx5SqZYrOnf150 7L6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714480428; x=1715085228; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8JYnpful/x3DE6HE/Q8pSIRWAs5wjh2Z17X6El2O6XQ=; b=NuFQf/4j5N2En9PDRF1J88qHd/jwq2Yamswebe30UXhg9ekm2CdhFE3NR8DK8nZWnk ueb1DG8ijNdhRkr5sD9Z60KO+Gp7L65IhKnglw6bZgioa74lxIGZl5ia/kRRfGMalrF1 Nl9neLAZEacdGyr89G+fa8HD6j1HX37QIhUpuIhsVgjYOdpkBW2rKaqNWtey0nLF45wd RIApcEMjxxLP3H6lHvRZlJXUhR1Q01GrCNHxHtW9A4aFoNffDTfONyvveIJ3M7yeih3o VazyVSG8Dp7F9DonfwHVGbQBfk7bSZdIy9XZsOKCEuUvfVBXc4R6q4gvmHTskgAqyz8L Acjw== X-Forwarded-Encrypted: i=1; AJvYcCUpF2it9fgq6axuSpowKrAhVtOO9/bx9gS57BBhozer9kPolp/id+nBe/jn5W6t98naH+uZkabHVPivN1JLr7QtZS7fpgT1nnBiIQ== X-Gm-Message-State: AOJu0YwuCfEtcqSnY9WeRzEF6AZDdcLFfkw6Oa94Pv8OWa0FnFNn2HYy j/ugYxyANCRX7T9do80kLvvrZrxa0dI6cM+IvwomE2ZU2QK3A04hVkYrZ5tP78E= X-Google-Smtp-Source: AGHT+IGh50yRx9fgD9SXLf1xEw2mn31RrUC8rB0v4vouvrUtYjpyhg94cyY1iBQpCTQRoHim5SrX3A== X-Received: by 2002:a2e:910a:0:b0:2dd:60d3:7664 with SMTP id m10-20020a2e910a000000b002dd60d37664mr8644774ljg.5.1714480428077; Tue, 30 Apr 2024 05:33:48 -0700 (PDT) Received: from ?IPV6:2a01:e0a:999:a3a0:c21b:67fd:90ab:9053? ([2a01:e0a:999:a3a0:c21b:67fd:90ab:9053]) by smtp.gmail.com with ESMTPSA id c1-20020a5d4141000000b003436cb45f7esm550771wrq.90.2024.04.30.05.33.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 05:33:47 -0700 (PDT) Message-ID: <770710b3-2495-41a6-9822-d9af9b13cef5@rivosinc.com> Date: Tue, 30 Apr 2024 14:33:46 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/11] riscv: add ISA extensions validation To: Conor Dooley Cc: Conor Dooley , Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rob Herring , Krzysztof Kozlowski , Anup Patel , Shuah Khan , Atish Patra , linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org References: <20240429150553.625165-1-cleger@rivosinc.com> <20240429150553.625165-3-cleger@rivosinc.com> <20240429-subtext-tabby-3a1532f058a5@spud> <5d5febd5-d113-4e8c-9535-9e75acf23398@rivosinc.com> <20240430-payable-famished-6711765d5ca4@wendy> <20240430-gratuity-refinish-29abb136c958@wendy> Content-Language: en-US From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= In-Reply-To: <20240430-gratuity-refinish-29abb136c958@wendy> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 30/04/2024 14:12, Conor Dooley wrote: > On Tue, Apr 30, 2024 at 01:58:11PM +0200, Clément Léger wrote: >> Yeah, see what you mean. I think we also need to define if we want to >> expose all the ISA extensions in /proc/cpuinfo (ie no matter the config >> of the kernel) or not. If so, additional validate() callback would make >> sense. If we want to keep the full ISA string in /proc/info, then we >> will need another way of doing so. > > If extensions aren't usable, they shouldn't be in /proc/cpuinfo either > as there's programs that parse that to figure out what they can use, > possibly even only checking a single cpu and using that as gospel. > That's why there's that per-hart-isa thing that was added by one of your > colleagues last year. Acked. So indeed, validate() callback for F/V dependent extensions makes sense. Clément