Devicetree
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzk@kernel.org>, Frank.Li@oss.nxp.com
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Wensheng Wang" <wenswang@yeah.net>,
	"Cosmo Chou" <chou.cosmo@gmail.com>,
	"Colin Huang" <u8813345@gmail.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Dixit Parmar" <dixitparmar19@gmail.com>,
	"Antoni Pokusinski" <apokusinski01@gmail.com>,
	"Eddie James" <eajames@linux.ibm.com>,
	"Thorsten Blum" <thorsten.blum@linux.dev>,
	"open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml
Date: Sun, 30 Aug 2026 08:38:10 -0700	[thread overview]
Message-ID: <77319f64-75d1-48d6-954d-7e1891362b08@roeck-us.net> (raw)
In-Reply-To: <20260830-alluring-goldfish-of-cubism-eef6db@quoll>

On 8/30/26 02:53, Krzysztof Kozlowski wrote:
> On Wed, Aug 26, 2026 at 05:14:19PM -0400, Frank.Li@oss.nxp.com wrote:
>> From: Frank Li <Frank.Li@nxp.com>
>>
>> Move ti,tmp103 binding from trivial-devices.yaml to ti,tmp102.yaml. Both
>> devices are single temperature sensors and update "#thermal-sensor-cells"
>> property to accept values 0 and 1 (passing no argument is equivalent to
>> passing 0 as the first argument)
> 
> Why updating the property? If there are single sensors, then what is the
> cell for?
> 

It registers as temperature sensor with the thermal subsystem. The documentation
of #thermal-sensor-cells states that the property is mandatory and "... Will be
0 on sensor nodes with only a single sensor". I don't claim to understand how
this is supposed to work, but the thermal subsystem code looking for it does
seem to suggest that the property is mandatory, even if there is only a single
sensor.

Thanks,
Guenter

>>
>> Fix below CHECK_DTBS warnings:
>> arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dtb: temperature-sensor@70 (ti,tmp103): '#thermal-sensor-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
>>
>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>> ---
>>   Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 5 +++--
>>   Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
>>   2 files changed, 3 insertions(+), 4 deletions(-)
> 
> Best regards,
> Krzysztof


  reply	other threads:[~2026-08-30 15:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 21:14 [PATCH 1/1] dt-bindings: hwmon: tmp102: move ti,tmp103 out of trivial-devices.yaml Frank.Li
2026-08-26 21:20 ` sashiko-bot
2026-08-30  9:53 ` Krzysztof Kozlowski
2026-08-30 15:38   ` Guenter Roeck [this message]
2026-08-30 20:53 ` Krzysztof Kozlowski
2026-08-31 18:03 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77319f64-75d1-48d6-954d-7e1891362b08@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Frank.Li@nxp.com \
    --cc=Frank.Li@oss.nxp.com \
    --cc=apokusinski01@gmail.com \
    --cc=chou.cosmo@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dixitparmar19@gmail.com \
    --cc=eajames@linux.ibm.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=thorsten.blum@linux.dev \
    --cc=u8813345@gmail.com \
    --cc=wenswang@yeah.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox