From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61EC4CCA47F for ; Tue, 5 Jul 2022 14:11:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233300AbiGEOLh (ORCPT ); Tue, 5 Jul 2022 10:11:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232956AbiGEOLS (ORCPT ); Tue, 5 Jul 2022 10:11:18 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C04E20BE2 for ; Tue, 5 Jul 2022 07:03:39 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id e12so20722492lfr.6 for ; Tue, 05 Jul 2022 07:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=FTByuoUDWjyR8an2g05CMGFWtHf96FEqLs3ngrwh6us=; b=GBKk4fxRrkRm2c6psUm6D/w0N6n06/W6BtHOUvFHVMUiEdDkUP1q3E7Hz3nQoPPBR8 5UWPpfePuVzE2M3m9X6CPurk2EYEJIF/Xsx3X51ML0Oqn+H48opY24dyLGyRx8NWnSJh eyBKLJTcWVBNh7YybUZ/q2k44/aNZmn7GyfZSJOPonRfHLLnopZ/Qu0w+4AI+sRHrgMB vwdx1u/Il43czbMCaBdZ8xbPZRCEsoOMXvR6wuGUVRjbfO2Ntdo47Y5e7zgLNK5qglbQ N44z5Esp4HfJ5zYyPBLLp4LQbUQVB+96Rg325ZjuoHsK4uWgnbMN7DG7I50n/ZM9MhBy 7ygg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=FTByuoUDWjyR8an2g05CMGFWtHf96FEqLs3ngrwh6us=; b=kWrzAnOpBd90mVRFacZv6N9huP3qDmmXM+SokbHmsiMHewEuu8vdbdug6iCDrsUHZt Ht/2h0q92mk0OK1wOFlXhlwVvMMHImJCMrOj5WLgyB33Cn/jh8ohFGFQ0cfKP3S7e3Xk BZa/bXGytVOXKpFDp9i5kUvL5vmlbgxfwz33OSGw7r2rVCpaIoygau9DKPTL8gDDgpDF yrBppu3Dg/HeTtFK5/dlzMhLEHi0FQm40V0ZmIqxvWhYOGV9VhQBPoh7ShZQ6mHf/v88 7reiQUVwSrLU91zXpBg8M2Txa06HF9KMXJesU3qgmXRqW9Gi8b6qJEFEwD/F5XrYLHrB Ajhg== X-Gm-Message-State: AJIora/oZcpNNaqw0WKtC4uBXTH6vdQjBcNbPoee5SgA/FCneThf4Xpo WqgdLNRlQQlYqMEnwcQOu1Hr0A== X-Google-Smtp-Source: AGRyM1uyOELuaksoAr9ygk7LHhzb3ah4SQdqixh/kdlutfggnui6spNPog9NnO2z+XbF/mcIT6CypA== X-Received: by 2002:ac2:4e10:0:b0:47f:9af2:9c64 with SMTP id e16-20020ac24e10000000b0047f9af29c64mr21115541lfr.109.1657029817605; Tue, 05 Jul 2022 07:03:37 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id d13-20020a056512368d00b00480fdbc1b01sm5301077lfs.64.2022.07.05.07.03.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 07:03:37 -0700 (PDT) Message-ID: <777026d0-578c-500f-7da4-0e81fc211df2@linaro.org> Date: Tue, 5 Jul 2022 16:03:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new property nxp,fspi-dll-slvdly Content-Language: en-US To: Han Xu , Bough Chen , "ashish.kumar@nxp.com" , "yogeshgaur.83@gmail.com" , "broonie@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "singh.kuldeep87k@gmail.com" , "tudor.ambarus@microchip.com" , "p.yadav@ti.com" , "michael@walle.cc" , "miquel.raynal@bootlin.com" , "richard@nod.at" , "vigneshr@ti.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" Cc: "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "festevam@gmail.com" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "zhengxunli@mxic.com.tw" References: <1657012303-6464-1-git-send-email-haibo.chen@nxp.com> <1657012303-6464-7-git-send-email-haibo.chen@nxp.com> <59d360ef-5374-c7a7-2995-854ab3715b25@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/07/2022 16:00, Han Xu wrote: >> So we probably misunderstood each other... looking at the driver it also explains >> the confusing. You encoded here register value which is pretty often wrong >> approach. >> >> This should be instead meaningful value for the user of the bindings, so usually >> using one of property units: >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com >> %2Fdevicetree-org%2Fdt- >> schema%2Fblob%2Fmain%2Fdtschema%2Fschemas%2Fproperty- >> units.yaml&data=05%7C01%7Chan.xu%40nxp.com%7C0ffe3d706e064f14382 >> 108da5e8a5add%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6379262 >> 45564450475%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV >> 2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Q4 >> SfVnBN%2BQ0vYKJzRf%2FXZkCA1WGyPV9doFcb%2BLSKx4w%3D&reserved=0 >> >> I think you could use here clock cycles or clock phase, but then it has to be obvious >> it is that unit. > > Hi Krzysztof, > > Let me clarify it, in the document a term "delay cell" was used to descript this register bit. Which document? The bindings (I cannot find it there)? Commit msg? > Each delay cell equals "1/32 clock phase", so the unit of delay cell is clock phase. The value user need set in DT just number to define how many delay cells needed. Your bindings did not say this at all. Best regards, Krzysztof