public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Rob Herring <robh@kernel.org>, Conor Dooley <conor@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: dt: writing-bindings: Extend compatible fallbacks guideline
Date: Mon, 27 Apr 2026 17:56:21 +0200	[thread overview]
Message-ID: <7776a506-62d0-4cca-ad36-70cae8573ed4@oss.qualcomm.com> (raw)
In-Reply-To: <20260427143750.GA2491314-robh@kernel.org>

On 27/04/2026 16:37, Rob Herring wrote:
> On Wed, Apr 15, 2026 at 03:46:41PM +0100, Conor Dooley wrote:
>> On Wed, Apr 15, 2026 at 10:21:14AM +0200, Krzysztof Kozlowski wrote:
>>> Extend the guidelines when to use fallback compatibles to cover to
>>> common review responses.  Devices are most likely compatible and should
>>> use fallbacks when having:
>>>
>>> 1. Compatible programming interface, meaning one is a subset, and Linux
>>>    device drivers can use the subset to correctly match/bind and still
>>>    operate with the subset features.
>>>
>>> 2. Device variant discovery through some means, like registers.
>>>
>>> Devices are incompatible and fallback is not suitable when that
>>> fallback cannot be used by the drivers to match/bind.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>> ---
>>>  Documentation/devicetree/bindings/writing-bindings.rst | 7 ++++++-
>>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/writing-bindings.rst b/Documentation/devicetree/bindings/writing-bindings.rst
>>> index 667816dd7d50..03e29e2d50af 100644
>>> --- a/Documentation/devicetree/bindings/writing-bindings.rst
>>> +++ b/Documentation/devicetree/bindings/writing-bindings.rst
>>> @@ -53,7 +53,12 @@ Properties
>>>     - DON'T use wildcards or device-family names in compatible strings.
>>>  
>>>     - DO use fallback compatibles when devices are the same as or a superset of
>>> -     prior implementations.
>>> +     prior implementations.  Fallback compatibles are applicable especially
>>> +     when sharing a programming interface or when able to discover the
>>> +     variants.
>>> +
>>> +   - DON'T add fake fallback compatibles when software cannot use such to match
>>> +     and bind to a device, and still operate correctly.
>>>  
>>>     - DO add new compatibles in case there are new features or bugs.
>>
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>
>>      - DO use the commit message explain why devices that may appear
>>        compatible in a diff (e.g. no differences in property use) but
>>        are not compatible, are not compatible.
> 
> Can you respin with Conor's addition.

Ack

Best regards,
Krzysztof

      reply	other threads:[~2026-04-27 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15  8:21 [PATCH] docs: dt: writing-bindings: Extend compatible fallbacks guideline Krzysztof Kozlowski
2026-04-15 14:46 ` Conor Dooley
2026-04-27 14:37   ` Rob Herring
2026-04-27 15:56     ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7776a506-62d0-4cca-ad36-70cae8573ed4@oss.qualcomm.com \
    --to=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox