From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD44AC41513 for ; Wed, 26 Jul 2023 19:05:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230221AbjGZTFp (ORCPT ); Wed, 26 Jul 2023 15:05:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230440AbjGZTFo (ORCPT ); Wed, 26 Jul 2023 15:05:44 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05E22E62 for ; Wed, 26 Jul 2023 12:05:43 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9891c73e0fbso14790466b.1 for ; Wed, 26 Jul 2023 12:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690398341; x=1691003141; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vc+YnquiSNW9jSHsyvSHU5isKp05LSU7F1ENa1rUcbM=; b=bhuVAMVfTt75c+eYp8niKiPd4/9xUfzc2utbmJ/BzL1C57dlAr/yriusVbbhwXfP4V ZPIEnsterWWdt8Rn4EFJXUYVri6EDFCwYuTIS1jDY9ZOkQYdiGxGnoYGGdc5dVcspGY0 ykDAgw6GYd/ibHTacjHZjt2hh2FBmDH9lyHysar7IJIxbXD/yvwqiihGaAED5CRKN4Uh E7GMTE5Wm5ISPH9gUPWZHOyI/Gj+C6abY6ofI+rzSr/j6qY4D6HiJ1CTlUjOymDBD7dh gvAKJjE3RrtWvExKe8+YI3EdawftzFIRPFcrxEL7s8jWBoIrD5ddpPS0NQU7KwLmWlJH 5CGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690398341; x=1691003141; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vc+YnquiSNW9jSHsyvSHU5isKp05LSU7F1ENa1rUcbM=; b=MIdgUFrJAhawSLmdIF/8aqjqxVfwc2ArJkDOMKScjmAn6EHrqWmovKkd3wHRmYBMSp A4th5Y/6bZAg3uNqpSD79mj0QzvlNRexskoFsyUX2UCC/IdI9/538R9qRrQlhT+/ga4Z NZ950Ymtl5HdeE9oKz42gC3Ht3X6yYa4eA4c2F2llKtB42R+K2156Mnb7stiCnmVxwnw fP/r6P5WacCZG8BDNFOZcWgFJIsykiofXPxXY7hVDby8+TbSa5rozQWmpIJx9hbaIVcf SMxQnSSJ9IKCUfzNjFfqSErtulH0La+DjpF+7i9zuBoPFO6WVMPgWCC+VxRd1B4DCCFO R67A== X-Gm-Message-State: ABy/qLauWzsnElbOQH/ZkASr4Il4yWBLeBNurDON+bI56G2ljbqhH6fi 2r/r/69OJKyHeqsh0FEejpO9rA== X-Google-Smtp-Source: APBJJlE6nZ0OxvOKRGUPIo74Ten0G5lDzCYi3OwLwybTm0cYwZKbYlDBbWbBJKRMB71Ro1jc4qHrKw== X-Received: by 2002:a17:907:a076:b0:99b:cdfd:fb44 with SMTP id ia22-20020a170907a07600b0099bcdfdfb44mr565067ejc.9.1690398341464; Wed, 26 Jul 2023 12:05:41 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id b10-20020a170906038a00b009929ab17bdfsm9949601eja.168.2023.07.26.12.05.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 12:05:41 -0700 (PDT) Message-ID: <778263e2-78f0-a679-e981-c8a7147028c6@linaro.org> Date: Wed, 26 Jul 2023 21:05:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] dt-bindings: hwmon: add renesas,isl28022 Content-Language: en-US To: Guenter Roeck , =?UTF-8?Q?Carsten_Spie=c3=9f?= , Jean Delvare , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20230726152235.249569-1-mail@carsten-spiess.de> <20230726152235.249569-3-mail@carsten-spiess.de> <82628237-e087-269e-9673-cf3873fe4b35@linaro.org> <4105d77e-e011-8df7-35bf-bbfca0b640da@roeck-us.net> <7a44e513-2b6b-aed3-3d71-e56bd0be2417@linaro.org> <7091e719-4d9f-246c-262a-02ad91fd790d@roeck-us.net> From: Krzysztof Kozlowski In-Reply-To: <7091e719-4d9f-246c-262a-02ad91fd790d@roeck-us.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/07/2023 20:59, Guenter Roeck wrote: > On 7/26/23 11:27, Krzysztof Kozlowski wrote: >> On 26/07/2023 20:19, Guenter Roeck wrote: >>>> >>>>> + enum: [1, 2, 4, 8] >>>>> + >>>>> + average: >>>>> + description: | >>>>> + Number of samples to be used to report voltage, current and power values. >>>>> + defaults to <0> when not set >>>>> + enum: [0, 1, 2, 4, 8, 16, 32, 64, 128] >>>> >>>> I am sure hwmon has some property for this. Are you sure it is called >>>> "average"? >>>> >>> >>> Something with samples. adi,power-sample-average is similar. Others >>> use average-samples, qcom,avg-samples, touchscreen-average-samples. >> >> So probably it's a time to come with something generic, e.g.: >> average-samples in some hwmon.yaml >> > > Maybe, but that is going to take a lot of time. Many configuration options > of hardware monitoring chips (such as the thermal sensor type, the ideality > factor of a thermal diode, or the number of pulses per revolution reported > by fans) are actually properties of the connected device, and Rob has made > clear that he expects such properties to be associated with the actual > device (fan, thermal sensor, etc). Sure, we can go then with usual vendor like property, so: renesas,average-samples Best regards, Krzysztof