From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v2] ARM: rockchip: convert smp bringup to CPU_METHOD_OF_DECLARE Date: Mon, 26 May 2014 21:20:15 +0200 Message-ID: <77845932.xlUTKoJDWT@phil> References: <1632873.urGeGsUMPH@diego> <1878147.CvhHSZhTas@diego> <20140526181315.GA27093@quad.lixom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20140526181315.GA27093-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Olof Johansson Cc: Mark Rutland , "arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Linux ARM Kernel , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala List-Id: devicetree@vger.kernel.org Am Montag, 26. Mai 2014, 11:13:15 schrieb Olof Johansson: > On Thu, Mar 27, 2014 at 01:06:32AM +0100, Heiko St=FCbner wrote: > > With the newly introduced CPU_METHOD_OF_DECLARE is not necessary an= ymore > > to reference the relevant smp_ops in the board file, but instead it= can > > simply be set by the enable-method property of the cpu nodes. > >=20 > > Signed-off-by: Heiko Stuebner >=20 > Applied, however: > > --- > >=20 > > changes since v1: > > - add a short description to the enable-method binding > > =20 > > Documentation/devicetree/bindings/arm/cpus.txt | 2 ++ > > arch/arm/boot/dts/rk3066a.dtsi | 1 + > > arch/arm/boot/dts/rk3188.dtsi | 1 + > > arch/arm/mach-rockchip/core.h | 2 -- > > arch/arm/mach-rockchip/platsmp.c | 3 ++- > > arch/arm/mach-rockchip/rockchip.c | 1 - > > 6 files changed, 6 insertions(+), 4 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/arm/cpus.txt > > b/Documentation/devicetree/bindings/arm/cpus.txt index 333f4ae..f52= a9ac > > 100644 > > --- a/Documentation/devicetree/bindings/arm/cpus.txt > > +++ b/Documentation/devicetree/bindings/arm/cpus.txt > > @@ -185,6 +185,8 @@ nodes to be present and contain the properties > > described below.>=20 > > "qcom,gcc-msm8660" > > "qcom,kpss-acc-v1" > > "qcom,kpss-acc-v2" > >=20 > > + "rockchip,rk3066-smp" - cpu-core handling of Socs > > + from Rockchip starting with rk3066 >=20 > Nobody else has a comment here, so I removed this one. >=20 > I noticed that the list is unsorted, in particular the new marvell en= tries > were appended instead of inserted at the right location, which caused= a > merge conflict. Sigh. I'll do a separate commit on top to sort the li= st, > since we seem to have the new out-of-order additions in our tree. I added the comment after Mark Rutland noted: "We should document what what these actually mean, so as to be a hardwa= re description and not a Linux internals description." But I'm fine with it either way :-) Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html