From: Steev Klimaszewski <steev@kali.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Shawn Guo <shawn.guo@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: c630: Polish i2c-hid devices
Date: Mon, 30 Nov 2020 11:25:45 -0600 [thread overview]
Message-ID: <77abcac1-daf6-adbd-7d02-00cd9b4ddf99@kali.org> (raw)
In-Reply-To: <20201130165924.319708-1-bjorn.andersson@linaro.org>
On 11/30/20 10:59 AM, Bjorn Andersson wrote:
> The numbering of the i2c busses differs from ACPI and a number of typos
> was made in the original patch. Further more the irq flags for the
> various resources was not correct and i2c3 only has one of the two
> client devices active in any one device.
>
> Also label the various devices, for easier comparison with the ACPI
> tables.
>
> Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 31 +++++++++++--------
> 1 file changed, 18 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index 047ac9c16874..399aef2a0951 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -264,23 +264,28 @@ &i2c3 {
> status = "okay";
> clock-frequency = <400000>;
>
> - hid@15 {
> + tsel: hid@15 {
> compatible = "hid-over-i2c";
> reg = <0x15>;
> hid-descr-addr = <0x1>;
>
> - interrupts-extended = <&tlmm 37 IRQ_TYPE_EDGE_RISING>;
> + interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c3_hid_active>;
> };
>
> - hid@2c {
> + tsc2: hid@2c {
> compatible = "hid-over-i2c";
> reg = <0x2c>;
> hid-descr-addr = <0x20>;
>
> - interrupts-extended = <&tlmm 37 IRQ_TYPE_EDGE_RISING>;
> + interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
>
> pinctrl-names = "default";
> - pinctrl-0 = <&i2c2_hid_active>;
> + pinctrl-0 = <&i2c3_hid_active>;
> +
> + status = "disabled";
> };
> };
>
> @@ -288,15 +293,15 @@ &i2c5 {
> status = "okay";
> clock-frequency = <400000>;
>
> - hid@10 {
> + tsc1: hid@10 {
> compatible = "hid-over-i2c";
> reg = <0x10>;
> hid-descr-addr = <0x1>;
>
> - interrupts-extended = <&tlmm 125 IRQ_TYPE_EDGE_FALLING>;
> + interrupts-extended = <&tlmm 125 IRQ_TYPE_LEVEL_LOW>;
>
> pinctrl-names = "default";
> - pinctrl-0 = <&i2c6_hid_active>;
> + pinctrl-0 = <&i2c5_hid_active>;
> };
> };
>
> @@ -304,7 +309,7 @@ &i2c11 {
> status = "okay";
> clock-frequency = <400000>;
>
> - hid@5c {
> + ecsh: hid@5c {
> compatible = "hid-over-i2c";
> reg = <0x5c>;
> hid-descr-addr = <0x1>;
> @@ -312,7 +317,7 @@ hid@5c {
> interrupts-extended = <&tlmm 92 IRQ_TYPE_LEVEL_LOW>;
>
> pinctrl-names = "default";
> - pinctrl-0 = <&i2c12_hid_active>;
> + pinctrl-0 = <&i2c11_hid_active>;
> };
> };
>
> @@ -426,7 +431,7 @@ codec {
> &tlmm {
> gpio-reserved-ranges = <0 4>, <81 4>;
>
> - i2c2_hid_active: i2c2-hid-active {
> + i2c3_hid_active: i2c2-hid-active {
> pins = <37>;
> function = "gpio";
>
> @@ -435,7 +440,7 @@ i2c2_hid_active: i2c2-hid-active {
> drive-strength = <2>;
> };
>
> - i2c6_hid_active: i2c6-hid-active {
> + i2c5_hid_active: i2c5-hid-active {
> pins = <125>;
> function = "gpio";
>
> @@ -444,7 +449,7 @@ i2c6_hid_active: i2c6-hid-active {
> drive-strength = <2>;
> };
>
> - i2c12_hid_active: i2c12-hid-active {
> + i2c11_hid_active: i2c11-hid-active {
> pins = <92>;
> function = "gpio";
>
Tested-by: Steev Klimaszewski <steev@kali.org>
prev parent reply other threads:[~2020-11-30 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 16:59 [PATCH] arm64: dts: qcom: c630: Polish i2c-hid devices Bjorn Andersson
2020-11-30 17:25 ` Steev Klimaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77abcac1-daf6-adbd-7d02-00cd9b4ddf99@kali.org \
--to=steev@kali.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).