From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tianyuan Jiang <code_0002@163.com>,
konrad.dybcio@oss.qualcomm.com, andersson@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tianyuan Jiang <hiez832670@gmail.com>
Subject: Re: [PATCH v6] arm64: dts: qcom: sm8550: add Xiaomi Pad 6S Pro (sheng)
Date: Tue, 21 Jul 2026 17:46:56 +0200 [thread overview]
Message-ID: <77d6127f-9f15-43d3-802f-c265c3062f11@kernel.org> (raw)
In-Reply-To: <20260721153444.423-1-code_0002@163.com>
On 21/07/2026 17:34, Tianyuan Jiang wrote:
> From: Tianyuan Jiang <hiez832670@gmail.com>
>
> Add device tree for Xiaomi Pad 6S Pro (sheng) based on SM8550.
>
> Signed-off-by: Tianyuan Jiang <code_0002@163.com>
>
> ---
> v6: address Sashiko AI review on v4
What is happening here? v2 was sent 1 hour ago and immediately this?
AGAIN, read submitting patches.
> - Fix cs35l43 reset-gpios polarity: use GPIO_ACTIVE_LOW
> - Add "kinetic,ktz8866" fallback compatible for backlight
> - Add map220v Signed-off-by (DCO chain fix)
> - Add assigned-clocks alongside assigned-clock-parents in mdss_dsi1
>
> v5: address additional Sashiko AI review on v3/v4
> - Add assigned-clocks alongside assigned-clock-parents in mdss_dsi1
> - Actually remove output-high from i2s1_default pinctrl (missed in v3)
>
> v4: address Sashiko AI review comments
> - Add GPIO_OPEN_DRAIN to shared cs35l43 reset-gpios to avoid -EBUSY
> - Set Bluetooth local-bd-address to [ 00 00 00 00 00 00 ]
>
> v3: address review comments from Konrad Dybcio
> - SM8550P has no modem; confirmed on device (dmesg shows no mpss)
> - Rename fingerprint_fpc -> fingerprint-reader, use interrupts-extended
> - pmic-glink compatibles: one per line
> - Sort DAI link subnodes alphabetically (codec before cpu)
> - Reorder root-level nodes by name
> - Place pinctrl-n properties before pinctrl-names
> - Remove msm-id, board-id, Xiaomi-specific comments
> - Remove output-low/output-high from TLMM pinctrl
> - Remove udmabuf bootargs (confirmed not in use on device)
> - Add "xiaomi-" prefix to firmware paths
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/sm8550-xiaomi-sheng.dts | 1761 +++++++++++++++++
> 2 files changed, 1762 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm8550-xiaomi-sheng.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 6f33c4e2f..d8e485521 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -386,6 +386,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8550-mtp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8550-qrd.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8550-samsung-q5q.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8550-sony-xperia-yodo-pdx234.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sm8550-xiaomi-sheng.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8650-ayaneo-pocket-s2.dtb
>
> sm8650-hdk-display-card-dtbs := sm8650-hdk.dtb sm8650-hdk-display-card.dtbo
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-xiaomi-sheng.dts b/arch/arm64/boot/dts/qcom/sm8550-xiaomi-sheng.dts
> new file mode 100644
> index 000000000..fa24b1c1b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8550-xiaomi-sheng.dts
> @@ -0,0 +1,1761 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2024, map220v <map220v300@gmail.com>
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/arm/qcom,ids.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +#include "sm8550.dtsi"
> +#include "pm8010.dtsi"
> +#include "pm8550.dtsi"
> +#include "pm8550b.dtsi"
> +#define PMK8550VE_SID 5
> +#include "pm8550ve.dtsi"
> +#include "pm8550vs.dtsi"
> +#include "pmk8550.dtsi"
> +
> +/delete-node/ &rmtfs_mem;
> +/delete-node/ &adspslpi_mem;
> +/delete-node/ &xbl_dt_log_merged_mem;
> +/delete-node/ &hwfence_shbuf;
> +
> +/* Free unused regions */
> +/delete-node/ &hyp_tags_reserved_mem;
> +/delete-node/ &cdsp_secure_heap_mem;
> +/delete-node/ &trust_ui_vm_mem;
> +/delete-node/ &trust_ui_vm_dump;
> +/delete-node/ &trust_ui_vm_qrtr;
> +/delete-node/ &trust_ui_vm_vblk0_ring;
> +/delete-node/ &trust_ui_vm_vblk1_ring;
> +/delete-node/ &trust_ui_vm_swiotlb;
> +/delete-node/ &oem_vm_vblk0_ring;
> +/delete-node/ &oem_vm_swiotlb;
> +/delete-node/ &oem_vm_mem;
> +/delete-node/ &hyp_ext_tags_mem;
> +/delete-node/ &hyp_ext_reserved_mem;
> +
> +/delete-node/ &qup_i2c8_data_clk;
> +
> +/delete-node/ &qup_i2c9_data_clk;
> +
> +/delete-node/ &mpss_dsm_mem;
> +/delete-node/ &mpss_mem;
> +/delete-node/ &q6_mpss_dtb_mem;
> +/delete-node/ &remoteproc_mpss;
> +
> +/ {
> + model = "Xiaomi Pad 6S Pro 12.4";
> + compatible = "xiaomi,sheng", "qcom,sm8550";
So you keep ignoring the problem and keep ignoring review. Not
responding, not fixing anything.
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-21 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 14:21 [PATCH v2] arm64: dts: qcom: sm8550: add Xiaomi Pad 6S Pro (sheng) code_0002
2026-07-21 14:41 ` Konrad Dybcio
2026-07-21 14:41 ` Konrad Dybcio
2026-07-21 14:49 ` sashiko-bot
2026-07-21 15:22 ` Krzysztof Kozlowski
2026-07-21 15:34 ` [PATCH v6] " Tianyuan Jiang
2026-07-21 15:46 ` Krzysztof Kozlowski [this message]
2026-07-21 15:52 ` sashiko-bot
2026-07-21 16:00 ` [PATCH v2] arm64: dts: qcom: sm8550: add xiaomi pad 6s pro (sheng) dts Tianyuan Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77d6127f-9f15-43d3-802f-c265c3062f11@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=code_0002@163.com \
--cc=devicetree@vger.kernel.org \
--cc=hiez832670@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox