From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20418C77B73 for ; Wed, 19 Apr 2023 08:57:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232819AbjDSI5K (ORCPT ); Wed, 19 Apr 2023 04:57:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232779AbjDSI5H (ORCPT ); Wed, 19 Apr 2023 04:57:07 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3629118DB for ; Wed, 19 Apr 2023 01:56:58 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id u3so27705605ejj.12 for ; Wed, 19 Apr 2023 01:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681894617; x=1684486617; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mFuzy4TuvFqYZVB9yIonpVvfyyHxImCxfwDErPMQgRg=; b=H/iMr/DovWLHt2YCjeW6aLfRxx2KGDYSy/hsKKdRIiNQKmpU9pgW72ZIATuskwh2gK GPWY+4ijiNsyeM+X4Dbf7/YsVp23JLhKLRC6kcInZXIlj+ZHf+E6rLY8R3slKcoER14e oolLGqzzPaJX8IkBrpJpwcP7ZQMMnl5zUgQca6wpzbKSkAPDcyqEDwds585KkzrMAQoO Dod9TgyryqBl6bb8iOWLH6zWlaYfhOcMN/q5of2nXEtHI1u52DMhLtJA5CSrFGAcLNy1 A+DJhj/85CcQFOg9iz3jbKKDywW0wP/I3HBB/u9J3zdFiuzvjTcqRuuxIG1RGNMdwrUJ SHRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681894617; x=1684486617; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mFuzy4TuvFqYZVB9yIonpVvfyyHxImCxfwDErPMQgRg=; b=gqbjeJ8V5z9tqdAa1ECtdtGifzqExzIxTeW59zxYHfIUnCe7gLk8+Kqw0/VtmpJ8WP iKltcLgKH0RFGOq5o+vy0vJ/O5GBh22xdJ43HIS/s0I3iqnX2Eb03QVVPKigKjMj+fJW wlYPJNdOTsB/dQm1cFwq/NGLFL7sMgKdD2pC8hDn4jONJ0ufKxpEj3LN4FBl/WV6B+Np cFYvR2+9YIw/lja5dijN2K0Qq9HF4HhnVKJHQZjCJ0hG9XGk9xMaruzLgJRNFEjgWmtl ba4k8pQ/lxxPtzFv56FzCwLquHT8HIeOVwlIwAUAQDvzPtiUFCsuj1eyYPMPkrm2YpeG GP4A== X-Gm-Message-State: AAQBX9eV5/zGed4ArenlaHcfwFsphmdTvXqtUMnYjTiSkNSPmid1A5Rj cl1Bl+NdfOYQr6TSZVVtLMYB+Q== X-Google-Smtp-Source: AKy350ZHhQqP60s84sOXg5hEoFCicZMMdVpYkZ1g5erVI/+cot6zkgX/52ioHeJ+kkdg+Elklcr+nw== X-Received: by 2002:a17:907:9805:b0:94f:3cf5:6d7f with SMTP id ji5-20020a170907980500b0094f3cf56d7fmr13114320ejc.46.1681894617176; Wed, 19 Apr 2023 01:56:57 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:62f5:eb43:f726:5fee? ([2a02:810d:15c0:828:62f5:eb43:f726:5fee]) by smtp.gmail.com with ESMTPSA id be5-20020a1709070a4500b0094f282fc29asm5844742ejc.207.2023.04.19.01.56.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 01:56:56 -0700 (PDT) Message-ID: <77d94fe0-75d2-8f64-19c6-fc19438ba71a@linaro.org> Date: Wed, 19 Apr 2023 10:56:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] dt-bindings: display: panel: add common definition of ports Content-Language: en-US To: Rob Herring Cc: Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Thierry Reding , Laurent Pinchart , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20230416153929.356330-1-krzysztof.kozlowski@linaro.org> <20230418222613.GA2408838-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20230418222613.GA2408838-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/04/2023 00:26, Rob Herring wrote: > On Sun, Apr 16, 2023 at 05:39:29PM +0200, Krzysztof Kozlowski wrote: >> Few panel bindings for dual-link connections just type "ports: true", >> which does not enforce any type. Add common definition of ports, so the >> type will be fixed. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> Cc: Konrad Dybcio >> --- >> .../bindings/display/panel/panel-common.yaml | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml >> index 5b38dc89cb21..ad62d34e6fa3 100644 >> --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml >> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml >> @@ -70,6 +70,16 @@ properties: >> port: >> $ref: /schemas/graph.yaml#/properties/port >> >> + # For dual-link connections >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + patternProperties: >> + "^port@[0-9a-f]+$": >> + $ref: /schemas/graph.yaml#/$defs/port-base > > This allows any undocumented property. Yes, which I hope the device schema (using this panel-common) will narrow with additionalProperties: false. I can make it explicit: additionalProperties: true. Otherwise, how do I allow custom properties like: Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml > >> + >> + required: >> + - port@0 >> + > > I don't think this should be added here because users must define what > each port is. With it here, we're going to validate the nodes twice as > well. Same can be said for 'port' though. It can't be extended though. So you propose to drop entire "ports" here and expect every panel schema to define it instead? Best regards, Krzysztof