From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Johan Hovold <johan@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com,
quic_jackp@quicinc.com, ahalaney@redhat.com,
quic_shazhuss@quicinc.com
Subject: Re: [PATCH v11 13/13] arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb controller
Date: Mon, 2 Oct 2023 11:47:52 +0200 [thread overview]
Message-ID: <77eff01f-082e-d7a7-2d6c-2abcc8665c59@linaro.org> (raw)
In-Reply-To: <e7e4fc1e-661a-fd62-e8b1-1e173cbfcd3e@quicinc.com>
On 9/14/23 17:45, Krishna Kurapati PSSNV wrote:
>
>
> On 9/13/2023 5:40 PM, Konrad Dybcio wrote:
>> On 7.09.2023 05:36, Krishna Kurapati PSSNV wrote:
>>>
>>>
>>>> Is there any benefit to removing the other ports?
>>>>
>>>> i.e. are ports 1-3 not parked properly by the dwc3 driver if
>>>> they're never connected to anything?
>>>>
>>> Hi Konrad,
>>>
>>> Whether or not the phy is connected to a port, the controller would
>>> modify the GUSB2PHYCFG/GUSB3PIPECTL registers. But if we don't
>>> specify only one phy and let phys from base DTSI take effect (4 HS /
>>> 2 SS), we would end up initializing and powering on phy's which are
>>> never connected to a port. To avoid that we need to specify only one
>>> phy for this platform.
>> And does that have any major effect on power use?
>>
>> Do these PHYs not have some dormant/low power mode?
>>
> Hi Konrad,
>
> I believe there will be some minimal power use. IMO its best to keep
> only one phy enabled for this variant instead of giving all and
> initializing/powering-on all 4 of them.
Okay let's not waste power..
Konrad
prev parent reply other threads:[~2023-10-02 9:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 13:30 [PATCH v11 00/13] Add multiport support for DWC3 controllers Krishna Kurapati
2023-08-28 13:30 ` [PATCH v11 01/13] dt-bindings: usb: qcom,dwc3: Add bindings for SC8280 Multiport Krishna Kurapati
2023-08-28 13:30 ` [PATCH v11 02/13] dt-bindings: usb: Add bindings for multiport properties on DWC3 controller Krishna Kurapati
2023-11-10 13:28 ` Johan Hovold
2023-11-11 8:30 ` Krishna Kurapati PSSNV
2023-11-11 9:47 ` Krishna Kurapati PSSNV
2023-11-11 10:55 ` Johan Hovold
2023-11-11 13:04 ` Krishna Kurapati PSSNV
2023-08-28 13:30 ` [PATCH v11 03/13] usb: xhci: Move extcaps related macros to respective header file Krishna Kurapati
2023-09-07 12:25 ` Mathias Nyman
2023-08-28 13:30 ` [PATCH v11 04/13] usb: dwc3: core: Access XHCI address space temporarily to read port info Krishna Kurapati
2023-10-02 17:10 ` Thinh Nguyen
2023-08-28 13:30 ` [PATCH v11 05/13] usb: dwc3: core: Skip setting event buffers for host only controllers Krishna Kurapati
2023-08-28 13:30 ` [PATCH v11 06/13] usb: dwc3: core: Refactor PHY logic to support Multiport Controller Krishna Kurapati
2023-09-01 1:13 ` Wesley Cheng
2023-09-01 21:54 ` Krishna Kurapati PSSNV
2023-09-19 17:26 ` kernel test robot
2023-10-02 17:19 ` Thinh Nguyen
2023-08-28 13:30 ` [PATCH v11 07/13] usb: dwc3: qcom: Add helper function to request threaded IRQ Krishna Kurapati
2023-09-28 21:48 ` Bjorn Andersson
2023-08-28 13:30 ` [PATCH v11 08/13] usb: dwc3: qcom: Refactor IRQ handling in QCOM Glue driver Krishna Kurapati
2023-08-28 13:30 ` [PATCH v11 09/13] usb: dwc3: qcom: Enable wakeup for applicable ports of multiport Krishna Kurapati
2023-08-28 13:30 ` [PATCH v11 10/13] usb: dwc3: qcom: Add multiport suspend/resume support for wrapper Krishna Kurapati
2023-09-15 13:48 ` Konrad Dybcio
2023-09-18 7:42 ` Krishna Kurapati PSSNV
2023-08-28 13:30 ` [PATCH v11 11/13] arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280 Krishna Kurapati
2023-08-28 13:30 ` [PATCH v11 12/13] arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB ports Krishna Kurapati
2023-09-13 12:11 ` Konrad Dybcio
2023-09-14 15:44 ` Krishna Kurapati PSSNV
2023-08-28 13:30 ` [PATCH v11 13/13] arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb controller Krishna Kurapati
2023-09-06 16:58 ` Konrad Dybcio
2023-09-07 3:36 ` Krishna Kurapati PSSNV
2023-09-13 12:10 ` Konrad Dybcio
2023-09-14 15:45 ` Krishna Kurapati PSSNV
2023-10-02 9:47 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77eff01f-082e-d7a7-2d6c-2abcc8665c59@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_jackp@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).