From: "Nuno Sá" <noname.nuno@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org>
Cc: nuno.sa@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v3 1/3] iio: temperature: ltc2983: convert to dev_err_probe()
Date: Mon, 04 Mar 2024 08:54:14 +0100 [thread overview]
Message-ID: <77fb1db27c1ad0731fa43852e64e7f9f19c0855e.camel@gmail.com> (raw)
In-Reply-To: <20240303121653.22f115c1@jic23-huawei>
On Sun, 2024-03-03 at 12:16 +0000, Jonathan Cameron wrote:
> On Fri, 01 Mar 2024 18:14:50 +0100
> Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote:
>
> > From: Nuno Sa <nuno.sa@analog.com>
> >
> > Use dev_err_probe() in the probe() path. While at it, made some simple
> > improvements:
> > * Declare a struct device *dev helper. This also makes the style more
> > consistent (some places the helper was used and not in other places);
> > * Explicitly included the err.h and errno.h headers;
> > * Removed an useless else if();
> > * Removed some unnecessary line breaks.
> >
> > Signed-off-by: Nuno Sa <nuno.sa@analog.com>
>
> I'd rather see a proposal for dev_errp_probe() than a local solution.
> We can fallback to local solution if it doesn't meet with approval!
>
I was kind of expecting that already :). I'll propose that for device.h. I guess
a simple macro should be enough...
- Nuno Sá
next prev parent reply other threads:[~2024-03-04 7:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 17:14 [PATCH v3 0/3] iio: temperature: ltc2983: small improvements Nuno Sa via B4 Relay
2024-03-01 17:14 ` [PATCH v3 1/3] iio: temperature: ltc2983: convert to dev_err_probe() Nuno Sa via B4 Relay
2024-03-03 12:16 ` Jonathan Cameron
2024-03-04 7:54 ` Nuno Sá [this message]
2024-03-01 17:14 ` [PATCH v3 2/3] dt-bindings: iio: temperature: ltc2983: document power supply Nuno Sa via B4 Relay
2024-03-04 10:22 ` Krzysztof Kozlowski
2024-03-01 17:14 ` [PATCH v3 3/3] iio: temperature: ltc2983: support vdd regulator Nuno Sa via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77fb1db27c1ad0731fa43852e64e7f9f19c0855e.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+nuno.sa.analog.com@kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox