From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C9D6C77B7F for ; Tue, 16 May 2023 16:28:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230057AbjEPQ2D (ORCPT ); Tue, 16 May 2023 12:28:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230154AbjEPQ2B (ORCPT ); Tue, 16 May 2023 12:28:01 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9A1C1FDC; Tue, 16 May 2023 09:27:44 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34GFIIiQ012006; Tue, 16 May 2023 18:27:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=udGhMp0O1RByLfJX0yGSSTgRBYNdT/tj2/Vqssv7rUQ=; b=wGS2V22FJvSUHZJ+1N42FintCjkXvCVioWPRDWbOFZMKfGnzD440SjC78P2z9hjt3lXo gVGi5IdUsFdu5JhQJAgCdD1Moy+4CPD4vPjbxqGZNg+XjHQcxxBxIFSnCD86b/pKvJv/ O+WMwmfAymAFXO//I0d+kH3EJZFApXUrTJ9+3ouC5X2yxw793IK5lcFO9VrUtYiwCm1n VnFWGPilUHvDxs9y1IA4VgHOhemBgCPo4D4tcXFdEFt8pme5zl/WUe1Kc+4HchXB7Paw z9HgsPcSUDe3XSr9Zgbkz2sHwWsxCNxBt55ttUiUJO2kKXEc8nXrviiqpz3h6ATikOUS rg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3qkgqx2dre-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 May 2023 18:27:35 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BEC1910002A; Tue, 16 May 2023 18:27:33 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id B1AE4235F07; Tue, 16 May 2023 18:27:33 +0200 (CEST) Received: from [10.252.0.230] (10.252.0.230) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 16 May 2023 18:27:33 +0200 Message-ID: <7839b9dc-0f33-0931-a552-ba4697f64150@foss.st.com> Date: Tue, 16 May 2023 18:27:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH] ARM: dts: stm32: remove typec port dtbs_check warning on stm32mp15xx-dkx Content-Language: en-US To: Fabrice Gasnier , , CC: , , , , References: <20230412151332.3037845-1-fabrice.gasnier@foss.st.com> From: Alexandre TORGUE In-Reply-To: <20230412151332.3037845-1-fabrice.gasnier@foss.st.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.252.0.230] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-16_08,2023-05-16_01,2023-02-09_01 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 4/12/23 17:13, Fabrice Gasnier wrote: > According to usb-connector.yaml, typec connector should always use: > - ports property > - with port@0 (required). > This is also true for a single HS port. This removes dtbs_check warning: > stusb1600@28: connector: Unevaluated properties are not allowed ('port' > was unexpected) > > Downside is it introduces another warning when building with W=1: > > Warning (graph_child_address): /soc/i2c@5c002000/stusb1600@28/connector/ > ports: graph node has single child node 'port@0', #address-cells > /#size-cells are not necessary > > By removing #address-cells/#size-cells as suggested, another couple of > W=1 warning shows up: > Warning (avoid_default_addr_size): /soc/i2c@5c002000/stusb1600@28/ > connector/ports/port@0: Relying on default #address-cells value > Warning (avoid_default_addr_size): /soc/i2c@5c002000/stusb1600@28/ > connector/ports/port@0: Relying on default #size-cells value > > Is there a clean way or necessary change to reach a clean build and clean > dtbs_check ? > Maybe this kind of concern has already been addressed ? > As far as I understand, the OF graph allows a single port {} node (e.g. > code being reworked here). Could this be added in relevant dtschema, to > address the single HS port use case (usb-connector.yaml) ? > Rob, Krzysztof, do you an idea to figure out this issue ? Thanks in advance Alex > Signed-off-by: Fabrice Gasnier > --- > arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi > index cefeeb00fc22..41e79c8cc752 100644 > --- a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi > +++ b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi > @@ -259,9 +259,14 @@ connector { > power-role = "dual"; > typec-power-opmode = "default"; > > - port { > - con_usbotg_hs_ep: endpoint { > - remote-endpoint = <&usbotg_hs_ep>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + con_usbotg_hs_ep: endpoint { > + remote-endpoint = <&usbotg_hs_ep>; > + }; > }; > }; > };