From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C09CC54EE9 for ; Wed, 7 Sep 2022 11:25:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbiIGLZz (ORCPT ); Wed, 7 Sep 2022 07:25:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbiIGLZy (ORCPT ); Wed, 7 Sep 2022 07:25:54 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AF3AB0B1B for ; Wed, 7 Sep 2022 04:25:53 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id b19so15566287ljf.8 for ; Wed, 07 Sep 2022 04:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=4OmTqg6On89kloMhcJgn+sZNlvyGPEamfza8yetGeeg=; b=MzVUvvfYQ1Sbi5uIeyJaz5aBQIeXkPxUwemtZnH51H/Y2ASy/GGBtYWCgKP8GIrdHk lv3RWBnycm9XaPWaXTxBv/llxoPR4lQ+awcmRBOoJN+oKSq3dhViXkSCfUU8iGE/x3Rd i/N1UoWuBQCW1gAnuR4evMlLkDOt89KJ62xEUnWmApu9kYebcd3mEwo2Z0jRIeq4gogf LQQ9FbUb6sx7CLC+Ie7Hmhy77xZNoIcpi46SIJTO6UYeEG4RfRUQmcChuwSzmDGqKFUg lBO/lt/hDCL161W327YK/WgeDiAAmPsAfKjYNrqqmbJg81lzSrruJi9074fgVGXEEdEo en8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=4OmTqg6On89kloMhcJgn+sZNlvyGPEamfza8yetGeeg=; b=1gJ5gNPd0vvThbdleOZOytAVwVqCZlqWFjyXllEHOA88quwmxLdIk831XCs63v3Ssy jeOUACcjtdVjL1KcFtMWbKujDiKg+nkiooqCrGrwWaOWE82OHnZi9eBa6gjAEQqZSxs7 uOipsvjIeTKGcBZ9MDxqCOtcFLfWkBE5o5ZI8M28qsUBh6ucrjzsOs1NlGio93tbA477 VqHyWH3dCN2FcXIWCaEEtBaVQKdCB/b1z+Yqcqoklw+maBsMQUhNxDHOgTao9mDLYDKI RwG4A7gAJVFJqwRENFMRQKVxkmilyqUtLQV8PnEvFzdpvTc66JAWL4U5tqzgX8KF8Z4W 9adA== X-Gm-Message-State: ACgBeo0CiYrGTjeOMFVCOioNHjTMfGwBU45pMgvqxUfL/pNwuZBKQ4F7 /k558YyTKUn+H8Ii0hvB82SbJg== X-Google-Smtp-Source: AA6agR7VLuw5g7GtGPZdFh8wzcqVqr0jMeu9LBMCFM3k2HFnQb6wcZFU9tGmtrHX1sTPInDXxtD0mQ== X-Received: by 2002:a2e:9e48:0:b0:261:c713:37dd with SMTP id g8-20020a2e9e48000000b00261c71337ddmr803889ljk.385.1662549951433; Wed, 07 Sep 2022 04:25:51 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id z10-20020a056512370a00b004979989028bsm999385lfr.147.2022.09.07.04.25.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Sep 2022 04:25:50 -0700 (PDT) Message-ID: <783df4f0-0b7e-8604-d61f-f78e0375c321@linaro.org> Date: Wed, 7 Sep 2022 13:25:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [Patch v2 15/15] arm64: dts: fsd: Add MFC related DT enteries Content-Language: en-US To: Smitha T Murthy , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, linux-fsd@tesla.com, aakarsh.jain@samsung.com References: <20220907064715.55778-1-smitha.t@samsung.com> <20220907064715.55778-16-smitha.t@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220907064715.55778-16-smitha.t@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/09/2022 08:47, Smitha T Murthy wrote: > Add MFC DT node and reserve memory node for MFC usage. > > Cc: linux-fsd@tesla.com > Signed-off-by: Smitha T Murthy > --- > arch/arm64/boot/dts/tesla/fsd-evb.dts | 4 ++++ > arch/arm64/boot/dts/tesla/fsd.dtsi | 22 ++++++++++++++++++++++ > 2 files changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts > index 1db6ddf03f01..17bb048f9d47 100644 > --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts > +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts > @@ -30,6 +30,10 @@ > }; > }; > > +&clock_mfc { > + status = "okay"; clock node was never disabled, so there is no need to enable it. > +}; > + > &fin_pll { > clock-frequency = <24000000>; > }; > diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi > index f35bc5a288c2..bca0ba030ee7 100644 > --- a/arch/arm64/boot/dts/tesla/fsd.dtsi > +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi > @@ -340,6 +340,18 @@ > #clock-cells = <0>; > }; > > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + mfc_left: region@84000000 { > + compatible = "shared-dma-pool"; > + no-map; > + reg = <0 0x84000000 0 0x8000000>; > + }; > + }; > + > soc: soc@0 { > compatible = "simple-bus"; > #address-cells = <2>; > @@ -832,6 +844,16 @@ > clock-names = "fin_pll", "mct"; > }; > > + mfc: mfc@12880000 { > + compatible = "samsung,fsd-mfc"; > + reg = <0x0 0x12880000 0x0 0x10000>; > + interrupts = ; > + clock-names = "mfc"; > + clocks = <&clock_mfc MFC_MFC_IPCLKPORT_ACLK>; > + memory-region = <&mfc_left>; > + status = "okay"; Okay is by default, don't add it. > + }; > + > ufs: ufs@15120000 { > compatible = "tesla,fsd-ufs"; > reg = <0x0 0x15120000 0x0 0x200>, /* 0: HCI standard */ Best regards, Krzysztof