From: Andrew Lunn <andrew@lunn.ch>
To: Tristram.Ha@microchip.com
Cc: Woojung Huh <woojung.huh@microchip.com>,
Vladimir Oltean <olteanv@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Marek Vasut <marex@denx.de>,
UNGLinuxDriver@microchip.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: dsa: microchip: Add SGMII port support to KSZ9477 switch
Date: Sat, 9 Nov 2024 16:13:24 +0100 [thread overview]
Message-ID: <784a33e2-c877-4d0e-b3a5-7fe1a04c9217@lunn.ch> (raw)
In-Reply-To: <20241109015633.82638-3-Tristram.Ha@microchip.com>
On Fri, Nov 08, 2024 at 05:56:33PM -0800, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <tristram.ha@microchip.com>
>
> The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct
> connect, 1 for 1000BaseT/1000BaseX SFP, and 2 for 10/100/1000BaseT SFP.
This naming is rather odd. First off, i would drop 'SFP'. It does not
have to be an SFP on the other end, it could be another switch for
example. 1 is PHY_INTERFACE_MODE_1000BASEX and 2 is
PHY_INTERFACE_MODE_SGMII.
> SFP is typically used so the default is 1. The driver can detect
> 10/100/1000BaseT SFP and change the mode to 2.
phylink will tell you want mode to use. I would ignore what the
hardware detects, so this driver is just the same as every other
driver, making it easier to maintain.
Andrew
next prev parent reply other threads:[~2024-11-09 15:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 1:56 [PATCH net-next 0/2] net: dsa: microchip: Add SGMII port support to KSZ9477 switch Tristram.Ha
2024-11-09 1:56 ` [PATCH net-next 1/2] dt-bindings: " Tristram.Ha
2024-11-09 10:43 ` Krzysztof Kozlowski
2024-11-12 2:45 ` Tristram.Ha
2024-11-09 1:56 ` [PATCH net-next 2/2] " Tristram.Ha
2024-11-09 15:13 ` Andrew Lunn [this message]
2024-11-12 2:55 ` Tristram.Ha
2024-11-12 13:50 ` Andrew Lunn
2024-11-13 2:12 ` Tristram.Ha
2024-11-13 14:42 ` Vladimir Oltean
2024-11-15 1:53 ` Tristram.Ha
2024-11-14 1:43 ` Andrew Lunn
2024-11-15 2:00 ` Tristram.Ha
2024-11-15 18:08 ` Andrew Lunn
2024-11-09 15:43 ` Andrew Lunn
2024-11-12 2:58 ` Tristram.Ha
2024-11-10 15:50 ` Vladimir Oltean
2024-11-12 2:43 ` Tristram.Ha
2024-11-29 12:59 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=784a33e2-c877-4d0e-b3a5-7fe1a04c9217@lunn.ch \
--to=andrew@lunn.ch \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox