From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90480C5479D for ; Mon, 9 Jan 2023 15:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237171AbjAIPur (ORCPT ); Mon, 9 Jan 2023 10:50:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235575AbjAIPuT (ORCPT ); Mon, 9 Jan 2023 10:50:19 -0500 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCB561A079; Mon, 9 Jan 2023 07:50:02 -0800 (PST) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 309FnKbk021502; Mon, 9 Jan 2023 09:49:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1673279360; bh=tHZZefyYne34nwtHlmcO9279ZiTFZKklHDR4wSaraLs=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=MPUiZGBLs/Ku6SlSm3Fh+yFJcoGIXbBdA2icjuIIZ3bG28Lf4hxlbusjtBtW3r+j1 d+ESwERr6zuKSVhU4PuUTfDVFIQp3yL6qzK+Rp5rdyZvl3hNXAGClH9q8f6DuClU8d KyAqikzfsRBeqcXaHluWkpbzVG7Qm/XmCoIq+OSg= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 309FnKl1105964 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 9 Jan 2023 09:49:20 -0600 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Mon, 9 Jan 2023 09:49:19 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Mon, 9 Jan 2023 09:49:19 -0600 Received: from [10.250.234.21] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 309Fn9qV038794; Mon, 9 Jan 2023 09:49:10 -0600 Message-ID: <784cc3a5-8b10-aed3-b151-77cedb531f25@ti.com> Date: Mon, 9 Jan 2023 21:19:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 3/4] dt-bindings: panel: Introduce dual-link LVDS panel Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Tomi Valkeinen , Jyri Sarha , David Airlie , Daniel Vetter , Laurent Pinchart , Thierry Reding , Sam Ravnborg , Maxime Ripard , Liam Girdwood , Mark Brown , Lad Prabhakar , Paul Walmsley , Palmer Dabbelt , Albert Ou , Matthias Brugger , Guo Ren CC: DRI Development List , Devicetree List , Linux Kernel List , Linux RISC-V List , Linux ARM Kernel List , Linux Mediatek List , Linux C-SKY Arch List , Nishanth Menon , Vignesh Raghavendra , Rahul T R , Devarsh Thakkar , Jai Luthra , Jayesh Choudhary References: <20230103064615.5311-1-a-bhatia1@ti.com> <20230103064615.5311-4-a-bhatia1@ti.com> <85837957-f6d2-4722-7693-98c6cf932096@linaro.org> <32d66fb7-6c63-0985-222f-0bd3c36c165d@ti.com> <30423568-df03-1d72-81fe-3a4b33214e5c@linaro.org> From: Aradhya Bhatia In-Reply-To: <30423568-df03-1d72-81fe-3a4b33214e5c@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On 03-Jan-23 16:58, Krzysztof Kozlowski wrote: > On 03/01/2023 12:02, Aradhya Bhatia wrote: >> But this is throwing an error. I am confused what else could be done. >> Can you please suggest what might be a more accurate check here? >> >>> >>>> + required: >>>> + - dual-lvds-odd-pixels >>>> + then: >>>> + properties: >>>> + port@1: >>>> + properties: >>>> + dual-lvds-even-pixels: true >>>> + dual-lvds-odd-pixels: false >>> >>> Why do you need this? Your oneOf before already solves it. >> >> I agree with your comment here. It makes sense to only have >> >> dual-lvds-even-pixels: true >> >> and have the oneOf condition take care of the other. But, I just tested >> this and it was unable to pick-up this intentionally-added error. >> >> I added 'dual-lvds-odd-pixels' property to both the nodes, and >> dt_binding_check passes successfully (which it should have not.) >> >> Instead, if I only keep this, >> >> dual-lvds-odd-pixels: false >> >> then the dt_binding_check detects the error as it should. >> >> Regardless, I am curious why the first method doesn't work. Will try to >> explore more on that. > > The check for presence of properties is only against required:, but you > added there properties. Like this: > > https://elixir.bootlin.com/linux/v5.17-rc2/source/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml#L155 > > > Other way is to drop your both oneOf and entire allOf from ports and use: > > oneOf: > - properties: > ports: > $ref: /schemas/graph.yaml#/properties/ports > properties: > port@0: > required: > - dual-lvds-odd-pixels > port@1: > required: > - dual-lvds-even-pixels > - properties: > ports: > $ref: /schemas/graph.yaml#/properties/ports > properties: > port@1: > required: > - dual-lvds-odd-pixels > port@0: > required: > - dual-lvds-even-pixels > Thank you for the suggestions. I tested the both of them, and they seem to be working as expected. V2 will reflect all the required fixes. Regards Aradhya